chore(roll): roll Playwright to 1.33.0-beta-1682447195000 (#1880)

Author: mxschmitt

README.md

@@ -4,9 +4,9 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H
 
 |          | Linux | macOS | Windows |
 |   :---   | :---: | :---: | :---:   |
-| Chromium <!-- GEN:chromium-version -->113.0.5672.24<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| Chromium <!-- GEN:chromium-version -->113.0.5672.53<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 | WebKit <!-- GEN:webkit-version -->16.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
-| Firefox <!-- GEN:firefox-version -->111.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| Firefox <!-- GEN:firefox-version -->112.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 
 ## Documentation
 

playwright/_impl/_network.py

@@ -366,10 +366,17 @@ async def fetch(
         headers: Dict[str, str] = None,
         postData: Union[Any, str, bytes] = None,
         maxRedirects: int = None,
+        timeout: float = None,
     ) -> "APIResponse":
         page = self.request.frame._page
         return await page.context.request._inner_fetch(
-            self.request, url, method, headers, postData, maxRedirects=maxRedirects
+            self.request,
+            url,
+            method,
+            headers,
+            postData,
+            maxRedirects=maxRedirects,
+            timeout=timeout,
         )
 
     async def fallback(

playwright/_impl/_stream.py

@@ -28,7 +28,7 @@ def __init__(
     async def save_as(self, path: Union[str, Path]) -> None:
         file = await self._loop.run_in_executor(None, lambda: open(path, "wb"))
         while True:
-            binary = await self._channel.send("read")
+            binary = await self._channel.send("read", {"size": 1024 * 1024})
             if not binary:
                 break
             await self._loop.run_in_executor(

playwright/async_api/_generated.py

@@ -30,7 +30,7 @@
     InWheel = None
 from wheel.bdist_wheel import bdist_wheel as BDistWheelCommand
 
-driver_version = "1.33.0-alpha-apr-12-2023"
+driver_version = "1.33.0-beta-1682447195000"
 
 
 def extractall(zip: zipfile.ZipFile, path: str) -> None:

playwright/sync_api/_generated.py

@@ -482,15 +482,15 @@ async def test_click_the_button_with_offset_with_page_scale(
 
     await page.click("button", position={"x": 20, "y": 10})
     assert await page.evaluate("result") == "Clicked"
-    expected = {"x": 28, "y": 18}
-    if is_webkit:
-        # WebKit rounds up during css -> dip -> css conversion.
-        expected = {"x": 26, "y": 17}
-    elif is_chromium:
-        # Chromium rounds down during css -> dip -> css conversion.
-        expected = {"x": 27, "y": 18}
-    assert await page.evaluate("pageX") == expected["x"]
-    assert await page.evaluate("pageY") == expected["y"]
+
+    def _assert_close_to(expected: int, actual: int) -> None:
+        if abs(expected - actual) > 2:
+            raise AssertionError(f"Expected: {expected}, received: {actual}")
+
+    # Expect 20;10 + 8px of border in each direction. Allow some delta as different
+    # browsers round up or down differently during css -> dip -> css conversion.
+    _assert_close_to(28, await page.evaluate("pageX"))
+    _assert_close_to(18, await page.evaluate("pageY"))
     await context.close()
 
 
@@ -676,7 +676,15 @@ async def click():
 
 async def test_wait_for_select_to_be_enabled(page, server):
     await page.set_content(
-        '<select onclick="javascript:window.__CLICKED=true;" disabled><option selected>Hello</option></select>'
+        """
+        <select disabled><option selected>Hello</option></select>
+        <script>
+        document.querySelector('select').addEventListener('mousedown', event => {
+            window.__CLICKED=true;
+            event.preventDefault();
+        });
+        </script>
+    """
     )
     done = []
 

setup.py

@@ -918,9 +918,9 @@ async def test_frame_goto_should_continue_after_client_redirect(page, server):
     url = server.PREFIX + "/frames/child-redirect.html"
 
     with pytest.raises(Error) as exc_info:
-        await page.goto(url, timeout=2500, wait_until="networkidle")
+        await page.goto(url, timeout=5000, wait_until="networkidle")
 
-    assert "Timeout 2500ms exceeded." in exc_info.value.message
+    assert "Timeout 5000ms exceeded." in exc_info.value.message
     assert (
         f'navigating to "{url}", waiting until "networkidle"' in exc_info.value.message
     )

tests/async/test_click.py

@@ -14,10 +14,33 @@
 
 import asyncio
 
+import pytest
+
 from playwright.async_api import Page, Route
 from tests.server import Server
 
 
+async def test_should_support_timeout_option_in_route_fetch(server: Server, page: Page):
+    server.set_route(
+        "/slow",
+        lambda request: (
+            request.responseHeaders.addRawHeader("Content-Length", "4096"),
+            request.responseHeaders.addRawHeader("Content-Type", "text/html"),
+            request.write(b""),
+        ),
+    )
+
+    async def handle(route: Route):
+        with pytest.raises(Exception) as error:
+            await route.fetch(timeout=1000)
+        assert "Request timed out after 1000ms" in error.value.message
+
+    await page.route("**/*", lambda route: handle(route))
+    with pytest.raises(Exception) as error:
+        await page.goto(server.PREFIX + "/slow", timeout=2000)
+    assert "Timeout 2000ms exceeded" in error.value.message
+
+
 async def test_should_not_follow_redirects_when_max_redirects_is_set_to_0_in_route_fetch(
     server: Server, page: Page
 ):

tests/async/test_navigation.py

@@ -137,6 +137,9 @@ async def test_workers_should_clear_upon_cross_process_navigation(server, page):
     assert len(page.workers) == 0
 
 
+@pytest.mark.skip_browser(
+    "firefox"
+)  # https://github.com/microsoft/playwright/issues/21760
 async def test_workers_should_report_network_activity(page, server):
     async with page.expect_worker() as worker_info:
         await page.goto(server.PREFIX + "/worker/worker.html")
@@ -155,6 +158,9 @@ async def test_workers_should_report_network_activity(page, server):
     assert response.ok
 
 
+@pytest.mark.skip_browser(
+    "firefox"
+)  # https://github.com/microsoft/playwright/issues/21760
 async def test_workers_should_report_network_activity_on_worker_creation(page, server):
     # Chromium needs waitForDebugger enabled for this one.
     await page.goto(server.EMPTY_PAGE)