cleanup: use [] and {} instead classes (#98)

Author: mxschmitt

playwright/browser.py

@@ -37,7 +37,7 @@ def __init__(self, scope: ConnectionScope, guid: str, initializer: Dict) -> None
         self._is_connected = True
         self._is_closed_or_closing = False
 
-        self._contexts: List[BrowserContext] = list()
+        self._contexts: List[BrowserContext] = []
         self._channel.on("close", lambda _: self._on_close())
 
     def _on_close(self) -> None:

playwright/browser_context.py

@@ -43,10 +43,10 @@ class BrowserContext(ChannelOwner):
 
     def __init__(self, scope: ConnectionScope, guid: str, initializer: Dict) -> None:
         super().__init__(scope, guid, initializer, True)
-        self._pages: List[Page] = list()
-        self._routes: List[RouteHandlerEntry] = list()
-        self._bindings: Dict[str, Any] = dict()
-        self._pending_wait_for_events: List[PendingWaitEvent] = list()
+        self._pages: List[Page] = []
+        self._routes: List[RouteHandlerEntry] = []
+        self._bindings: Dict[str, Any] = {}
+        self._pending_wait_for_events: List[PendingWaitEvent] = []
         self._timeout_settings = TimeoutSettings(None)
         self._browser: Optional["Browser"] = None
         self._owner_page: Optional[Page] = None
@@ -106,7 +106,7 @@ async def newPage(self) -> Page:
 
     async def cookies(self, urls: Union[str, List[str]]) -> List[Cookie]:
         if urls is None:
-            urls = list()
+            urls = []
         return await self._channel.send("cookies", dict(urls=urls))
 
     async def addCookies(self, cookies: List[Cookie]) -> None:

playwright/connection.py

@@ -32,7 +32,7 @@ def __init__(self, scope: "ConnectionScope", guid: str) -> None:
 
     async def send(self, method: str, params: dict = None) -> Any:
         if params is None:
-            params = dict()
+            params = {}
         result = await self._scope.send_message_to_server(self._guid, method, params)
         # Protocol now has named return values, assume result is one level deeper unless
         # there is explicit ambiguity.
@@ -47,7 +47,7 @@ async def send(self, method: str, params: dict = None) -> Any:
 
     def send_no_reply(self, method: str, params: dict = None) -> None:
         if params is None:
-            params = dict()
+            params = {}
         self._scope.send_message_to_server_no_reply(self._guid, method, params)
 
 
@@ -74,8 +74,8 @@ def __init__(
         self._connection: "Connection" = connection
         self._loop: asyncio.AbstractEventLoop = connection._loop
         self._guid: str = guid
-        self._children: List["ConnectionScope"] = list()
-        self._objects: Dict[str, ChannelOwner] = dict()
+        self._children: List["ConnectionScope"] = []
+        self._objects: Dict[str, ChannelOwner] = {}
         self._parent = parent
 
     def create_child(self, guid: str) -> "ConnectionScope":
@@ -138,12 +138,12 @@ def __init__(
     ) -> None:
         self._transport = Transport(input, output, loop)
         self._transport.on_message = lambda msg: self._dispatch(msg)
-        self._waiting_for_object: Dict[str, Any] = dict()
+        self._waiting_for_object: Dict[str, Any] = {}
         self._last_id = 0
         self._loop = loop
-        self._objects: Dict[str, ChannelOwner] = dict()
-        self._scopes: Dict[str, ConnectionScope] = dict()
-        self._callbacks: Dict[int, ProtocolCallback] = dict()
+        self._objects: Dict[str, ChannelOwner] = {}
+        self._scopes: Dict[str, ConnectionScope] = {}
+        self._callbacks: Dict[int, ProtocolCallback] = {}
         self._root_scope = self.create_scope("", None)
         self._object_factory = object_factory
 
@@ -212,7 +212,7 @@ def _replace_channels_with_guids(self, payload: Any) -> Any:
         if isinstance(payload, Channel):
             return dict(guid=payload._guid)
         if isinstance(payload, dict):
-            result = dict()
+            result = {}
             for key in payload:
                 result[key] = self._replace_channels_with_guids(payload[key])
             return result
@@ -226,7 +226,7 @@ def _replace_guids_with_channels(self, payload: Any) -> Any:
         if isinstance(payload, dict):
             if payload.get("guid") in self._objects:
                 return self._objects[payload["guid"]]._channel
-            result = dict()
+            result = {}
             for key in payload:
                 result[key] = self._replace_guids_with_channels(payload[key])
             return result

playwright/element_handle.py

@@ -227,10 +227,10 @@ async def evalOnSelectorAll(
 
 def convert_select_option_values(arg: ValuesToSelect) -> Any:
     if arg is None:
-        return dict()
+        return {}
     arg_list = arg if isinstance(arg, list) else [arg]
     if not len(arg_list):
-        return dict()
+        return {}
     if isinstance(arg_list[0], ElementHandle):
         element_list = cast(List[ElementHandle], arg_list)
         return dict(elements=list(map(lambda e: e._channel, element_list)))

playwright/frame.py

@@ -64,7 +64,7 @@ def __init__(self, scope: ConnectionScope, guid: str, initializer: Dict) -> None
         self._name = initializer["name"]
         self._url = initializer["url"]
         self._detached = False
-        self._child_frames: List[Frame] = list()
+        self._child_frames: List[Frame] = []
         self._page: "Page"
         self._load_states: Set[str] = set()
         self._event_emitter = BaseEventEmitter()

playwright/helper.py

@@ -211,7 +211,7 @@ def is_function_body(expression: str) -> bool:
 
 
 def locals_to_params(args: Dict) -> Dict:
-    copy = dict()
+    copy = {}
     for key in args:
         if key == "self":
             continue

playwright/js_handle.py

@@ -134,7 +134,7 @@ def serialize_value(value: Any, handles: List[JSHandle], depth: int) -> Any:
 
 
 def serialize_argument(arg: Any) -> Any:
-    handles: List[JSHandle] = list()
+    handles: List[JSHandle] = []
     value = serialize_value(arg, handles, 0)
     return dict(value=value, handles=handles)
 

playwright/network.py

@@ -99,7 +99,7 @@ async def abort(self, error_code: str = "failed") -> None:
     async def fulfill(
         self,
         status: int = 200,
-        headers: Dict[str, str] = dict(),
+        headers: Dict[str, str] = {},
         body: Union[str, bytes] = None,
         contentType: str = None,
     ) -> None:
@@ -120,7 +120,7 @@ async def continue_(
         headers: Dict[str, str] = None,
         postData: Union[str, bytes] = None,
     ) -> None:
-        overrides: ContinueParameters = dict()
+        overrides: ContinueParameters = {}
         if method:
             overrides["method"] = method
         if headers:

playwright/page.py

@@ -105,10 +105,10 @@ def __init__(self, scope: ConnectionScope, guid: str, initializer: Dict) -> None
         self._frames = [self._main_frame]
         self._viewport_size = initializer.get("viewportSize")
         self._is_closed = False
-        self._workers: List[Worker] = list()
-        self._bindings: Dict[str, Any] = dict()
-        self._pending_wait_for_events: List[PendingWaitEvent] = list()
-        self._routes: List[RouteHandlerEntry] = list()
+        self._workers: List[Worker] = []
+        self._bindings: Dict[str, Any] = {}
+        self._pending_wait_for_events: List[PendingWaitEvent] = []
+        self._routes: List[RouteHandlerEntry] = []
         self._owned_context: Optional["BrowserContext"] = None
         self._timeout_settings = TimeoutSettings(None)