Editing an Existing Service

[ssande-fwd]

I need a pH service and there is one, acidity. However, there are 3 issues/quirks with it:

• It's experimental, not stable
• It has max_humidity instead of max_acidity
• At risk of semantics, I feel like it should be called the pH service since it measures both acidity and basicity, but that is not nearly as important as points 1 and 2

Can I edit the max_humidity typo? Can we move it to stable at some point soon? Any argument against renaming it to pH? I only found documentation about creating new service, not editing an existing one. How do you edit an existing one?

[pelikhan]

You would need to edit https://github.com/microsoft/jacdac/blob/main/services/acidity.md and then run the buildspecs script.

[pelikhan]

The rename is tricker since it will have impact on the generated files etc...

But you could reach a middle ground by setting the short name to ph.

Sounds good to rename the register and move to stable.

[ssande-fwd]

I'm still building my mental model of the system.

1. Update acidity.md in jacdac and wait for merge.
2. Pull that update into the jacdac submodule of jacdac-ts and commit the updated hash to jacdac-ts.
3. Run buildspecs script in jacdac-ts to make acidity.ts which will be used for constants.ts in pxt-jacdac.

I can't find a link between pxt-jacdac and jacdac-ts. Do I simply manually copy acidity.ts into constants.ts, retaining the namespace?

[pelikhan]

I typically open jacdac-docs which has the full layout of all the sub repos as submodules... so this is fairly easy if you have Microsoft access.

Let me see with Tom if he can take this over. Once the jacdac repos are migrated, might also be good to rethink this layout.

[pelikhan]

@tballmsft can drive you through the update process?

[tballmsft]

let's go over tomorrow.