Remain c-style casts clean

Author: YexuanXiao

strings/base_array.h

@@ -446,7 +446,7 @@ WINRT_EXPORT namespace winrt
 
         if constexpr (std::is_base_of_v<Windows::Foundation::IUnknown, T>)
         {
-            return reinterpret_cast<void**>(data);
+            return impl::abi_cast(*data);
         }
         else
         {
@@ -564,21 +564,21 @@ WINRT_EXPORT namespace winrt
     inline hstring get_class_name(Windows::Foundation::IInspectable const& object)
     {
         void* value{};
-        check_hresult((*(impl::inspectable_abi**)&object)->GetRuntimeClassName(&value));
+        check_hresult(static_cast<impl::inspectable_abi*>(*impl::abi_cast(object))->GetRuntimeClassName(&value));
         return { value, take_ownership_from_abi };
     }
 
     inline com_array<guid> get_interfaces(Windows::Foundation::IInspectable const& object)
     {
         com_array<guid> value;
-        check_hresult((*(impl::inspectable_abi**)&object)->GetIids(impl::put_size_abi(value), put_abi(value)));
+        check_hresult(static_cast<impl::inspectable_abi*>(*impl::abi_cast(object))->GetIids(impl::put_size_abi(value), put_abi(value)));
         return value;
     }
 
     inline Windows::Foundation::TrustLevel get_trust_level(Windows::Foundation::IInspectable const& object)
     {
         Windows::Foundation::TrustLevel value{};
-        check_hresult((*(impl::inspectable_abi**)&object)->GetTrustLevel(&value));
+        check_hresult(static_cast<impl::inspectable_abi*>(*impl::abi_cast(object))->GetTrustLevel(&value));
         return value;
     }
 }

strings/base_coroutine_foundation.h

@@ -860,7 +860,7 @@ WINRT_EXPORT namespace winrt
 
             void operator()(T const& sender, Windows::Foundation::AsyncStatus operation_status) noexcept
             {
-                auto sender_abi = *(impl::unknown_abi**)&sender;
+                auto sender_abi = static_cast<impl::unknown_abi*>(*impl::abi_cast(sender));
 
                 if (nullptr == _InterlockedCompareExchangePointer(impl::abi_cast(result), sender_abi, nullptr))
                 {

strings/base_macros.h

@@ -13,7 +13,7 @@
 
 #endif
 
-#define WINRT_IMPL_SHIM(...) (*(abi_t<__VA_ARGS__>**)&static_cast<__VA_ARGS__ const&>(static_cast<D const&>(*this)))
+#define WINRT_IMPL_SHIM(...) (*impl::abi_t_abi_cast(static_cast<__VA_ARGS__ const&>(static_cast<D const&>(*this))))
 
 #ifdef _MSC_VER
 // Note: this is a workaround for a false-positive warning produced by the Visual C++ 15.9 compiler.

strings/base_string_input.h

@@ -61,7 +61,7 @@ WINRT_EXPORT namespace winrt::param
 
     inline void* get_abi(hstring const& object) noexcept
     {
-        return *(void**)(&object);
+        return *impl::abi_cast(object);
     }
 }
 

strings/base_windows.h

@@ -471,7 +471,7 @@ WINRT_EXPORT namespace winrt::impl
             winrt::hresult winrt_cast_result_code;
             auto const winrt_casted_result = try_as_with_reason<Base, Derive const*>(d, winrt_cast_result_code);
             check_hresult(winrt_cast_result_code);
-            auto const winrt_abi_type = *(abi_t<Base>**)&winrt_casted_result;
+            auto const winrt_abi_type = *abi_t_abi_cast(static_cast<Base const&>(winrt_casted_result));
             (winrt_abi_type->*mptr)(std::forward<Args>(args)...);
         }
         else
@@ -489,7 +489,7 @@ WINRT_EXPORT namespace winrt::impl
             winrt::hresult winrt_cast_result_code;
             auto const winrt_casted_result = try_as_with_reason<Base, Derive const*>(d, winrt_cast_result_code);
             check_hresult(winrt_cast_result_code);
-            auto const winrt_abi_type = *(abi_t<Base>**)&winrt_casted_result;
+            auto const winrt_abi_type = *abi_t_abi_cast(static_cast<Base const&>(winrt_casted_result));
             WINRT_VERIFY_(0, (winrt_abi_type->*mptr)(std::forward<Args>(args)...));
         }
         else
@@ -507,7 +507,7 @@ WINRT_EXPORT namespace winrt::impl
             winrt::hresult winrt_cast_result_code;
             auto const winrt_casted_result = try_as_with_reason<Base, Derive const*>(d, winrt_cast_result_code);
             check_hresult(winrt_cast_result_code);
-            auto const winrt_abi_type = *(abi_t<Base>**)&winrt_casted_result;
+            auto const winrt_abi_type = *abi_t_abi_cast(static_cast<Base const&>(winrt_casted_result));
             check_hresult((winrt_abi_type->*mptr)(std::forward<Args>(args)...));
         }
         else