Add option to force logout if server is unreachable

Author: esbenvb

cli/script/command-executor.ts

@@ -527,7 +527,7 @@ export function execute(command: cli.ICommand) {
         return login(<cli.ILoginCommand>command);
 
       case cli.CommandType.logout:
-        return logout(command);
+        return logout(<cli.ILogoutCommand>command);
 
       case cli.CommandType.patch:
         return patch(<cli.IPatchCommand>command);
@@ -626,7 +626,7 @@ function loginWithExternalAuthentication(action: string, serverUrl?: string): Pr
   });
 }
 
-function logout(command: cli.ICommand): Promise<void> {
+function logout(command: cli.ILogoutCommand): Promise<void> {
   return Q(<void>null)
     .then((): Promise<void> => {
       if (!connectionInfo.preserveAccessKeyOnLogout) {
@@ -642,6 +642,15 @@ function logout(command: cli.ICommand): Promise<void> {
     .then((): void => {
       sdk = null;
       deleteConnectionInfoCache();
+    })
+    .catch((error: any) => {
+      if (command.force) {
+        log(chalk.redBright("\nThere was an issue logging out from the server. Forcing logout by deleting local connection info.\n"));
+        deleteConnectionInfoCache();
+        log(chalk.yellowBright("Notice: Local session file was deleted, but the session ID might still exist on the server.\n"));
+      } else {
+        throw error;
+      }
     });
 }
 

cli/script/command-parser.ts

@@ -454,6 +454,13 @@ yargs
     yargs
       .usage(USAGE_PREFIX + " logout")
       .demand(/*count*/ 0, /*max*/ 0)
+      .option("force", {
+        alias: "f",
+        default: null,
+        demand: false,
+        description: "Force logout, even if server is unreachable.",
+        type: "boolean",
+      })
       .example("logout", "Logs out and ends your current session");
     addCommonConfiguration(yargs);
   })
@@ -1146,6 +1153,9 @@ export function createCommand(): cli.ICommand {
 
       case "logout":
         cmd = { type: cli.CommandType.logout };
+
+        const logoutCommand = <cli.ILogoutCommand>cmd;
+        logoutCommand.force = argv["force"] as boolean;
         break;
 
       case "patch":

cli/script/types/cli.ts

@@ -149,6 +149,10 @@ export interface ILoginCommand extends ICommand {
   accessKey: string;
 }
 
+export interface ILogoutCommand extends ICommand {
+  force: boolean
+}
+
 export interface IPackageInfo {
   description?: string;
   label?: string;