Guarantee pipeline failure for AzurePowerShellV5 (#21377)

* Guarantee pipeline failure for AzurePowerShellV5

Added cleanupExitCode

added logs

added try-catch

removed logs

added logs

changed condition

Uncommented the fix for the missing import error

Update error messages for AzurePowerShell task

Update the task version

Guarantee pipeline failure for AzurePowerShellV5

Uncommented the fix for the missing import error

Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Bump AzurePowerShell task version to 5.267.0

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Ivan Duplenskikh <115665590+ivanduplenskikh@users.noreply.github.com>

Author: 3 people

Tasks/AzurePowerShellV5/RemoveAzContext.ps1

@@ -1,13 +1,21 @@
 Import-Module "$PSScriptRoot\ps_modules\VstsTaskSdk" -ArgumentList @{ NonInteractive = $true }
 
-. "$PSScriptRoot/Utility.ps1"
-. "$PSScriptRoot/ps_modules/VstsAzureHelpers_/Utility.ps1"
+Set-StrictMode -Version Latest
+$ErrorActionPreference = 'Stop'
+try {
+    . "$PSScriptRoot/Utility.ps1"
+    . "$PSScriptRoot/ps_modules/VstsAzureHelpers_/Utility.ps1"
 
-Update-PSModulePathForHostedAgentLinux
-Disconnect-AzureAndClearContext -restrictContext 'True'
+    Update-PSModulePathForHostedAgentLinux
+    Disconnect-AzureAndClearContext -restrictContext 'True'
 
-if ($env:AZURESUBSCRIPTION_SERVICE_CONNECTION_ID) {
-    $env:AZURESUBSCRIPTION_SERVICE_CONNECTION_ID = ""
-    $env:AZURESUBSCRIPTION_CLIENT_ID = ""
-    $env:AZURESUBSCRIPTION_TENANT_ID = ""
+    if ($env:AZURESUBSCRIPTION_SERVICE_CONNECTION_ID) {
+        $env:AZURESUBSCRIPTION_SERVICE_CONNECTION_ID = ""
+        $env:AZURESUBSCRIPTION_CLIENT_ID = ""
+        $env:AZURESUBSCRIPTION_TENANT_ID = ""
+    }
+}
+catch {
+    Write-Host "##vso[task.logissue type=error]$($_.Exception.Message)"
+    exit 1
 }

Tasks/AzurePowerShellV5/azurepowershell.ts

@@ -180,6 +180,7 @@ async function run() {
         tl.setResult(tl.TaskResult.Failed, err.message || 'run() failed');
     }
     finally {
+        let cleanupExitCode = 0;
         try {
             const powershell = tl.tool(tl.which('pwsh') || tl.which('powershell') || tl.which('pwsh', true))
                 .arg('-NoLogo')
@@ -197,10 +198,16 @@ async function run() {
                     outStream: process.stdout, // of order since Node buffers it's own STDOUT but not STDERR.
                     ignoreReturnCode: true
                 };
-            await powershell.exec(options);
+            cleanupExitCode = await powershell.exec(options);
+            tl.debug(`Cleanup exit code: ${cleanupExitCode}`);
         }
         catch (err) {
             tl.debug("Az-clearContext not completed due to an error");
+            tl.setResult(tl.TaskResult.Failed, `Cleanup failed with error message: ${err.message}`);
+        }
+
+        if (cleanupExitCode !== 0) {
+            tl.setResult(tl.TaskResult.Failed, `Cleanup failed with exit code: ${cleanupExitCode}`);
         }
     }
 }

Tasks/AzurePowerShellV5/task.json

@@ -17,7 +17,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 5,
-    "Minor": 266,
+    "Minor": 267,
     "Patch": 0
   },
   "releaseNotes": "Added support for Az Module and cross platform agents.",

Tasks/AzurePowerShellV5/task.loc.json

@@ -17,7 +17,7 @@
   "author": "Microsoft Corporation",
   "version": {
     "Major": 5,
-    "Minor": 266,
+    "Minor": 267,
     "Patch": 0
   },
   "releaseNotes": "ms-resource:loc.releaseNotes",