Skip to content

Don't run generator when formatter isn't available#201

Open
benibenj wants to merge 2 commits into
mainfrom
benibenj/noble-alpaca
Open

Don't run generator when formatter isn't available#201
benibenj wants to merge 2 commits into
mainfrom
benibenj/noble-alpaca

Conversation

@benibenj

@benibenj benibenj commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This has cause a lot of pain for me. I did not notice that I didn't have the formatters installed and so I ended up having CI builds red all the time without understanding why. As the generated files must be formatted before being able to merge them I would suggest throwing when none is installed and providing a command line argument instead to be very clear that something is not setup correctly.
I also added some other default paths on windows for go formatter

@benibenj benibenj enabled auto-merge June 8, 2026 19:07
@benibenj benibenj requested a review from Copilot June 8, 2026 19:09
@benibenj benibenj requested review from connor4312 and removed request for Copilot June 8, 2026 19:10
@connor4312

connor4312 commented Jun 8, 2026

Copy link
Copy Markdown
Member

I wonder if we can also have a CI action that developers can manually run that formats + commits to their branch, similar to what we had in copilot-chat with the update simulation cache pipeline. And we could reference that as an alternative in the output warning

@benibenj

benibenj commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

That would be neat. But are you referring to maintainers or contributors? For maintainers that should be straight forward to add. But if you are referring to contributors without write permissions, I'm not sure how they would be able to trigger this.

@connor4312

Copy link
Copy Markdown
Member

Yea, maintainers only, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants