Fixed CA1873 warning (#4479)

dmytrostruk · web-flow · commit fd981da0f87b · 2026-03-04T13:24:53.000-08:00
diff --git a/dotnet/src/Microsoft.Agents.AI/ChatClient/ChatClientAgent.cs b/dotnet/src/Microsoft.Agents.AI/ChatClient/ChatClientAgent.cs
@@ -747,9 +747,15 @@ private void UpdateSessionConversationId(ChatClientAgentSession session, string?
             {
                 // The agent has a ChatHistoryProvider configured, but the service returned a conversation id,
                 // meaning the service manages chat history server-side. Both cannot be used simultaneously.
-                if (this._agentOptions?.WarnOnChatHistoryProviderConflict is true)
+                if (this._agentOptions?.WarnOnChatHistoryProviderConflict is true
+                    && this._logger.IsEnabled(LogLevel.Warning))
                 {
-                    this._logger.LogAgentChatClientHistoryProviderConflict(nameof(ChatClientAgentSession.ConversationId), nameof(this.ChatHistoryProvider), this.Id, this.GetLoggingAgentName());
+                    var loggingAgentName = this.GetLoggingAgentName();
+                    this._logger.LogAgentChatClientHistoryProviderConflict(
+                        nameof(ChatClientAgentSession.ConversationId),
+                        nameof(this.ChatHistoryProvider),
+                        this.Id,
+                        loggingAgentName);
                 }
 
                 if (this._agentOptions?.ThrowOnChatHistoryProviderConflict is true)

Original file line number	Diff line number	Diff line change
`@@ -747,9 +747,15 @@ private void UpdateSessionConversationId(ChatClientAgentSession session, string?`
`747`	`747`	`{`
`748`	`748`	`// The agent has a ChatHistoryProvider configured, but the service returned a conversation id,`
`749`	`749`	`// meaning the service manages chat history server-side. Both cannot be used simultaneously.`
`750`		`- if (this._agentOptions?.WarnOnChatHistoryProviderConflict is true)`
	`750`	`+ if (this._agentOptions?.WarnOnChatHistoryProviderConflict is true`
	`751`	`+ && this._logger.IsEnabled(LogLevel.Warning))`
`751`	`752`	`{`
`752`		`- this._logger.LogAgentChatClientHistoryProviderConflict(nameof(ChatClientAgentSession.ConversationId), nameof(this.ChatHistoryProvider), this.Id, this.GetLoggingAgentName());`
	`753`	`+ var loggingAgentName = this.GetLoggingAgentName();`
	`754`	`+ this._logger.LogAgentChatClientHistoryProviderConflict(`
	`755`	`+ nameof(ChatClientAgentSession.ConversationId),`
	`756`	`+ nameof(this.ChatHistoryProvider),`
	`757`	`+ this.Id,`
	`758`	`+ loggingAgentName);`
`753`	`759`	`}`
`754`	`760`
`755`	`761`	`if (this._agentOptions?.ThrowOnChatHistoryProviderConflict is true)`