Skip to content

Commit f7339cd

Browse files
committed
Replace indexOf checks with includes() for readability
Modernize membership checks from `indexOf(...) === -1` and `indexOf(...) >= 0` to use `includes()` in moduleSpecifiers.ts and importFixes.ts. https://claude.ai/code/session_01As1r4ZnGpdzw4gMYehgwe7
1 parent b949efa commit f7339cd

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/compiler/moduleSpecifiers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1107,7 +1107,7 @@ function tryGetModuleNameFromExportsOrImports(
11071107
else if (typeof exports === "object" && exports !== null) { // eslint-disable-line no-restricted-syntax
11081108
// conditional mapping
11091109
for (const key of getOwnKeys(exports as MapLike<unknown>)) {
1110-
if (key === "default" || conditions.indexOf(key) >= 0 || isApplicableVersionedTypesKey(conditions, key)) {
1110+
if (key === "default" || conditions.includes(key) || isApplicableVersionedTypesKey(conditions, key)) {
11111111
const subTarget = (exports as MapLike<unknown>)[key];
11121112
const result = tryGetModuleNameFromExportsOrImports(options, host, targetFilePath, packageDirectory, packageName, subTarget, conditions, mode, isImports, preferTsExtension);
11131113
if (result) {

src/services/codefixes/importFixes.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,7 @@ function createImportAdderWorker(sourceFile: SourceFile | FutureSourceFile, prog
607607
// has named bindings
608608
d.importClause?.namedBindings &&
609609
// is not being fully removed
610-
emptyImportDeclarations.indexOf(d) === -1 &&
610+
!emptyImportDeclarations.includes(d) &&
611611
// is not gaining named imports
612612
!addToExisting.get(d.importClause)?.namedImports &&
613613
// all named imports are being removed
@@ -632,8 +632,8 @@ function createImportAdderWorker(sourceFile: SourceFile | FutureSourceFile, prog
632632
const importDeclaration = findAncestor(declaration, isImportDeclaration);
633633
if (
634634
importDeclaration &&
635-
emptyImportDeclarations.indexOf(importDeclaration) === -1 &&
636-
namedBindingsToDelete.indexOf(importDeclaration) === -1
635+
!emptyImportDeclarations.includes(importDeclaration) &&
636+
!namedBindingsToDelete.includes(importDeclaration)
637637
) {
638638
if (declaration.kind === SyntaxKind.ImportClause) {
639639
changeTracker.delete(sourceFile, declaration.name!);

0 commit comments

Comments
 (0)