Revert isArrayLikeType

Author: jakebailey

src/compiler/checker.ts

@@ -25480,11 +25480,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
 
     function isArrayLikeType(type: Type): boolean {
         // A type is array-like if it is a reference to the global Array or global ReadonlyArray type,
-        // or if it is not the undefined or null type and if it is assignable to ReadonlyArray<any>.
-        // When Array doesn't exist (noLib), we can't determine array-likeness.
-        if (anyReadonlyArrayType === emptyObjectType) {
-            return false;
-        }
+        // or if it is not the undefined or null type and if it is assignable to ReadonlyArray<any>
         return isArrayType(type) || !(type.flags & TypeFlags.Nullable) && isTypeAssignableTo(type, anyReadonlyArrayType);
     }
 

tests/baselines/reference/arrayIterationLibES5TargetDifferent(nolib=true,target=es2015).errors.txt

@@ -9,9 +9,6 @@ error TS2318: Cannot find global type 'Object'.
 error TS2318: Cannot find global type 'RegExp'.
 error TS2318: Cannot find global type 'String'.
 error TS5053: Option 'lib' cannot be specified with option 'noLib'.
-arrayIterationLibES5TargetDifferent.ts(3,17): error TS2495: Type '{}' is not an array type or a string type.
-arrayIterationLibES5TargetDifferent.ts(15,17): error TS2495: Type 'number' is not an array type or a string type.
-arrayIterationLibES5TargetDifferent.ts(21,17): error TS2495: Type '{ foo: string; }' is not an array type or a string type.
 
 
 !!! error TS2318: Cannot find global type 'Array'.
@@ -25,12 +22,10 @@ arrayIterationLibES5TargetDifferent.ts(21,17): error TS2495: Type '{ foo: string
 !!! error TS2318: Cannot find global type 'RegExp'.
 !!! error TS2318: Cannot find global type 'String'.
 !!! error TS5053: Option 'lib' cannot be specified with option 'noLib'.
-==== arrayIterationLibES5TargetDifferent.ts (3 errors) ====
+==== arrayIterationLibES5TargetDifferent.ts (0 errors) ====
     declare function log(message?: any): void;
 
     for (const x of [1, 2, 3]) {
-                    ~~~~~~~~~
-!!! error TS2495: Type '{}' is not an array type or a string type.
         log(x);
     }
 
@@ -43,15 +38,11 @@ arrayIterationLibES5TargetDifferent.ts(21,17): error TS2495: Type '{ foo: string
     declare const aNumber: number;
 
     for (const x of aNumber) {
-                    ~~~~~~~
-!!! error TS2495: Type 'number' is not an array type or a string type.
         log(x);
     }
 
     declare const anObject: { foo: string };
 
     for (const x of anObject) {
-                    ~~~~~~~~
-!!! error TS2495: Type '{ foo: string; }' is not an array type or a string type.
         log(x);
     }

tests/baselines/reference/arrayIterationLibES5TargetDifferent(nolib=true,target=es5).errors.txt

@@ -9,9 +9,6 @@ error TS2318: Cannot find global type 'Object'.
 error TS2318: Cannot find global type 'RegExp'.
 error TS2318: Cannot find global type 'String'.
 error TS5053: Option 'lib' cannot be specified with option 'noLib'.
-arrayIterationLibES5TargetDifferent.ts(3,17): error TS2495: Type '{}' is not an array type or a string type.
-arrayIterationLibES5TargetDifferent.ts(15,17): error TS2495: Type 'number' is not an array type or a string type.
-arrayIterationLibES5TargetDifferent.ts(21,17): error TS2495: Type '{ foo: string; }' is not an array type or a string type.
 
 
 !!! error TS2318: Cannot find global type 'Array'.
@@ -25,12 +22,10 @@ arrayIterationLibES5TargetDifferent.ts(21,17): error TS2495: Type '{ foo: string
 !!! error TS2318: Cannot find global type 'RegExp'.
 !!! error TS2318: Cannot find global type 'String'.
 !!! error TS5053: Option 'lib' cannot be specified with option 'noLib'.
-==== arrayIterationLibES5TargetDifferent.ts (3 errors) ====
+==== arrayIterationLibES5TargetDifferent.ts (0 errors) ====
     declare function log(message?: any): void;
 
     for (const x of [1, 2, 3]) {
-                    ~~~~~~~~~
-!!! error TS2495: Type '{}' is not an array type or a string type.
         log(x);
     }
 
@@ -43,15 +38,11 @@ arrayIterationLibES5TargetDifferent.ts(21,17): error TS2495: Type '{ foo: string
     declare const aNumber: number;
 
     for (const x of aNumber) {
-                    ~~~~~~~
-!!! error TS2495: Type 'number' is not an array type or a string type.
         log(x);
     }
 
     declare const anObject: { foo: string };
 
     for (const x of anObject) {
-                    ~~~~~~~~
-!!! error TS2495: Type '{ foo: string; }' is not an array type or a string type.
         log(x);
     }

tests/baselines/reference/arrayIterationLibES5TargetDifferent(nolib=true,target=esnext).errors.txt

@@ -9,9 +9,6 @@ error TS2318: Cannot find global type 'Object'.
 error TS2318: Cannot find global type 'RegExp'.
 error TS2318: Cannot find global type 'String'.
 error TS5053: Option 'lib' cannot be specified with option 'noLib'.
-arrayIterationLibES5TargetDifferent.ts(3,17): error TS2495: Type '{}' is not an array type or a string type.
-arrayIterationLibES5TargetDifferent.ts(15,17): error TS2495: Type 'number' is not an array type or a string type.
-arrayIterationLibES5TargetDifferent.ts(21,17): error TS2495: Type '{ foo: string; }' is not an array type or a string type.
 
 
 !!! error TS2318: Cannot find global type 'Array'.
@@ -25,12 +22,10 @@ arrayIterationLibES5TargetDifferent.ts(21,17): error TS2495: Type '{ foo: string
 !!! error TS2318: Cannot find global type 'RegExp'.
 !!! error TS2318: Cannot find global type 'String'.
 !!! error TS5053: Option 'lib' cannot be specified with option 'noLib'.
-==== arrayIterationLibES5TargetDifferent.ts (3 errors) ====
+==== arrayIterationLibES5TargetDifferent.ts (0 errors) ====
     declare function log(message?: any): void;
 
     for (const x of [1, 2, 3]) {
-                    ~~~~~~~~~
-!!! error TS2495: Type '{}' is not an array type or a string type.
         log(x);
     }
 
@@ -43,15 +38,11 @@ arrayIterationLibES5TargetDifferent.ts(21,17): error TS2495: Type '{ foo: string
     declare const aNumber: number;
 
     for (const x of aNumber) {
-                    ~~~~~~~
-!!! error TS2495: Type 'number' is not an array type or a string type.
         log(x);
     }
 
     declare const anObject: { foo: string };
 
     for (const x of anObject) {
-                    ~~~~~~~~
-!!! error TS2495: Type '{ foo: string; }' is not an array type or a string type.
         log(x);
     }

tests/baselines/reference/noCrashOnNoLib.errors.txt

@@ -6,7 +6,6 @@ error TS2318: Cannot find global type 'Number'.
 error TS2318: Cannot find global type 'Object'.
 error TS2318: Cannot find global type 'RegExp'.
 error TS2318: Cannot find global type 'String'.
-noCrashOnNoLib.ts(4,15): error TS2461: Type '{}' is not an array type.
 
 
 !!! error TS2318: Cannot find global type 'Array'.
@@ -17,12 +16,10 @@ noCrashOnNoLib.ts(4,15): error TS2461: Type '{}' is not an array type.
 !!! error TS2318: Cannot find global type 'Object'.
 !!! error TS2318: Cannot find global type 'RegExp'.
 !!! error TS2318: Cannot find global type 'String'.
-==== noCrashOnNoLib.ts (1 errors) ====
+==== noCrashOnNoLib.ts (0 errors) ====
     export function f() {
         let e: {}[] = [];
         while (true) {
           e = [...(e || [])];
-                  ~~~~~~~~~
-!!! error TS2461: Type '{}' is not an array type.
         }
     }