Skip to content

Commit da0b88e

Browse files
author
typescript-bot
committed
Merge remote-tracking branch 'upstream/master' into HEAD
2 parents 194c0c8 + 8aa49c4 commit da0b88e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Performance.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,13 +319,14 @@ yarn add typescript@next --dev
319319
A compiler perf issue should include
320320

321321
* The version of TypeScript that was installed (i.e. `npx tsc -v` or `yarn tsc -v`)
322+
* The version of Node on which TypeScript ran (i.e. `node -v`)
322323
* The output of running with `extendedDiagnostics` (`tsc --extendedDiagnostics -p tsconfig.json`)
323324
* Ideally, a project that demonstrates the issues being encountered.
324325
* Output logs from profiling the compiler (`isolate-*-*-*.log` and `*.cpuprofile` files)
325326

326327
### Profiling the Compiler
327328

328-
It is important to provide the team with diagnostic traces by running Node.js with the `--trace-ic` flag alongside TypeScript with the `--generateCpuProfile` flag:
329+
It is important to provide the team with diagnostic traces by running Node.js v10+ with the `--trace-ic` flag alongside TypeScript with the `--generateCpuProfile` flag:
329330

330331
```sh
331332
node --trace-ic ./node_modules/typescript/lib/tsc.js --generateCpuProfile profile.cpuprofile -p tsconfig.json

0 commit comments

Comments
 (0)