From 0cdbbd0add7adb43a45f64023dae356c0cc180db Mon Sep 17 00:00:00 2001 From: steveluc Date: Sun, 25 Jan 2026 22:22:23 -0800 Subject: [PATCH] Fix WebSocket event type imports in agent-server-client The isomorphic-ws package doesn't export MessageEvent, CloseEvent, or ErrorEvent types. These types are defined in the WebSocket namespace via @types/ws. Updated to use the namespaced types (WebSocket.MessageEvent, WebSocket.CloseEvent, WebSocket.ErrorEvent) instead of trying to import them directly from isomorphic-ws. This resolves TypeScript compilation errors: - TS2305: Module '"isomorphic-ws"' has no exported member 'MessageEvent' - TS2305: Module '"isomorphic-ws"' has no exported member 'CloseEvent' - TS2305: Module '"isomorphic-ws"' has no exported member 'ErrorEvent' Co-Authored-By: Claude Sonnet 4.5 --- .../agentServer/client/src/agentServerClient.ts | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/ts/packages/agentServer/client/src/agentServerClient.ts b/ts/packages/agentServer/client/src/agentServerClient.ts index 0065f0b81..3ca9713b8 100644 --- a/ts/packages/agentServer/client/src/agentServerClient.ts +++ b/ts/packages/agentServer/client/src/agentServerClient.ts @@ -6,11 +6,7 @@ import { createRpc } from "@typeagent/agent-rpc/rpc"; import { createClientIORpcServer } from "@typeagent/dispatcher-rpc/clientio/server"; import { createDispatcherRpcClient } from "@typeagent/dispatcher-rpc/dispatcher/client"; import type { ClientIO, Dispatcher } from "@typeagent/dispatcher-rpc/types"; -import WebSocket, { - type MessageEvent, - type CloseEvent, - type ErrorEvent, -} from "isomorphic-ws"; +import WebSocket from "isomorphic-ws"; import registerDebug from "debug"; import { @@ -67,19 +63,19 @@ export async function connectDispatcher( reject(err); }); }; - ws.onmessage = (event: MessageEvent) => { + ws.onmessage = (event: WebSocket.MessageEvent) => { debug("Received message from server:", event.data); channel.notifyMessage(JSON.parse(event.data.toString())); }; - ws.onclose = (event: CloseEvent) => { + ws.onclose = (event: WebSocket.CloseEvent) => { debug("WebSocket connection closed", event.code, event.reason); channel.notifyDisconnected(); if (!resolved) { reject(new Error(`Failed to connect to dispatcher at ${url}`)); } }; - ws.onerror = (error: ErrorEvent) => { + ws.onerror = (error: WebSocket.ErrorEvent) => { debugErr("WebSocket error:", error); }; });