From 80e232cfa54d4a55e8391ec67a9d53c1775f9c62 Mon Sep 17 00:00:00 2001 From: Aadarsh Indurkhya Date: Mon, 19 May 2025 08:55:27 +0000 Subject: [PATCH 1/9] updating vulnerable packages + An obselete package to be in sync with GitOps Base library so that it doesn't conflict --- .../PullRequestQuantifier.Client.csproj | 4 ++-- .../PullRequestQuantifier.Abstractions.csproj | 2 +- .../PullRequestQuantifier.Common.Tests.csproj | 2 +- .../Extensions/FileSystemExtensions.cs | 2 +- .../PullRequestQuantifier.Common.csproj | 2 +- .../Helpers/Diff/GitCreateDiff.cs | 2 +- .../PullRequestQuantifier.GitEngine.csproj | 2 +- .../PullRequestQuantifier.Repository.Service.csproj | 4 ++-- 8 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/Clients/PullRequestQuantifier.Client/PullRequestQuantifier.Client.csproj b/src/Clients/PullRequestQuantifier.Client/PullRequestQuantifier.Client.csproj index cba651f..c6db1a5 100644 --- a/src/Clients/PullRequestQuantifier.Client/PullRequestQuantifier.Client.csproj +++ b/src/Clients/PullRequestQuantifier.Client/PullRequestQuantifier.Client.csproj @@ -11,8 +11,8 @@ - - + + diff --git a/src/PullRequestQuantifier.Abstractions/PullRequestQuantifier.Abstractions.csproj b/src/PullRequestQuantifier.Abstractions/PullRequestQuantifier.Abstractions.csproj index 0a03abb..df55e68 100644 --- a/src/PullRequestQuantifier.Abstractions/PullRequestQuantifier.Abstractions.csproj +++ b/src/PullRequestQuantifier.Abstractions/PullRequestQuantifier.Abstractions.csproj @@ -12,7 +12,7 @@ - + diff --git a/src/PullRequestQuantifier.Common.Tests/PullRequestQuantifier.Common.Tests.csproj b/src/PullRequestQuantifier.Common.Tests/PullRequestQuantifier.Common.Tests.csproj index 06ceead..a6335b8 100644 --- a/src/PullRequestQuantifier.Common.Tests/PullRequestQuantifier.Common.Tests.csproj +++ b/src/PullRequestQuantifier.Common.Tests/PullRequestQuantifier.Common.Tests.csproj @@ -7,7 +7,7 @@ - + diff --git a/src/PullRequestQuantifier.Common/Extensions/FileSystemExtensions.cs b/src/PullRequestQuantifier.Common/Extensions/FileSystemExtensions.cs index 4909759..a901706 100644 --- a/src/PullRequestQuantifier.Common/Extensions/FileSystemExtensions.cs +++ b/src/PullRequestQuantifier.Common/Extensions/FileSystemExtensions.cs @@ -9,7 +9,7 @@ public static class FileSystemExtensions public static void DeleteDirectory(this IFileSystem fileSystem, string path) { #pragma warning disable CS0618 // Do not catch general exception types - var dirInfo = fileSystem.DirectoryInfo.FromDirectoryName(path); + var dirInfo = fileSystem.DirectoryInfo.New(path); #pragma warning restore CS0618 // Do not catch general exception types if (dirInfo.Exists) diff --git a/src/PullRequestQuantifier.Common/PullRequestQuantifier.Common.csproj b/src/PullRequestQuantifier.Common/PullRequestQuantifier.Common.csproj index f2e223f..5da4346 100644 --- a/src/PullRequestQuantifier.Common/PullRequestQuantifier.Common.csproj +++ b/src/PullRequestQuantifier.Common/PullRequestQuantifier.Common.csproj @@ -14,7 +14,7 @@ - + diff --git a/src/PullRequestQuantifier.GitEngine/Helpers/Diff/GitCreateDiff.cs b/src/PullRequestQuantifier.GitEngine/Helpers/Diff/GitCreateDiff.cs index 6c91959..fb87d0e 100644 --- a/src/PullRequestQuantifier.GitEngine/Helpers/Diff/GitCreateDiff.cs +++ b/src/PullRequestQuantifier.GitEngine/Helpers/Diff/GitCreateDiff.cs @@ -76,7 +76,7 @@ private void Commit() private void DeleteRepoDirectory() { #pragma warning disable CS0618 // Type or member is obsolete - var dirInfo = fileSystem.DirectoryInfo.FromDirectoryName(repoPath); + var dirInfo = fileSystem.DirectoryInfo.New(repoPath); #pragma warning restore CS0618 // Type or member is obsolete if (dirInfo.Exists) { diff --git a/src/PullRequestQuantifier.GitEngine/PullRequestQuantifier.GitEngine.csproj b/src/PullRequestQuantifier.GitEngine/PullRequestQuantifier.GitEngine.csproj index 9c6e68a..2395977 100644 --- a/src/PullRequestQuantifier.GitEngine/PullRequestQuantifier.GitEngine.csproj +++ b/src/PullRequestQuantifier.GitEngine/PullRequestQuantifier.GitEngine.csproj @@ -8,7 +8,7 @@ - + diff --git a/src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj b/src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj index cce5148..25769a8 100644 --- a/src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj +++ b/src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj @@ -11,10 +11,10 @@ - + - + From dacfaeffbe118d0932ac0a2b09c383a14939cb46 Mon Sep 17 00:00:00 2001 From: Aadarsh Indurkhya Date: Mon, 19 May 2025 09:15:51 +0000 Subject: [PATCH 2/9] Updating target version --- .../PullRequestQuantifier.Client.Tests.csproj | 2 +- .../PullRequestQuantifier.GitHub.Client.Tests.csproj | 2 +- .../PullRequestQuantifier.GitHub.Client.csproj | 2 +- .../PullRequestQuantifier.GitHub.Common.Tests.csproj | 2 +- .../PullRequestQuantifier.Local.Client.csproj | 2 +- .../PullRequestQuantifier.Local.Context.csproj | 2 +- .../PullRequestQuantifier.VsCode.Client.csproj | 2 +- .../PullRequestQuantifier.Abstractions.Tests.csproj | 2 +- .../PullRequestQuantifier.Common.Tests.csproj | 2 +- .../PullRequestQuantifier.Feedback.Service.csproj | 2 +- .../PullRequestQuantifier.GitEngine.Tests.csproj | 2 +- .../PullRequestQuantifier.Repository.Service.csproj | 2 +- .../PullRequestQuantifier.Tests.csproj | 2 +- .../PullRequestQuantifier.Tools.CloneAdoRepo.csproj | 2 +- .../PullRequestQuantifier.Tools.QuantifyRepositories.csproj | 2 +- 15 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/Clients/PullRequestQuantifier.Client.Tests/PullRequestQuantifier.Client.Tests.csproj b/src/Clients/PullRequestQuantifier.Client.Tests/PullRequestQuantifier.Client.Tests.csproj index 8b42f27..829f489 100644 --- a/src/Clients/PullRequestQuantifier.Client.Tests/PullRequestQuantifier.Client.Tests.csproj +++ b/src/Clients/PullRequestQuantifier.Client.Tests/PullRequestQuantifier.Client.Tests.csproj @@ -1,7 +1,7 @@ - net7.0 + net8.0 false diff --git a/src/Clients/PullRequestQuantifier.GitHub.Client.Tests/PullRequestQuantifier.GitHub.Client.Tests.csproj b/src/Clients/PullRequestQuantifier.GitHub.Client.Tests/PullRequestQuantifier.GitHub.Client.Tests.csproj index d4f0ab6..d48e2fc 100644 --- a/src/Clients/PullRequestQuantifier.GitHub.Client.Tests/PullRequestQuantifier.GitHub.Client.Tests.csproj +++ b/src/Clients/PullRequestQuantifier.GitHub.Client.Tests/PullRequestQuantifier.GitHub.Client.Tests.csproj @@ -1,7 +1,7 @@ - net7.0 + net8.0 false diff --git a/src/Clients/PullRequestQuantifier.GitHub.Client/PullRequestQuantifier.GitHub.Client.csproj b/src/Clients/PullRequestQuantifier.GitHub.Client/PullRequestQuantifier.GitHub.Client.csproj index 018f3a4..e19f211 100644 --- a/src/Clients/PullRequestQuantifier.GitHub.Client/PullRequestQuantifier.GitHub.Client.csproj +++ b/src/Clients/PullRequestQuantifier.GitHub.Client/PullRequestQuantifier.GitHub.Client.csproj @@ -1,7 +1,7 @@ - net7.0 + net8.0 true diff --git a/src/Clients/PullRequestQuantifier.GitHub.Common.Tests/PullRequestQuantifier.GitHub.Common.Tests.csproj b/src/Clients/PullRequestQuantifier.GitHub.Common.Tests/PullRequestQuantifier.GitHub.Common.Tests.csproj index 510d41b..5cd28b6 100644 --- a/src/Clients/PullRequestQuantifier.GitHub.Common.Tests/PullRequestQuantifier.GitHub.Common.Tests.csproj +++ b/src/Clients/PullRequestQuantifier.GitHub.Common.Tests/PullRequestQuantifier.GitHub.Common.Tests.csproj @@ -1,7 +1,7 @@  - net7.0 + net8.0 false diff --git a/src/Clients/PullRequestQuantifier.Local.Client/PullRequestQuantifier.Local.Client.csproj b/src/Clients/PullRequestQuantifier.Local.Client/PullRequestQuantifier.Local.Client.csproj index cb48cab..3df449a 100644 --- a/src/Clients/PullRequestQuantifier.Local.Client/PullRequestQuantifier.Local.Client.csproj +++ b/src/Clients/PullRequestQuantifier.Local.Client/PullRequestQuantifier.Local.Client.csproj @@ -2,7 +2,7 @@ Exe - net7.0 + net8.0 true diff --git a/src/Clients/PullRequestQuantifier.Local.Context/PullRequestQuantifier.Local.Context.csproj b/src/Clients/PullRequestQuantifier.Local.Context/PullRequestQuantifier.Local.Context.csproj index 77a806f..4d41833 100644 --- a/src/Clients/PullRequestQuantifier.Local.Context/PullRequestQuantifier.Local.Context.csproj +++ b/src/Clients/PullRequestQuantifier.Local.Context/PullRequestQuantifier.Local.Context.csproj @@ -2,7 +2,7 @@ Exe - net7.0 + net8.0 true diff --git a/src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj b/src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj index d8a9d69..17b756d 100644 --- a/src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj +++ b/src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj @@ -2,7 +2,7 @@ Exe - net7.0 + net8.0 pull-request-quantifier\ true diff --git a/src/PullRequestQuantifier.Abstractions.Tests/PullRequestQuantifier.Abstractions.Tests.csproj b/src/PullRequestQuantifier.Abstractions.Tests/PullRequestQuantifier.Abstractions.Tests.csproj index 71da271..b4b8496 100644 --- a/src/PullRequestQuantifier.Abstractions.Tests/PullRequestQuantifier.Abstractions.Tests.csproj +++ b/src/PullRequestQuantifier.Abstractions.Tests/PullRequestQuantifier.Abstractions.Tests.csproj @@ -1,7 +1,7 @@  - net7.0 + net8.0 false diff --git a/src/PullRequestQuantifier.Common.Tests/PullRequestQuantifier.Common.Tests.csproj b/src/PullRequestQuantifier.Common.Tests/PullRequestQuantifier.Common.Tests.csproj index a6335b8..52f7578 100644 --- a/src/PullRequestQuantifier.Common.Tests/PullRequestQuantifier.Common.Tests.csproj +++ b/src/PullRequestQuantifier.Common.Tests/PullRequestQuantifier.Common.Tests.csproj @@ -1,7 +1,7 @@ - net7.0 + net8.0 true diff --git a/src/PullRequestQuantifier.Feedback.Service/PullRequestQuantifier.Feedback.Service.csproj b/src/PullRequestQuantifier.Feedback.Service/PullRequestQuantifier.Feedback.Service.csproj index 12fb3a9..c7113e8 100644 --- a/src/PullRequestQuantifier.Feedback.Service/PullRequestQuantifier.Feedback.Service.csproj +++ b/src/PullRequestQuantifier.Feedback.Service/PullRequestQuantifier.Feedback.Service.csproj @@ -1,7 +1,7 @@  - net7.0 + net8.0 true diff --git a/src/PullRequestQuantifier.GitEngine.Tests/PullRequestQuantifier.GitEngine.Tests.csproj b/src/PullRequestQuantifier.GitEngine.Tests/PullRequestQuantifier.GitEngine.Tests.csproj index 931e4a7..a59fef4 100644 --- a/src/PullRequestQuantifier.GitEngine.Tests/PullRequestQuantifier.GitEngine.Tests.csproj +++ b/src/PullRequestQuantifier.GitEngine.Tests/PullRequestQuantifier.GitEngine.Tests.csproj @@ -1,7 +1,7 @@ - net7.0 + net8.0 false diff --git a/src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj b/src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj index 25769a8..5fd3105 100644 --- a/src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj +++ b/src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj @@ -1,7 +1,7 @@  - net7.0 + net8.0 true diff --git a/src/PullRequestQuantifier.Tests/PullRequestQuantifier.Tests.csproj b/src/PullRequestQuantifier.Tests/PullRequestQuantifier.Tests.csproj index 2dde1e3..f146178 100644 --- a/src/PullRequestQuantifier.Tests/PullRequestQuantifier.Tests.csproj +++ b/src/PullRequestQuantifier.Tests/PullRequestQuantifier.Tests.csproj @@ -1,7 +1,7 @@ - net7.0 + net8.0 Latest true PullRequestQuantifier.Tests diff --git a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/PullRequestQuantifier.Tools.CloneAdoRepo.csproj b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/PullRequestQuantifier.Tools.CloneAdoRepo.csproj index 49f616c..75666e7 100644 --- a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/PullRequestQuantifier.Tools.CloneAdoRepo.csproj +++ b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/PullRequestQuantifier.Tools.CloneAdoRepo.csproj @@ -2,7 +2,7 @@ Exe - net7.0 + net8.0 PullRequestQuantifier.Tools.CloneAdoRepo PullRequestQuantifier.Tools.CloneAdoRepo true diff --git a/src/Tools/PullRequestQuantifier.Tools.QuantifyRepositories/PullRequestQuantifier.Tools.QuantifyRepositories.csproj b/src/Tools/PullRequestQuantifier.Tools.QuantifyRepositories/PullRequestQuantifier.Tools.QuantifyRepositories.csproj index e4e7e2a..8a5f3cf 100644 --- a/src/Tools/PullRequestQuantifier.Tools.QuantifyRepositories/PullRequestQuantifier.Tools.QuantifyRepositories.csproj +++ b/src/Tools/PullRequestQuantifier.Tools.QuantifyRepositories/PullRequestQuantifier.Tools.QuantifyRepositories.csproj @@ -2,7 +2,7 @@ Exe - net7.0 + net8.0 true From 941a349c2e8aa2ebdbfa3de17e44bdfa10946fff Mon Sep 17 00:00:00 2001 From: Aadarsh Indurkhya Date: Mon, 19 May 2025 09:39:52 +0000 Subject: [PATCH 3/9] .Net 8.0 --- .github/workflows/build_net.yml | 2 +- .github/workflows/build_net_core.yml | 2 +- .github/workflows/feedback_service.yml | 2 +- .github/workflows/github_client.yml | 2 +- .github/workflows/repository_service.yml | 2 +- .github/workflows/vscode_client.yml | 2 +- .../PullRequestQuantifier.Client.csproj | 2 +- .../PullRequestQuantifier.GitHub.Client.csproj | 2 +- .../PullRequestQuantifier.Local.Client.csproj | 2 +- .../PullRequestQuantifier.Abstractions.csproj | 2 +- .../PullRequestQuantifier.Common.Tests.csproj | 2 +- .../PullRequestQuantifier.Common.csproj | 2 +- .../PullRequestQuantifier.Feedback.Service.csproj | 2 +- .../PullRequestQuantifier.Repository.Service.csproj | 4 ++-- .../PullRequestQuantifier.Tests.csproj | 2 +- .../Program.cs | 10 +++------- .../PullRequestQuantifier.Tools.CloneAdoRepo.csproj | 2 +- 17 files changed, 20 insertions(+), 24 deletions(-) diff --git a/.github/workflows/build_net.yml b/.github/workflows/build_net.yml index c36dec0..6918f52 100644 --- a/.github/workflows/build_net.yml +++ b/.github/workflows/build_net.yml @@ -22,7 +22,7 @@ jobs: - name: Setup .NET Core uses: actions/setup-dotnet@v1 with: - dotnet-version: 7.0.x + dotnet-version: 8.0.x # Add MSBuild to the PATH: https://github.com/microsoft/setup-msbuild - name: Setup MSBuild.exe diff --git a/.github/workflows/build_net_core.yml b/.github/workflows/build_net_core.yml index 59e58ed..428585a 100644 --- a/.github/workflows/build_net_core.yml +++ b/.github/workflows/build_net_core.yml @@ -22,7 +22,7 @@ jobs: - name: Setup .NET Core uses: actions/setup-dotnet@v1 with: - dotnet-version: 7.0.x + dotnet-version: 8.0.x - name: Install dependencies run: dotnet restore PullRequestQuantifier.sln diff --git a/.github/workflows/feedback_service.yml b/.github/workflows/feedback_service.yml index 38141d9..051462f 100644 --- a/.github/workflows/feedback_service.yml +++ b/.github/workflows/feedback_service.yml @@ -17,7 +17,7 @@ jobs: - name: Setup .NET Core uses: actions/setup-dotnet@v1 with: - dotnet-version: 7.0.x + dotnet-version: 8.0.x - name: Install dependencies run: dotnet restore src/PullRequestQuantifier.Feedback.Service/PullRequestQuantifier.Feedback.Service.csproj env: diff --git a/.github/workflows/github_client.yml b/.github/workflows/github_client.yml index 283a654..957fcf5 100644 --- a/.github/workflows/github_client.yml +++ b/.github/workflows/github_client.yml @@ -17,7 +17,7 @@ jobs: - name: Setup .NET Core uses: actions/setup-dotnet@v1 with: - dotnet-version: 7.0.x + dotnet-version: 8.0.x - name: Install dependencies run: dotnet restore src/Clients/PullRequestQuantifier.GitHub.Client/PullRequestQuantifier.GitHub.Client.csproj env: diff --git a/.github/workflows/repository_service.yml b/.github/workflows/repository_service.yml index 83fdffa..5eb2c7a 100644 --- a/.github/workflows/repository_service.yml +++ b/.github/workflows/repository_service.yml @@ -17,7 +17,7 @@ jobs: - name: Setup .NET Core uses: actions/setup-dotnet@v1 with: - dotnet-version: 7.0.x + dotnet-version: 8.0.x - name: Install dependencies run: dotnet restore src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj env: diff --git a/.github/workflows/vscode_client.yml b/.github/workflows/vscode_client.yml index 84cbafd..c740483 100644 --- a/.github/workflows/vscode_client.yml +++ b/.github/workflows/vscode_client.yml @@ -18,7 +18,7 @@ jobs: - name: Setup .NET Core uses: actions/setup-dotnet@v1 with: - dotnet-version: 7.0.x + dotnet-version: 8.0.x - name: Install dependencies run: dotnet restore src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj env: diff --git a/src/Clients/PullRequestQuantifier.Client/PullRequestQuantifier.Client.csproj b/src/Clients/PullRequestQuantifier.Client/PullRequestQuantifier.Client.csproj index c6db1a5..d6ae430 100644 --- a/src/Clients/PullRequestQuantifier.Client/PullRequestQuantifier.Client.csproj +++ b/src/Clients/PullRequestQuantifier.Client/PullRequestQuantifier.Client.csproj @@ -14,7 +14,7 @@ - + diff --git a/src/Clients/PullRequestQuantifier.GitHub.Client/PullRequestQuantifier.GitHub.Client.csproj b/src/Clients/PullRequestQuantifier.GitHub.Client/PullRequestQuantifier.GitHub.Client.csproj index e19f211..e4437b7 100644 --- a/src/Clients/PullRequestQuantifier.GitHub.Client/PullRequestQuantifier.GitHub.Client.csproj +++ b/src/Clients/PullRequestQuantifier.GitHub.Client/PullRequestQuantifier.GitHub.Client.csproj @@ -12,7 +12,7 @@ - + diff --git a/src/Clients/PullRequestQuantifier.Local.Client/PullRequestQuantifier.Local.Client.csproj b/src/Clients/PullRequestQuantifier.Local.Client/PullRequestQuantifier.Local.Client.csproj index 3df449a..ff72b1c 100644 --- a/src/Clients/PullRequestQuantifier.Local.Client/PullRequestQuantifier.Local.Client.csproj +++ b/src/Clients/PullRequestQuantifier.Local.Client/PullRequestQuantifier.Local.Client.csproj @@ -7,7 +7,7 @@ - + diff --git a/src/PullRequestQuantifier.Abstractions/PullRequestQuantifier.Abstractions.csproj b/src/PullRequestQuantifier.Abstractions/PullRequestQuantifier.Abstractions.csproj index df55e68..5f0c94b 100644 --- a/src/PullRequestQuantifier.Abstractions/PullRequestQuantifier.Abstractions.csproj +++ b/src/PullRequestQuantifier.Abstractions/PullRequestQuantifier.Abstractions.csproj @@ -10,7 +10,7 @@ - + diff --git a/src/PullRequestQuantifier.Common.Tests/PullRequestQuantifier.Common.Tests.csproj b/src/PullRequestQuantifier.Common.Tests/PullRequestQuantifier.Common.Tests.csproj index 52f7578..0badceb 100644 --- a/src/PullRequestQuantifier.Common.Tests/PullRequestQuantifier.Common.Tests.csproj +++ b/src/PullRequestQuantifier.Common.Tests/PullRequestQuantifier.Common.Tests.csproj @@ -6,7 +6,7 @@ - + diff --git a/src/PullRequestQuantifier.Common/PullRequestQuantifier.Common.csproj b/src/PullRequestQuantifier.Common/PullRequestQuantifier.Common.csproj index 5da4346..2c75051 100644 --- a/src/PullRequestQuantifier.Common/PullRequestQuantifier.Common.csproj +++ b/src/PullRequestQuantifier.Common/PullRequestQuantifier.Common.csproj @@ -17,7 +17,7 @@ - + diff --git a/src/PullRequestQuantifier.Feedback.Service/PullRequestQuantifier.Feedback.Service.csproj b/src/PullRequestQuantifier.Feedback.Service/PullRequestQuantifier.Feedback.Service.csproj index c7113e8..0f7bebd 100644 --- a/src/PullRequestQuantifier.Feedback.Service/PullRequestQuantifier.Feedback.Service.csproj +++ b/src/PullRequestQuantifier.Feedback.Service/PullRequestQuantifier.Feedback.Service.csproj @@ -16,7 +16,7 @@ - + diff --git a/src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj b/src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj index 5fd3105..bf594bf 100644 --- a/src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj +++ b/src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj @@ -13,12 +13,12 @@ - + - + diff --git a/src/PullRequestQuantifier.Tests/PullRequestQuantifier.Tests.csproj b/src/PullRequestQuantifier.Tests/PullRequestQuantifier.Tests.csproj index f146178..880d169 100644 --- a/src/PullRequestQuantifier.Tests/PullRequestQuantifier.Tests.csproj +++ b/src/PullRequestQuantifier.Tests/PullRequestQuantifier.Tests.csproj @@ -20,7 +20,7 @@ runtime; build; native; contentfiles; analyzers; buildtransitive - + diff --git a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs index 34c1484..53dc3b9 100644 --- a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs +++ b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs @@ -34,14 +34,10 @@ private static async Task Clone( string pat) { var credentials = new NetworkCredential(userName, pat); - var cloneOptions = new CloneOptions + var cloneOptions = new CloneOptions().FetchOptions.CredentialsProvider = (url, user, cred) => new SecureUsernamePasswordCredentials { - Checkout = true, - CredentialsProvider = (url, user, cred) => new SecureUsernamePasswordCredentials - { - Username = credentials.UserName, - Password = credentials.SecurePassword - } + Username = credentials.UserName, + Password = credentials.SecurePassword }; foreach (var organization in organizations) diff --git a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/PullRequestQuantifier.Tools.CloneAdoRepo.csproj b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/PullRequestQuantifier.Tools.CloneAdoRepo.csproj index 75666e7..8f6bd25 100644 --- a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/PullRequestQuantifier.Tools.CloneAdoRepo.csproj +++ b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/PullRequestQuantifier.Tools.CloneAdoRepo.csproj @@ -9,7 +9,7 @@ - + From 63af6e847685643317d54b8d8320170934dbbc2b Mon Sep 17 00:00:00 2001 From: Aadarsh Indurkhya Date: Tue, 3 Jun 2025 02:13:43 +0530 Subject: [PATCH 4/9] Update build_net_core.yml --- .github/workflows/build_net_core.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build_net_core.yml b/.github/workflows/build_net_core.yml index 428585a..52a827c 100644 --- a/.github/workflows/build_net_core.yml +++ b/.github/workflows/build_net_core.yml @@ -16,11 +16,11 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: fetch-depth: 0 - name: Setup .NET Core - uses: actions/setup-dotnet@v1 + uses: actions/setup-dotnet@v4 with: dotnet-version: 8.0.x @@ -54,7 +54,7 @@ jobs: - name: Upload release artifacts if: github.ref == 'refs/heads/main' - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 with: name: release path: release/* From 0de11e49cade066812efce4704eda0da1cb1b770 Mon Sep 17 00:00:00 2001 From: Aadarsh Indurkhya Date: Mon, 2 Jun 2025 20:55:04 +0000 Subject: [PATCH 5/9] Fixes --- .github/workflows/build_net.yml | 4 ++-- .github/workflows/feedback_service.yml | 4 ++-- .github/workflows/github_client.yml | 4 ++-- .github/workflows/repository_service.yml | 4 ++-- .github/workflows/vscode_client.yml | 6 +++--- .../Program.cs | 10 +++++++--- 6 files changed, 18 insertions(+), 14 deletions(-) diff --git a/.github/workflows/build_net.yml b/.github/workflows/build_net.yml index 6918f52..8918133 100644 --- a/.github/workflows/build_net.yml +++ b/.github/workflows/build_net.yml @@ -16,11 +16,11 @@ jobs: runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: fetch-depth: 0 - name: Setup .NET Core - uses: actions/setup-dotnet@v1 + uses: actions/setup-dotnet@v4 with: dotnet-version: 8.0.x diff --git a/.github/workflows/feedback_service.yml b/.github/workflows/feedback_service.yml index 051462f..d3682a3 100644 --- a/.github/workflows/feedback_service.yml +++ b/.github/workflows/feedback_service.yml @@ -11,11 +11,11 @@ jobs: runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: fetch-depth: 0 - name: Setup .NET Core - uses: actions/setup-dotnet@v1 + uses: actions/setup-dotnet@v4 with: dotnet-version: 8.0.x - name: Install dependencies diff --git a/.github/workflows/github_client.yml b/.github/workflows/github_client.yml index 957fcf5..b8a9809 100644 --- a/.github/workflows/github_client.yml +++ b/.github/workflows/github_client.yml @@ -11,11 +11,11 @@ jobs: runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: fetch-depth: 0 - name: Setup .NET Core - uses: actions/setup-dotnet@v1 + uses: actions/setup-dotnet@v4 with: dotnet-version: 8.0.x - name: Install dependencies diff --git a/.github/workflows/repository_service.yml b/.github/workflows/repository_service.yml index 5eb2c7a..c1c4f3c 100644 --- a/.github/workflows/repository_service.yml +++ b/.github/workflows/repository_service.yml @@ -11,11 +11,11 @@ jobs: runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: fetch-depth: 0 - name: Setup .NET Core - uses: actions/setup-dotnet@v1 + uses: actions/setup-dotnet@v4 with: dotnet-version: 8.0.x - name: Install dependencies diff --git a/.github/workflows/vscode_client.yml b/.github/workflows/vscode_client.yml index c740483..d6ad4fd 100644 --- a/.github/workflows/vscode_client.yml +++ b/.github/workflows/vscode_client.yml @@ -12,11 +12,11 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 with: fetch-depth: 0 - name: Setup .NET Core - uses: actions/setup-dotnet@v1 + uses: actions/setup-dotnet@v4 with: dotnet-version: 8.0.x - name: Install dependencies @@ -36,7 +36,7 @@ jobs: run: dotnet publish src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj --configuration Release --self-contained false -p:PackageVsix=true - name: Upload release artifacts if: github.ref == 'refs/heads/main' - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 with: name: vsix path: src/Clients/PullRequestQuantifier.VsCode.Client/**/*.vsix diff --git a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs index 53dc3b9..e222485 100644 --- a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs +++ b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs @@ -34,10 +34,14 @@ private static async Task Clone( string pat) { var credentials = new NetworkCredential(userName, pat); - var cloneOptions = new CloneOptions().FetchOptions.CredentialsProvider = (url, user, cred) => new SecureUsernamePasswordCredentials + var cloneOptions = new CloneOptions(); + cloneOptions.FetchOptions = new FetchOptions { - Username = credentials.UserName, - Password = credentials.SecurePassword + CredentialsProvider = (url, user, cred) => new SecureUsernamePasswordCredentials + { + Username = credentials.UserName, + Password = credentials.Password // Use .Password, not .SecurePassword + } }; foreach (var organization in organizations) From 73ddf16b10ef018c581d60e946ba6daf9fb892f4 Mon Sep 17 00:00:00 2001 From: Aadarsh Indurkhya Date: Mon, 2 Jun 2025 20:58:27 +0000 Subject: [PATCH 6/9] Test --- .../PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs index e222485..b4c28d5 100644 --- a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs +++ b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs @@ -34,15 +34,18 @@ private static async Task Clone( string pat) { var credentials = new NetworkCredential(userName, pat); - var cloneOptions = new CloneOptions(); - cloneOptions.FetchOptions = new FetchOptions + var fetchOptions = new FetchOptions { CredentialsProvider = (url, user, cred) => new SecureUsernamePasswordCredentials { Username = credentials.UserName, - Password = credentials.Password // Use .Password, not .SecurePassword + Password = credentials.Password } }; + var cloneOptions = new CloneOptions + { + FetchOptions = fetchOptions + }; foreach (var organization in organizations) { From dc90950771e53e2f45de15906a985c6d0574b3b9 Mon Sep 17 00:00:00 2001 From: Aadarsh Indurkhya Date: Mon, 2 Jun 2025 21:19:10 +0000 Subject: [PATCH 7/9] Test --- .../Program.cs | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs index b4c28d5..bc0f033 100644 --- a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs +++ b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs @@ -34,17 +34,11 @@ private static async Task Clone( string pat) { var credentials = new NetworkCredential(userName, pat); - var fetchOptions = new FetchOptions + var cloneOptions = new CloneOptions(); + cloneOptions.FetchOptions.CredentialsProvider = (url, user, cred) => new UsernamePasswordCredentials { - CredentialsProvider = (url, user, cred) => new SecureUsernamePasswordCredentials - { - Username = credentials.UserName, - Password = credentials.Password - } - }; - var cloneOptions = new CloneOptions - { - FetchOptions = fetchOptions + Username = credentials.UserName, + Password = credentials.Password }; foreach (var organization in organizations) From 4dce137483c2b871422b22902fe0fca4a874ff63 Mon Sep 17 00:00:00 2001 From: Aadarsh Indurkhya Date: Mon, 2 Jun 2025 21:22:26 +0000 Subject: [PATCH 8/9] Secure password --- src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs index bc0f033..c7670ba 100644 --- a/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs +++ b/src/Tools/PullRequestQuantifier.Tools.CloneAdoRepo/Program.cs @@ -35,10 +35,10 @@ private static async Task Clone( { var credentials = new NetworkCredential(userName, pat); var cloneOptions = new CloneOptions(); - cloneOptions.FetchOptions.CredentialsProvider = (url, user, cred) => new UsernamePasswordCredentials + cloneOptions.FetchOptions.CredentialsProvider = (url, user, cred) => new SecureUsernamePasswordCredentials { Username = credentials.UserName, - Password = credentials.Password + Password = credentials.SecurePassword }; foreach (var organization in organizations) From 095227069086012cd5c15f52b140715a55f782f2 Mon Sep 17 00:00:00 2001 From: Aadarsh Indurkhya Date: Mon, 2 Jun 2025 21:55:44 +0000 Subject: [PATCH 9/9] Updating the CI pipelines path --- .github/workflows/feedback_service.yml | 2 +- .github/workflows/github_client.yml | 2 +- .github/workflows/repository_service.yml | 2 +- .github/workflows/vscode_client.yml | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/feedback_service.yml b/.github/workflows/feedback_service.yml index d3682a3..d6bfe78 100644 --- a/.github/workflows/feedback_service.yml +++ b/.github/workflows/feedback_service.yml @@ -25,7 +25,7 @@ jobs: - name: Build run: dotnet build src/PullRequestQuantifier.Feedback.Service/PullRequestQuantifier.Feedback.Service.csproj --configuration Release --no-restore - name: dotnet publish - run: dotnet publish src/PullRequestQuantifier.Feedback.Service/PullRequestQuantifier.Feedback.Service.csproj -c Release -o ${{env.DOTNET_ROOT}}/pullrequestquantifierfeedback + run: dotnet publish src/PullRequestQuantifier.Feedback.Service/PullRequestQuantifier.Feedback.Service.csproj -c Release -o "${{env.DOTNET_ROOT}}/pullrequestquantifierfeedback" - name: Deploy to Azure Web App uses: azure/webapps-deploy@v2 with: diff --git a/.github/workflows/github_client.yml b/.github/workflows/github_client.yml index b8a9809..485a993 100644 --- a/.github/workflows/github_client.yml +++ b/.github/workflows/github_client.yml @@ -25,7 +25,7 @@ jobs: - name: Build run: dotnet build src/Clients/PullRequestQuantifier.GitHub.Client/PullRequestQuantifier.GitHub.Client.csproj --configuration Release --no-restore - name: dotnet publish - run: dotnet publish src/Clients/PullRequestQuantifier.GitHub.Client/PullRequestQuantifier.GitHub.Client.csproj -c Release -o ${{env.DOTNET_ROOT}}/pullrequestquantifiergithubclient + run: dotnet publish src/Clients/PullRequestQuantifier.GitHub.Client/PullRequestQuantifier.GitHub.Client.csproj -c Release -o "${{env.DOTNET_ROOT}}/pullrequestquantifiergithubclient" - name: Deploy to Azure Web App if: github.ref == 'refs/heads/main' uses: azure/webapps-deploy@v2 diff --git a/.github/workflows/repository_service.yml b/.github/workflows/repository_service.yml index c1c4f3c..130eb05 100644 --- a/.github/workflows/repository_service.yml +++ b/.github/workflows/repository_service.yml @@ -25,7 +25,7 @@ jobs: - name: Build run: dotnet build src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj --configuration Release --no-restore - name: dotnet publish - run: dotnet publish src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj -c Release -o ${{env.DOTNET_ROOT}}/pullrequestquantifierreposervice + run: dotnet publish src/PullRequestQuantifier.Repository.Service/PullRequestQuantifier.Repository.Service.csproj -c Release -o "${{env.DOTNET_ROOT}}/pullrequestquantifierreposervice" - name: Deploy to Azure Web App uses: azure/webapps-deploy@v2 with: diff --git a/.github/workflows/vscode_client.yml b/.github/workflows/vscode_client.yml index d6ad4fd..186684b 100644 --- a/.github/workflows/vscode_client.yml +++ b/.github/workflows/vscode_client.yml @@ -26,12 +26,12 @@ jobs: - name: Build run: dotnet build src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj --configuration Release --no-restore - - name: dotnet publish win10-x64 - run: dotnet publish src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj --configuration Release --self-contained false -r win10-x64 + - name: dotnet publish win-x64 + run: dotnet publish src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj --configuration Release --self-contained false -r win-x64 - name: dotnet publish linux-x64 run: dotnet publish src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj --configuration Release --self-contained false -r linux-x64 - - name: dotnet publish osx-x64 - run: dotnet publish src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj --configuration Release --self-contained false -r osx-x64 + - name: dotnet publish osx-64 + run: dotnet publish src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj --configuration Release --self-contained false -r osx-64 - name: dotnet publish vsix run: dotnet publish src/Clients/PullRequestQuantifier.VsCode.Client/PullRequestQuantifier.VsCode.Client.csproj --configuration Release --self-contained false -p:PackageVsix=true - name: Upload release artifacts