Commit d8ee50a
authored
Fix coalesced Team permission property (#361)
When retrieving the permissions granted to a team for a repository, the API returns an array of booleans indicating what individual permissions the team currently has.
| name | permissions granted |
| ---- | ------------------ |
| pull | pull |
| triage | pull, triage |
| push | pull, triage, push |
| maintain | pull, triage, push, maintain |
| admin | pull, triage, push, maintain, admin |
As you can see, each permissions builds on top of the previous permission. When adding extra properties to this returned object via `Add-GitHubRepositoryTeamPermissionAdditionalProperties`, we also add a new `permission` property that attempts to represent the collection of permissions with their current top-permission level.
The logic however incorrectly favored `push` over `maintain` and thus would always said that a Team had `push` permission when in fact it may have actually had `maintain` permission.
This simple change corrects that ordering mistake.1 parent 4d7667b commit d8ee50a
1 file changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3925 | 3925 | | |
3926 | 3926 | | |
3927 | 3927 | | |
3928 | | - | |
3929 | | - | |
3930 | | - | |
3931 | | - | |
3932 | 3928 | | |
3933 | 3929 | | |
3934 | 3930 | | |
3935 | 3931 | | |
| 3932 | + | |
| 3933 | + | |
| 3934 | + | |
| 3935 | + | |
3936 | 3936 | | |
3937 | 3937 | | |
3938 | 3938 | | |
| |||
0 commit comments