PR feedback

Author: johnterickson

src/Common.Tests/PluginSettingsTests.cs

@@ -95,7 +95,7 @@ public void LocalCacheSizeInMegabytesSetting()
             new[] { 123u, 456u, 789u });
 
     [TestMethod]
-    public void ForceCacheMissBitMaskSetting()
+    public void ForceCacheMissPercentageSetting()
         => TestBasicSetting(
             nameof(PluginSettings.ForceCacheMissPercentage),
             pluginSettings => pluginSettings.ForceCacheMissPercentage,

src/Common/MSBuildCachePluginBase.cs

@@ -355,11 +355,15 @@ private async Task<CacheResult> GetCacheResultInnerAsync(BuildRequestData buildR
         if (Settings.ForceCacheMissPercentage != 0)
         {
             // use a hash of the project id so that it is repeatable
-#pragma warning disable CA1850 // ComputeHash is not in net472
+
+#if NETFRAMEWORK
             using SHA256 hasher = SHA256.Create();
             byte[] projectHash = hasher.ComputeHash(Encoding.UTF8.GetBytes(nodeContext.Id));
+#else
+            byte[] projectHash = SHA256.HashData(Encoding.UTF8.GetBytes(nodeContext.Id));
+#endif
+
             uint hashInt = BitConverter.ToUInt32(projectHash, 0);
-#pragma warning restore CA1850
             if ((hashInt % 100) < Settings.ForceCacheMissPercentage)
             {
                 logger.LogMessage($"Forcing an otherwise 'cache hit' to be a 'cache miss' because of ForceCacheMissPercentage.");