fix: address PR review feedback

1. Fix sed regex: replace \s with [[:space:]] for portable whitespace
   matching in version extraction (review comment on line 333)

2. Expand version-bump check scope to include .github/skills/** in
   addition to plugin/skills/** (review comment on line 205)

3. Make license and metadata.version checks produce warnings instead
   of errors in frontmatter CLI. Missing fields are reported as
   warnings (⚠️) that don't fail the workflow; invalid formats
   (e.g. bad semver) remain errors (❌) that do fail. Updated tests
   to verify warning severity. (review comment on cli.ts:236)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: spboyer

.github/workflows/pr.yml

@@ -203,6 +203,7 @@ jobs:
         with:
           files: |
             plugin/skills/**
+            .github/skills/**
 
       - name: Setup Node.js
         if: steps.changed-skills.outputs.any_changed == 'true'
@@ -307,7 +308,7 @@ jobs:
           SKILL_FILES=""
           for file in ${{ steps.changed-plugin-skills.outputs.all_changed_files }}; do
             dir=$(dirname "$file")
-            while [ "$dir" != "plugin/skills" ] && [ "$dir" != "plugin" ] && [ "$dir" != "." ]; do
+            while [ "$dir" != "plugin/skills" ] && [ "$dir" != ".github/skills" ] && [ "$dir" != "plugin" ] && [ "$dir" != ".github" ] && [ "$dir" != "." ]; do
               if [ -f "$dir/SKILL.md" ]; then
                 SKILL_FILES="$SKILL_FILES $dir/SKILL.md"
                 break
@@ -326,11 +327,11 @@ jobs:
           fi
 
           for skill_file in $SKILL_FILES; do
-            # Get version in base branch
-            BASE_VERSION=$(git show origin/${{ github.base_ref }}:"$skill_file" 2>/dev/null | sed -n '/^---$/,/^---$/p' | grep -E '^\s+version:' | head -1 | sed 's/.*version:\s*"\{0,1\}\([^"]*\)"\{0,1\}/\1/' || echo "")
+            # Get version in base branch (use [[:space:]] for portable whitespace matching)
+            BASE_VERSION=$(git show origin/${{ github.base_ref }}:"$skill_file" 2>/dev/null | sed -n '/^---$/,/^---$/p' | grep -E '^[[:space:]]+version:' | head -1 | sed 's/.*version:[[:space:]]*"\{0,1\}\([^"]*\)"\{0,1\}/\1/' || echo "")
 
             # Get version in PR branch
-            HEAD_VERSION=$(sed -n '/^---$/,/^---$/p' "$skill_file" | grep -E '^\s+version:' | head -1 | sed 's/.*version:\s*"\{0,1\}\([^"]*\)"\{0,1\}/\1/')
+            HEAD_VERSION=$(sed -n '/^---$/,/^---$/p' "$skill_file" | grep -E '^[[:space:]]+version:' | head -1 | sed 's/.*version:[[:space:]]*"\{0,1\}\([^"]*\)"\{0,1\}/\1/')
 
             # New skill (no base version) — skip, it starts at 1.0.0
             if [ -z "$BASE_VERSION" ]; then

scripts/src/frontmatter/__tests__/frontmatter.test.ts

@@ -259,20 +259,23 @@ describe("Frontmatter Spec Validator", () => {
       expect(validateLicense("MIT")).toEqual([]);
     });
 
-    it("fails for missing license", () => {
+    it("warns for missing license", () => {
       const issues = validateLicense(undefined);
       expect(issues).toHaveLength(1);
       expect(issues[0].check).toBe("license");
+      expect(issues[0].severity).toBe("warning");
     });
 
-    it("fails for null license", () => {
+    it("warns for null license", () => {
       const issues = validateLicense(null);
       expect(issues).toHaveLength(1);
+      expect(issues[0].severity).toBe("warning");
     });
 
-    it("fails for empty license", () => {
+    it("warns for empty license", () => {
       const issues = validateLicense("");
       expect(issues).toHaveLength(1);
+      expect(issues[0].severity).toBe("warning");
     });
 
     it("fails for non-string license", () => {
@@ -293,16 +296,18 @@ describe("Frontmatter Spec Validator", () => {
       expect(validateMetadataVersion({ version: "3.2.1" })).toEqual([]);
     });
 
-    it("fails for missing metadata", () => {
+    it("warns for missing metadata", () => {
       const issues = validateMetadataVersion(undefined);
       expect(issues).toHaveLength(1);
       expect(issues[0].check).toBe("metadata-version");
+      expect(issues[0].severity).toBe("warning");
     });
 
-    it("fails for missing version in metadata", () => {
+    it("warns for missing version in metadata", () => {
       const issues = validateMetadataVersion({ author: "Microsoft" });
       expect(issues).toHaveLength(1);
       expect(issues[0].check).toBe("metadata-version");
+      expect(issues[0].severity).toBe("warning");
     });
 
     it("fails for non-semver version", () => {

scripts/src/frontmatter/cli.ts

@@ -38,6 +38,7 @@ const META_SKILLS_DIR = resolve(REPO_ROOT, ".github", "skills");
 export interface ValidationIssue {
   check: string;     // Check identifier (e.g., "name-format", "description-format")
   message: string;   // Human-readable explanation
+  severity?: "error" | "warning";  // Defaults to "error" if omitted
 }
 
 export interface ValidationResult {
@@ -188,6 +189,7 @@ export function validateLicense(license: unknown): ValidationIssue[] {
     issues.push({
       check: "license",
       message: "Missing 'license' field in frontmatter",
+      severity: "warning",
     });
   } else if (typeof license !== "string") {
     issues.push({
@@ -209,6 +211,7 @@ export function validateMetadataVersion(metadata: unknown): ValidationIssue[] {
     issues.push({
       check: "metadata-version",
       message: "Missing 'metadata' block with 'version' field in frontmatter",
+      severity: "warning",
     });
     return issues;
   }
@@ -220,6 +223,7 @@ export function validateMetadataVersion(metadata: unknown): ValidationIssue[] {
     issues.push({
       check: "metadata-version",
       message: "Missing 'version' in metadata block",
+      severity: "warning",
     });
     return issues;
   }
@@ -332,31 +336,41 @@ function main(): void {
   console.log("\n📋 Frontmatter Spec Validator\n");
   console.log("────────────────────────────────────────────────────────────");
 
-  let totalIssues = 0;
+  let totalErrors = 0;
+  let totalWarnings = 0;
   let skillsWithIssues = 0;
 
   for (const file of skillFiles) {
     const result = validateSkillFile(file);
+    const errors = result.issues.filter(i => i.severity !== "warning");
+    const warnings = result.issues.filter(i => i.severity === "warning");
 
     if (result.issues.length === 0) {
       console.log(`  ✅ ${result.skill}`);
     } else {
-      skillsWithIssues++;
-      totalIssues += result.issues.length;
-
-      console.log(`  ❌ ${result.skill} — ${result.issues.length} issue(s)`);
-      for (const issue of result.issues) {
-        console.log(`     [${issue.check}] ${issue.message}`);
+      if (errors.length > 0) skillsWithIssues++;
+      totalErrors += errors.length;
+      totalWarnings += warnings.length;
+
+      const icon = errors.length > 0 ? "❌" : "⚠️";
+      console.log(`  ${icon} ${result.skill} — ${errors.length} error(s), ${warnings.length} warning(s)`);
+      for (const issue of errors) {
+        console.log(`     ❌ [${issue.check}] ${issue.message}`);
+      }
+      for (const issue of warnings) {
+        console.log(`     ⚠️  [${issue.check}] ${issue.message}`);
       }
     }
   }
 
   console.log("\n────────────────────────────────────────────────────────────");
 
-  if (totalIssues === 0) {
+  if (totalErrors === 0 && totalWarnings === 0) {
     console.log(`\n✅ All ${skillFiles.length} skill(s) passed frontmatter validation.\n`);
+  } else if (totalErrors === 0) {
+    console.log(`\n✅ All ${skillFiles.length} skill(s) passed with ${totalWarnings} warning(s).\n`);
   } else {
-    console.log(`\n❌ ${totalIssues} issue(s) found in ${skillsWithIssues} skill(s).\n`);
+    console.log(`\n❌ ${totalErrors} error(s) and ${totalWarnings} warning(s) found in ${skillsWithIssues} skill(s).\n`);
     process.exitCode = 1;
   }
 }