[SPIR-V] Add SPV_EXT_descriptor_heap + SPV_KHR_untyped_pointers codegen#8517
Open
jzakharovnv wants to merge 1 commit into
Open
[SPIR-V] Add SPV_EXT_descriptor_heap + SPV_KHR_untyped_pointers codegen#8517jzakharovnv wants to merge 1 commit into
jzakharovnv wants to merge 1 commit into
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
jzakharovnv
force-pushed
the
pr1-descriptor-heap-core
branch
from
4b4b143 to
f640327
Compare
Building off of microsoft#8281, this commit adds a native lowering via SPV_EXT_descriptor_heap and SPV_KHR_untyped_pointers. ResourceDescriptorHeap and SamplerDescriptorHeap are lowered to untyped variables decorated with ResourceHeapEXT and SamplerHeapEXT. Each heap access emits OpUntypedAccessChainKHR into a runtime array of the appropriate descriptor type. Buffer-like resources (StructuredBuffer, ByteAddressBuffer, ConstantBuffer, TextureBuffer) use OpTypeBufferEXT and OpBufferPointerEXT; image and sampler resources use OpLoad. Interlocked operations on RWTexture use OpUntypedImageTexelPointerEXT. Requires -fspv-target-env=vulkan1.3. Assisted-by: Claude.
jzakharovnv
force-pushed
the
pr1-descriptor-heap-core
branch
from
f640327 to
cbcae38
Compare
Author
|
@microsoft-github-policy-service agree company="NVIDIA" |
dnovillo
suggested changes
Jun 8, 2026
dnovillo
left a comment
dnovillo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this! I just started looking at it and have a couple of questions. I'll add more as I read the PRs.
| SpirvEmitter::getDescriptorHeapRuntimeArrayType(const SpirvType *elemType, | ||
| bool onSamplerHeap) { | ||
| constexpr uint32_t kDefaultResourceHeapStride = 64; | ||
| constexpr uint32_t kDefaultSamplerHeapStride = 32; |
Collaborator
There was a problem hiding this comment.
I think I would float these defaults to SpirvEmitter.h and document where the seemingly magic values 32 and 64 come from.
| constexpr uint32_t kDefaultSamplerHeapStride = 32; | ||
| const uint32_t stride = | ||
| onSamplerHeap ? kDefaultSamplerHeapStride : kDefaultResourceHeapStride; | ||
| return spvContext.getRuntimeArrayType(elemType, stride); |
Collaborator
There was a problem hiding this comment.
It doesn't seem that there are tests for OpDecorate ArrayStride N in this PR. I haven't checked the others. Could you add one (unless I missed it?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building off of #8281, this PR adds a native lowering via SPV_EXT_descriptor_heap and SPV_KHR_untyped_pointers and is part 1/4 in a series.
ResourceDescriptorHeap and SamplerDescriptorHeap are lowered to untyped variables decorated with ResourceHeapEXT and SamplerHeapEXT. Each heap access emits OpUntypedAccessChainKHR into a runtime array of the appropriate descriptor type. Buffer-like resources (StructuredBuffer, ByteAddressBuffer, ConstantBuffer, TextureBuffer) use OpTypeBufferEXT and OpBufferPointerEXT; image and sampler resources use OpLoad. Interlocked operations on RWTexture use OpUntypedImageTexelPointerEXT.
Requires -fspv-target-env=vulkan1.3.
Assisted by an AI agent.
@dnovillo