Make record_output_messages append messages instead of replacing

Changed the behavior of record_output_messages to append new messages to
the accumulated list rather than replacing all messages. This allows
collecting output messages over multiple calls during the scope's lifetime.

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

Author: Copilot

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/spans_scopes/output_scope.py

@@ -60,13 +60,19 @@ def __init__(
             parent_id=parent_id,
         )
 
+        # Initialize accumulated messages list
+        self._output_messages: list[str] = list(response.messages)
+
         # Set response messages
-        self.set_tag_maybe(GEN_AI_OUTPUT_MESSAGES_KEY, safe_json_dumps(response.messages))
+        self.set_tag_maybe(GEN_AI_OUTPUT_MESSAGES_KEY, safe_json_dumps(self._output_messages))
 
     def record_output_messages(self, messages: list[str]) -> None:
         """Records the output messages for telemetry tracking.
 
+        Appends the provided messages to the accumulated output messages list.
+
         Args:
-            messages: List of output messages
+            messages: List of output messages to append
         """
-        self.set_tag_maybe(GEN_AI_OUTPUT_MESSAGES_KEY, safe_json_dumps(messages))
+        self._output_messages.extend(messages)
+        self.set_tag_maybe(GEN_AI_OUTPUT_MESSAGES_KEY, safe_json_dumps(self._output_messages))

tests/observability/core/test_output_scope.py

@@ -141,14 +141,14 @@ def test_multiple_output_messages(self):
         self.assertIn("Third response", output_value)
 
     def test_record_output_messages_updates_span(self):
-        """Test that record_output_messages updates the span with new messages."""
+        """Test that record_output_messages appends messages to the span."""
         response = Response(messages=["Initial message"])
 
         scope = OutputScope.start(self.agent_details, self.tenant_details, response)
 
         if scope is not None:
-            # Record updated messages
-            scope.record_output_messages(["Updated message 1", "Updated message 2"])
+            # Record additional messages (should append, not replace)
+            scope.record_output_messages(["Appended message 1", "Appended message 2"])
             scope.dispose()
 
         finished_spans = self.span_exporter.get_finished_spans()
@@ -163,10 +163,37 @@ def test_record_output_messages_updates_span(self):
             "Expected output messages key to be set on span",
         )
 
-        # The span should have the updated messages
+        # The span should have all messages (initial + appended)
         output_value = span_attributes[GEN_AI_OUTPUT_MESSAGES_KEY]
-        self.assertIn("Updated message 1", output_value)
-        self.assertIn("Updated message 2", output_value)
+        self.assertIn("Initial message", output_value)
+        self.assertIn("Appended message 1", output_value)
+        self.assertIn("Appended message 2", output_value)
+
+    def test_record_output_messages_multiple_appends(self):
+        """Test that multiple calls to record_output_messages accumulate messages."""
+        response = Response(messages=["First message"])
+
+        scope = OutputScope.start(self.agent_details, self.tenant_details, response)
+
+        if scope is not None:
+            # First append
+            scope.record_output_messages(["Second message"])
+            # Second append
+            scope.record_output_messages(["Third message", "Fourth message"])
+            scope.dispose()
+
+        finished_spans = self.span_exporter.get_finished_spans()
+        self.assertTrue(finished_spans, "Expected at least one span to be created")
+
+        span = finished_spans[-1]
+        span_attributes = getattr(span, "attributes", {}) or {}
+
+        output_value = span_attributes[GEN_AI_OUTPUT_MESSAGES_KEY]
+        # All four messages should be present
+        self.assertIn("First message", output_value)
+        self.assertIn("Second message", output_value)
+        self.assertIn("Third message", output_value)
+        self.assertIn("Fourth message", output_value)
 
     def test_output_scope_context_manager(self):
         """Test that OutputScope works as a context manager."""