address copilot review

Author: nikhilc-microsoft

libraries/microsoft-agents-a365-observability-extensions-semantickernel/microsoft_agents_a365/observability/extensions/semantickernel/span_enricher.py

@@ -63,19 +63,11 @@ def enrich_semantic_kernel_span(span: ReadableSpan) -> ReadableSpan:
 
     # Map tool attributes for execute_tool spans
     elif span.name.startswith(EXECUTE_TOOL_OPERATION_NAME):
-        # Map SK's gen_ai.tool.arguments to standard gen_ai.tool.call.arguments
-        tool_arguments = attributes.get(GEN_AI_TOOL_ARGS_KEY) or attributes.get(
-            SK_TOOL_CALL_ARGUMENTS_KEY
-        )
-        if tool_arguments:
-            extra_attributes[GEN_AI_TOOL_ARGS_KEY] = tool_arguments
+        if SK_TOOL_CALL_ARGUMENTS_KEY in attributes:
+            extra_attributes[GEN_AI_TOOL_ARGS_KEY] = attributes[SK_TOOL_CALL_ARGUMENTS_KEY]
 
-        # Map SK's tool result to standard gen_ai.tool.call.result
-        tool_result = attributes.get(GEN_AI_TOOL_CALL_RESULT_KEY) or attributes.get(
-            SK_TOOL_CALL_RESULT_KEY
-        )
-        if tool_result:
-            extra_attributes[GEN_AI_TOOL_CALL_RESULT_KEY] = tool_result
+        if SK_TOOL_CALL_RESULT_KEY in attributes:
+            extra_attributes[GEN_AI_TOOL_CALL_RESULT_KEY] = attributes[SK_TOOL_CALL_RESULT_KEY]
 
     if extra_attributes:
         return EnrichedReadableSpan(span, extra_attributes)

libraries/microsoft-agents-a365-observability-extensions-semantickernel/microsoft_agents_a365/observability/extensions/semantickernel/span_processor.py

@@ -9,6 +9,7 @@
 from microsoft_agents_a365.observability.core.execution_type import ExecutionType
 from microsoft_agents_a365.observability.core.inference_operation_type import InferenceOperationType
 from microsoft_agents_a365.observability.core.utils import extract_model_name
+from opentelemetry import context as context_api
 from opentelemetry.sdk.trace import ReadableSpan, Span
 from opentelemetry.sdk.trace.export import SpanProcessor
 
@@ -27,7 +28,7 @@ def __init__(self, service_name: str | None = None):
         """
         self.service_name = service_name
 
-    def on_start(self, span: Span, parent_context) -> None:
+    def on_start(self, span: Span, parent_context: context_api.Context | None) -> None:
         """
         Modify span while it's still writable.
 
@@ -48,10 +49,6 @@ def on_start(self, span: Span, parent_context) -> None:
     def on_end(self, span: ReadableSpan) -> None:
         """
         Called when a span ends.
-
-        Note: For on_end modifications, use the span enricher pattern
-        (enrich_semantic_kernel_span) which is registered with the core SDK.
-        This ensures enriched attributes propagate to the exporter.
         """
         pass