Commit cac6bb3
Add clarifying comments for urlparse edge case
- Added comments explaining why checking for '://' is necessary
- urlparse treats 'example.com:8080' as having scheme='example.com', so we need to check for '://' to distinguish between real protocols and domain:port format
- All 28 tests still passing
Co-authored-by: sergioescalera <8428450+sergioescalera@users.noreply.github.com>1 parent 6800198 commit cac6bb3
File tree
2 files changed
+3
-0
lines changed- libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/exporters
2 files changed
+3
-0
lines changedLines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| 108 | + | |
108 | 109 | | |
109 | 110 | | |
110 | 111 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
| 162 | + | |
| 163 | + | |
162 | 164 | | |
163 | 165 | | |
164 | 166 | | |
| |||
0 commit comments