Align middleware with Middleware Protocol; consolidate tests (#187)

* Initial plan

* Add BaggageMiddleware, OutputLoggingMiddleware, and ObservabilityHostingManager

Implement Python equivalents of the Node.js PR #210 middleware:
- BaggageMiddleware: propagates OpenTelemetry baggage from TurnContext
- OutputLoggingMiddleware: creates OutputScope spans for outgoing messages
- ObservabilityHostingManager: singleton to configure hosting middleware
- 19 unit tests covering all three middleware components

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

* Update ObservabilityHostingManager.configure to use ChannelAdapter type and require non-None params

- Replace _AdapterLike protocol with actual ChannelAdapter from microsoft_agents.hosting.core
- Make adapter and options required (non-optional) parameters
- Raise TypeError if either is None
- Update tests to match new contract

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

* Use MiddlewareSet type for adapter and Activity helper methods instead of direct attribute access

- Change adapter param type from ChannelAdapter to MiddlewareSet (the actual
  middleware registration object)
- Use activity.get_agentic_instance_id() instead of recipient.agentic_app_id
- Use activity.get_agentic_user() instead of recipient.agentic_user_id
- Update test to use agentic role for proper helper method behavior

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

* Fix ObservabilityHostingManager.configure to accept MiddlewareSet instead of ChannelAdapter

ChannelAdapter is an ABC (CloudAdapter extends ChannelServiceAdapter extends
ChannelAdapter). The adapter HAS-A MiddlewareSet (composition) — it is not one.
The configure() method only needs the middleware registration object, so accept
MiddlewareSet directly. Users pass adapter.middleware_set.

Rename parameter from 'adapter' to 'middleware_set' for clarity.

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

* Address review comments: fix logic callback type, gate on is_agentic_request

- Fix `logic` type annotation from `Callable[[TurnContext], Awaitable]` to
  `Callable[[], Awaitable]` in both BaggageMiddleware and
  OutputLoggingMiddleware. At runtime, MiddlewareSet passes a zero-arg
  `call_next_middleware` closure, so the annotation now matches the callsite.

- Gate `_derive_agent_details` on `activity.is_agentic_request()` to avoid
  emitting spans with empty agent_id for non-agentic requests.

- Remove unused `logging`/`logger` from baggage_middleware.py.

- Update test recipient role from "assistant" to "agenticAppInstance" to
  exercise the intended agentic code path.

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

* Revert logic type to Callable[[TurnContext], Awaitable] to match Middleware Protocol; consolidate tests

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Co-authored-by: Nikhil Navakiran <nikhil.navakiran@gmail.com>

Author: Copilot

libraries/microsoft-agents-a365-observability-hosting/microsoft_agents_a365/observability/hosting/__init__.py

@@ -4,3 +4,18 @@
 """
 Microsoft Agent 365 Observability Hosting Library.
 """
+
+from .middleware.baggage_middleware import BaggageMiddleware
+from .middleware.observability_hosting_manager import (
+    ObservabilityHostingManager,
+    ObservabilityHostingOptions,
+)
+from .middleware.output_logging_middleware import A365_PARENT_SPAN_KEY, OutputLoggingMiddleware
+
+__all__ = [
+    "BaggageMiddleware",
+    "OutputLoggingMiddleware",
+    "A365_PARENT_SPAN_KEY",
+    "ObservabilityHostingManager",
+    "ObservabilityHostingOptions",
+]

libraries/microsoft-agents-a365-observability-hosting/microsoft_agents_a365/observability/hosting/middleware/__init__.py

@@ -0,0 +1,14 @@
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+
+from .baggage_middleware import BaggageMiddleware
+from .observability_hosting_manager import ObservabilityHostingManager, ObservabilityHostingOptions
+from .output_logging_middleware import A365_PARENT_SPAN_KEY, OutputLoggingMiddleware
+
+__all__ = [
+    "BaggageMiddleware",
+    "OutputLoggingMiddleware",
+    "A365_PARENT_SPAN_KEY",
+    "ObservabilityHostingManager",
+    "ObservabilityHostingOptions",
+]

libraries/microsoft-agents-a365-observability-hosting/microsoft_agents_a365/observability/hosting/middleware/baggage_middleware.py

@@ -0,0 +1,44 @@
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+
+"""Middleware that propagates OpenTelemetry baggage context derived from TurnContext."""
+
+from __future__ import annotations
+
+from collections.abc import Awaitable, Callable
+
+from microsoft_agents.activity import ActivityEventNames, ActivityTypes
+from microsoft_agents.hosting.core.turn_context import TurnContext
+from microsoft_agents_a365.observability.core.middleware.baggage_builder import BaggageBuilder
+
+from ..scope_helpers.populate_baggage import populate
+
+
+class BaggageMiddleware:
+    """Middleware that propagates OpenTelemetry baggage context derived from TurnContext.
+
+    Async replies (ContinueConversation) are passed through without baggage setup.
+    """
+
+    async def on_turn(
+        self,
+        context: TurnContext,
+        logic: Callable[[TurnContext], Awaitable],
+    ) -> None:
+        activity = context.activity
+        is_async_reply = (
+            activity is not None
+            and activity.type == ActivityTypes.event
+            and activity.name == ActivityEventNames.continue_conversation
+        )
+
+        if is_async_reply:
+            await logic()
+            return
+
+        builder = BaggageBuilder()
+        populate(builder, context)
+        baggage_scope = builder.build()
+
+        with baggage_scope:
+            await logic()

libraries/microsoft-agents-a365-observability-hosting/microsoft_agents_a365/observability/hosting/middleware/observability_hosting_manager.py

@@ -0,0 +1,101 @@
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+
+"""Singleton manager for configuring hosting-layer observability middleware."""
+
+from __future__ import annotations
+
+import logging
+from dataclasses import dataclass
+
+from microsoft_agents.hosting.core.middleware_set import MiddlewareSet
+
+from .baggage_middleware import BaggageMiddleware
+from .output_logging_middleware import OutputLoggingMiddleware
+
+logger = logging.getLogger(__name__)
+
+
+@dataclass
+class ObservabilityHostingOptions:
+    """Configuration options for the hosting observability layer."""
+
+    enable_baggage: bool = False
+    """Enable baggage propagation middleware. Defaults to ``False``."""
+
+    enable_output_logging: bool = False
+    """Enable output logging middleware for tracing outgoing messages. Defaults to ``False``."""
+
+
+class ObservabilityHostingManager:
+    """Singleton manager for configuring hosting-layer observability middleware.
+
+    Example:
+        .. code-block:: python
+
+            ObservabilityHostingManager.configure(adapter.middleware_set, ObservabilityHostingOptions(
+                enable_output_logging=True,
+            ))
+    """
+
+    _instance: ObservabilityHostingManager | None = None
+
+    def __init__(self) -> None:
+        """Private constructor — use :meth:`configure` instead."""
+
+    @classmethod
+    def configure(
+        cls,
+        middleware_set: MiddlewareSet,
+        options: ObservabilityHostingOptions,
+    ) -> ObservabilityHostingManager:
+        """Configure the singleton instance and register middleware.
+
+        Subsequent calls after the first are no-ops and return the existing instance.
+
+        Args:
+            middleware_set: The middleware set to register middleware on
+                (e.g., ``adapter.middleware_set``).
+            options: Configuration options controlling which middleware to enable.
+
+        Returns:
+            The singleton :class:`ObservabilityHostingManager` instance.
+
+        Raises:
+            TypeError: If *middleware_set* or *options* is ``None``.
+        """
+        if middleware_set is None:
+            raise TypeError("middleware_set must not be None")
+        if options is None:
+            raise TypeError("options must not be None")
+
+        if cls._instance is not None:
+            logger.warning(
+                "[ObservabilityHostingManager] Already configured. "
+                "Subsequent configure() calls are ignored."
+            )
+            return cls._instance
+
+        instance = cls()
+
+        if options.enable_baggage:
+            middleware_set.use(BaggageMiddleware())
+            logger.info("[ObservabilityHostingManager] BaggageMiddleware registered.")
+
+        if options.enable_output_logging:
+            middleware_set.use(OutputLoggingMiddleware())
+            logger.info("[ObservabilityHostingManager] OutputLoggingMiddleware registered.")
+
+        logger.info(
+            "[ObservabilityHostingManager] Configured. Baggage: %s, OutputLogging: %s.",
+            options.enable_baggage,
+            options.enable_output_logging,
+        )
+
+        cls._instance = instance
+        return instance
+
+    @classmethod
+    def reset(cls) -> None:
+        """Reset the singleton instance. Intended for testing only."""
+        cls._instance = None