address ci copilot comments

Author: nikhilc-microsoft

.github/workflows/ci.yml

@@ -120,18 +120,19 @@ jobs:
 
     - name: Run unit tests
       run: |
-        uv run --frozen python -m pytest tests/ -v --tb=short -m "not integration"
+        uv run --frozen pytest tests/ -v --tb=short -m "not integration"
 
     - name: Run integration tests
       # Only run integration tests if secrets are available
       if: ${{ vars.RUN_INTEGRATION_TESTS == 'true' }}
       run: |
-        uv run --frozen python -m pytest tests/integration/ -v --tb=short -m integration
+        uv run --frozen pytest -m integration -v --tb=short
       env:
         AZURE_OPENAI_API_KEY: ${{ secrets.AZURE_OPENAI_API_KEY }}
         AZURE_OPENAI_ENDPOINT: ${{ vars.AZURE_OPENAI_ENDPOINT }}
         AZURE_OPENAI_DEPLOYMENT: ${{ vars.AZURE_OPENAI_DEPLOYMENT }}
         AZURE_OPENAI_API_VERSION: ${{ vars.AZURE_OPENAI_API_VERSION }}        
+        ENABLE_OBSERVABILITY: true
 
     # Copy package and samples to drop folder
     - name: Copy package and samples to drop folder

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/inference_scope.py

@@ -20,6 +20,7 @@
 from .opentelemetry_scope import OpenTelemetryScope
 from .request import Request
 from .tenant_details import TenantDetails
+from .utils import safe_json_dumps
 
 
 class InferenceScope(OpenTelemetryScope):
@@ -85,7 +86,7 @@ def __init__(
         )
         self.set_tag_maybe(
             GEN_AI_RESPONSE_FINISH_REASONS_KEY,
-            ",".join(details.finishReasons) if details.finishReasons else None,
+            safe_json_dumps(details.finishReasons) if details.finishReasons else None,
         )
         self.set_tag_maybe(GEN_AI_RESPONSE_ID_KEY, details.responseId)
 
@@ -95,15 +96,15 @@ def record_input_messages(self, messages: List[str]) -> None:
         Args:
             messages: List of input messages
         """
-        self.set_tag_maybe(GEN_AI_INPUT_MESSAGES_KEY, ",".join(messages))
+        self.set_tag_maybe(GEN_AI_INPUT_MESSAGES_KEY, safe_json_dumps(messages))
 
     def record_output_messages(self, messages: List[str]) -> None:
         """Records the output messages for telemetry tracking.
 
         Args:
             messages: List of output messages
         """
-        self.set_tag_maybe(GEN_AI_OUTPUT_MESSAGES_KEY, ",".join(messages))
+        self.set_tag_maybe(GEN_AI_OUTPUT_MESSAGES_KEY, safe_json_dumps(messages))
 
     def record_input_tokens(self, input_tokens: int) -> None:
         """Records the number of input tokens for telemetry tracking.
@@ -128,7 +129,7 @@ def record_finish_reasons(self, finish_reasons: List[str]) -> None:
             finish_reasons: List of finish reasons
         """
         if finish_reasons:
-            self.set_tag_maybe(GEN_AI_RESPONSE_FINISH_REASONS_KEY, ",".join(finish_reasons))
+            self.set_tag_maybe(GEN_AI_RESPONSE_FINISH_REASONS_KEY, safe_json_dumps(finish_reasons))
 
     def record_thought_process(self, thought_process: str) -> None:
         """Records the thought process.

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/invoke_agent_scope.py

@@ -32,6 +32,7 @@
 from .opentelemetry_scope import OpenTelemetryScope
 from .request import Request
 from .tenant_details import TenantDetails
+from .utils import safe_json_dumps
 
 
 class InvokeAgentScope(OpenTelemetryScope):
@@ -154,12 +155,12 @@ def record_input_messages(self, messages: list[str]) -> None:
         Args:
             messages: List of input messages to record
         """
-        self.set_tag_maybe(GEN_AI_INPUT_MESSAGES_KEY, ",".join(messages))
+        self.set_tag_maybe(GEN_AI_INPUT_MESSAGES_KEY, safe_json_dumps(messages))
 
     def record_output_messages(self, messages: list[str]) -> None:
         """Record the output messages for telemetry tracking.
 
         Args:
             messages: List of output messages to record
         """
-        self.set_tag_maybe(GEN_AI_OUTPUT_MESSAGES_KEY, ",".join(messages))
+        self.set_tag_maybe(GEN_AI_OUTPUT_MESSAGES_KEY, safe_json_dumps(messages))