Skip to content

Commit 50387b6

Browse files
CopilotJesuTerraz
andauthored
Fix Google ADK extension documentation and log messages (#160)
* Initial plan * Fix documentation and log message for in-place agent modification Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com> * Remove redundant comment from documentation example Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>
1 parent bdf4ba6 commit 50387b6

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

libraries/microsoft-agents-a365-tooling-extensions-google/docs/design.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ from microsoft_agents_a365.tooling.extensions.google import McpToolRegistrationS
1717

1818
service = McpToolRegistrationService()
1919

20-
# Create agent with MCP tools
21-
agent = await service.add_tool_servers_to_agent(
20+
# Add MCP tools to existing agent (modified in place)
21+
await service.add_tool_servers_to_agent(
2222
agent=existing_agent,
2323
auth=auth_context,
2424
auth_handler_name="graph",
@@ -39,7 +39,7 @@ McpToolRegistrationService.add_tool_servers_to_agent()
3939
4040
├── Exchange token for MCP scope
4141
├── Create McpToolset for each server
42-
└── Create new Agent with all tools
42+
└── Modify agent in place to add all tools
4343
4444
4545
Google ADK Agent with MCP tools

libraries/microsoft-agents-a365-tooling-extensions-google/microsoft_agents_a365/tooling/extensions/google/services/mcp_tool_registration_service.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,8 @@ async def add_tool_servers_to_agent(
121121
all_tools = list(agent.tools) + mcp_servers_info
122122

123123
self._logger.info(
124-
f"Successfully configured {len(all_tools)} total MCP tool servers for agent"
124+
f"Successfully configured agent with {len(mcp_servers_info)} MCP tool servers "
125+
f"(total tools: {len(all_tools)})"
125126
)
126127

127128
agent.tools = all_tools

0 commit comments

Comments
 (0)