fix comments

Author: nikhilc-microsoft

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter.py

@@ -6,7 +6,6 @@
 
 import json
 import logging
-import os
 import threading
 import time
 from collections.abc import Callable, Sequence
@@ -19,6 +18,7 @@
 from opentelemetry.trace import StatusCode
 
 from .utils import (
+    get_validated_domain_override,
     hex_span_id,
     hex_trace_id,
     kind_name,
@@ -62,7 +62,7 @@ def __init__(
         self._cluster_category = cluster_category
         self._use_s2s_endpoint = use_s2s_endpoint
         # Read domain override once at initialization
-        self._domain_override = self._get_validated_domain_override()
+        self._domain_override = get_validated_domain_override()
 
     # ------------- SpanExporter API -----------------
 
@@ -150,28 +150,6 @@ def force_flush(self, timeout_millis: int = 30000) -> bool:
 
     # ------------- Helper methods -------------------
 
-    @staticmethod
-    def _get_validated_domain_override() -> str | None:
-        """
-        Get and validate the domain override from environment variable.
-        
-        Returns:
-            The validated domain override, or None if not set or invalid.
-        """
-        domain_override = os.getenv("A365_OBSERVABILITY_DOMAIN_OVERRIDE", "").strip()
-        if not domain_override:
-            return None
-        
-        # Basic validation: ensure domain doesn't contain protocol or path separators
-        if "://" in domain_override or "/" in domain_override:
-            logger.warning(
-                f"Invalid domain override '{domain_override}': "
-                "domain should not contain protocol (://) or path separators (/)"
-            )
-            return None
-        
-        return domain_override
-
     # ------------- HTTP helper ----------------------
 
     @staticmethod

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/exporters/utils.py

@@ -142,6 +142,28 @@ def partition_by_identity(
     return groups
 
 
+def get_validated_domain_override() -> str | None:
+    """
+    Get and validate the domain override from environment variable.
+
+    Returns:
+        The validated domain override, or None if not set or invalid.
+    """
+    domain_override = os.getenv("A365_OBSERVABILITY_DOMAIN_OVERRIDE", "").strip()
+    if not domain_override:
+        return None
+
+    # Basic validation: ensure domain doesn't contain protocol or path separators
+    if "://" in domain_override or "/" in domain_override:
+        logger.warning(
+            f"Invalid domain override '{domain_override}': "
+            "domain should not contain protocol (://) or path separators (/)"
+        )
+        return None
+
+    return domain_override
+
+
 def is_agent365_exporter_enabled() -> bool:
     """Check if Agent 365 exporter is enabled."""
     # Check environment variable

libraries/microsoft-agents-a365-runtime/microsoft_agents_a365/runtime/environment_utils.py

@@ -24,10 +24,6 @@ def get_observability_authentication_scope() -> list[str]:
     The scope can be overridden via the A365_OBSERVABILITY_SCOPE_OVERRIDE environment variable
     to enable testing against pre-production environments.
 
-    Environment Variable:
-        A365_OBSERVABILITY_SCOPE_OVERRIDE: Full authentication scope URL including the /.default suffix
-                                          (e.g., "https://preprod.api.powerplatform.com/.default")
-
     Returns:
         list[str]: The authentication scope for the current environment.
     """