Skip to content

Commit 0517c1e

Browse files
Making OTLPSpanExporter be an additional flag rather than only used as a fallback
1 parent f72fbb1 commit 0517c1e

1 file changed

Lines changed: 11 additions & 10 deletions

File tree

  • libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core

libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/config.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -166,16 +166,10 @@ def _configure_internal(
166166
)
167167

168168
else:
169-
if os.environ.get("OTEL_EXPORTER_OTLP_ENDPOINT"):
170-
exporter = OTLPSpanExporter()
171-
self._logger.warning(
172-
"is_agent365_exporter_enabled() not enabled or token_resolver not set. Falling back to OTLP exporter."
173-
)
174-
else:
175-
exporter = ConsoleSpanExporter()
176-
self._logger.warning(
177-
"is_agent365_exporter_enabled() not enabled or token_resolver not set.Falling back to console exporter."
178-
)
169+
exporter = ConsoleSpanExporter()
170+
self._logger.warning(
171+
"is_agent365_exporter_enabled() not enabled or token_resolver not set. Falling back to console exporter."
172+
)
179173

180174
# Add span processors
181175

@@ -191,6 +185,13 @@ def _configure_internal(
191185
self._span_processors["batch"] = batch_processor
192186
self._span_processors["agent"] = agent_processor
193187

188+
if os.environ.get("OTEL_EXPORTER_OTLP_ENDPOINT"):
189+
# The OTLPSpanExporter is auto configured from the environment variables
190+
otlp_exporter = OTLPSpanExporter()
191+
tracer_provider.add_span_processor(
192+
_EnrichingBatchSpanProcessor(otlp_exporter, **batch_processor_kwargs)
193+
)
194+
194195
# Configure logging if logger_name is provided
195196
if logger_name:
196197
target_logger = logging.getLogger(logger_name)

0 commit comments

Comments
 (0)