From 576da628a341802e2ed66241aab10ab3bc3a970b Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 27 Apr 2026 20:42:30 +0000 Subject: [PATCH 1/2] Initial plan From 3481730aeb75bc46ba02adc825352b51d88136e4 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 27 Apr 2026 20:48:17 +0000 Subject: [PATCH 2/2] Remove TextCompletion and GenerateContent from InferenceOperationType and GEN_AI_OPERATION_NAMES Agent-Logs-Url: https://github.com/microsoft/Agent365-nodejs/sessions/3acaba0f-3822-468d-b962-cf8531c7be53 Co-authored-by: fpfp100 <126631706+fpfp100@users.noreply.github.com> --- packages/agents-a365-observability/docs/design.md | 4 +--- packages/agents-a365-observability/src/tracing/contracts.ts | 4 +--- .../agents-a365-observability/src/tracing/exporter/utils.ts | 2 -- tests/observability/core/scopes.test.ts | 2 +- 4 files changed, 3 insertions(+), 9 deletions(-) diff --git a/packages/agents-a365-observability/docs/design.md b/packages/agents-a365-observability/docs/design.md index 7d947eb3..d4cdf37a 100644 --- a/packages/agents-a365-observability/docs/design.md +++ b/packages/agents-a365-observability/docs/design.md @@ -451,9 +451,7 @@ enum InvocationRole { } enum InferenceOperationType { - CHAT = 'Chat', - TEXT_COMPLETION = 'TextCompletion', - GENERATE_CONTENT = 'GenerateContent' + CHAT = 'Chat' } ``` diff --git a/packages/agents-a365-observability/src/tracing/contracts.ts b/packages/agents-a365-observability/src/tracing/contracts.ts index 0ed18d8b..b154b1de 100644 --- a/packages/agents-a365-observability/src/tracing/contracts.ts +++ b/packages/agents-a365-observability/src/tracing/contracts.ts @@ -26,9 +26,7 @@ export enum InvocationRole { * Represents different operation for types for model inference */ export enum InferenceOperationType { - CHAT = 'Chat', - TEXT_COMPLETION = 'TextCompletion', - GENERATE_CONTENT = 'GenerateContent' + CHAT = 'Chat' } /** diff --git a/packages/agents-a365-observability/src/tracing/exporter/utils.ts b/packages/agents-a365-observability/src/tracing/exporter/utils.ts index 2c2f813e..9910ffdd 100644 --- a/packages/agents-a365-observability/src/tracing/exporter/utils.ts +++ b/packages/agents-a365-observability/src/tracing/exporter/utils.ts @@ -97,8 +97,6 @@ const GEN_AI_OPERATION_NAMES: ReadonlySet = new Set([ OpenTelemetryConstants.OUTPUT_MESSAGES_OPERATION_NAME, // 'output_messages' OpenTelemetryConstants.CHAT_OPERATION_NAME, // 'chat' 'Chat', // InferenceOperationType.CHAT - 'TextCompletion', // InferenceOperationType.TEXT_COMPLETION - 'GenerateContent', // InferenceOperationType.GENERATE_CONTENT ]); /** diff --git a/tests/observability/core/scopes.test.ts b/tests/observability/core/scopes.test.ts index 1fec6ff9..f96f46b3 100644 --- a/tests/observability/core/scopes.test.ts +++ b/tests/observability/core/scopes.test.ts @@ -558,7 +558,7 @@ describe('Scopes', () => { it('should create scope with minimal details', () => { const spy = jest.spyOn(OpenTelemetryScope.prototype as any, 'setTagMaybe'); const inferenceDetails: InferenceDetails = { - operationName: InferenceOperationType.TEXT_COMPLETION, + operationName: InferenceOperationType.CHAT, model: 'gpt-3.5-turbo' };