MMCore: waitForConfig() swallows errors

[marktsuchida]

mmCoreAndDevices/MMCore/MMCore.cpp

Lines 1547 to 1560 in 9a35738

	void CMMCore::waitForConfig(const char* group, const char* configName) MMCORE_LEGACY_THROW(CMMError)
	{
	CheckConfigGroupName(group);
	CheckConfigPresetName(configName);
	Configuration cfg = getConfigData(group, configName);
	try {
	for(size_t i=0; i<cfg.size(); i++)
	waitForDevice(cfg.getSetting(i).getDeviceLabel().c_str());
	} catch (CMMError& err) {
	// trap MM exceptions and keep quiet - this is not a good time to blow up
	logError("waitForConfig", err.getMsg().c_str());
	}
	}

This seems to have been the case since pre-2007.

It's quite bad: it could be causing/hiding subtle misbehavior during MDA, for example, because any timeouts are ignored.

I'd say we should just remove the try-catch.

[marktsuchida]

Given how old this code is, the "not a good time to blow up" probably refers to MDA prior to the Clojure acqEngine? So I'd say we remove it and see if we run into any problems. It has a much greater chance of surfacing latent issues than breaking anything that wasn't already broken.

BTW the Clojure acqEngine does not call waitForConfig(), nor does the pymmcore-plus MDA currently. AcqEngJ does in one place, but with a comment saying it may not be needed. So we've been getting lucky.