fix: Animation fixes to reads#18
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the animation tooling and assets used to generate README-friendly visuals for SparseIO, with small cleanups to the general-read manim scene and improved setup/runtime checks for rendering.
Changes:
- Update animation setup docs to install dependencies from
requirements.txtinstead of a hardcodedmanimpin. - Simplify the
general-readscene by removing unused imports/constants/helpers. - Add an
ffmpegpresence check and ensure requirements are installed on each render run; add alt text for the README animation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/animations/README.md | Switch setup instructions to pip install -r requirements.txt. |
| scripts/animations/general-read/scene.py | Remove unused manim import and prefetch/stream helper code. |
| scripts/animations/common.sh | Add ffmpeg check and always install requirements when rendering. |
| README.md | Add descriptive alt text to the embedded animation image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.