Skip to content

fix: Animation fixes to reads#18

Merged
mhambre merged 1 commit into
masterfrom
docs/readme-manim
May 10, 2026
Merged

fix: Animation fixes to reads#18
mhambre merged 1 commit into
masterfrom
docs/readme-manim

Conversation

@mhambre
Copy link
Copy Markdown
Owner

@mhambre mhambre commented May 10, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 10, 2026 18:48
@mhambre mhambre merged commit a86da61 into master May 10, 2026
6 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the animation tooling and assets used to generate README-friendly visuals for SparseIO, with small cleanups to the general-read manim scene and improved setup/runtime checks for rendering.

Changes:

  • Update animation setup docs to install dependencies from requirements.txt instead of a hardcoded manim pin.
  • Simplify the general-read scene by removing unused imports/constants/helpers.
  • Add an ffmpeg presence check and ensure requirements are installed on each render run; add alt text for the README animation.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
scripts/animations/README.md Switch setup instructions to pip install -r requirements.txt.
scripts/animations/general-read/scene.py Remove unused manim import and prefetch/stream helper code.
scripts/animations/common.sh Add ffmpeg check and always install requirements when rendering.
README.md Add descriptive alt text to the embedded animation image.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants