Objectives with input dist latencies #3575
Open
+417
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
@isururanawaka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87389540. |
isururanawaka
added a commit
to isururanawaka/torchrec
that referenced
this pull request
Nov 24, 2025
Summary: Pull Request resolved: meta-pytorch#3575 This diff introduce two objectives for LP Planner considering input_dist in Critical Path. - BALANCE_ACROSS_ALL_SYNC_POINTS_WITH_INPUT_DIST max(fwd compute) + max(bwd compute) + sum_{module, shardtype} max(fwd comms for module) + max(bwd comms for module, shardtype) + sum_{module, shardtype} max(bwd comms for module, shardtype} + sum_{module} max(input_dist_comms for module) - BALANCE_ACROSS_ALL_SYNC_POINTS_WITH_COMBINED_FWD_COMMS_INPUT_DIST max(fwd compute) + max(bwd compute) + sum_{module, shardtype} max(fwd comms + input_dist_comms for module) + max(bwd comms for module, shardtype) + sum_{module, shardtype} max(bwd comms for module, shardtype} Differential Revision: D87389540
isururanawaka
force-pushed
the
export-D87389540
branch
from
556bdb2 to
b3c23a3
Compare
isururanawaka
force-pushed
the
export-D87389540
branch
from
b3c23a3 to
9a6f3d0
Compare
Summary: This introduces input distribution latency estimations. Input distribution is two step communication happens inside SDD pipelines. - split exchange: Exchanges buffer sizes to receive input IDS from KJTs. The cost does not depend on Input and it meta data exchanging phase. Hence, this diff excludes that from the computations. - ID exchange: this exchanges actual IDs to lookup. we estimated the cost by analyzing all-to-all comms Differential Revision: D87389540
isururanawaka
force-pushed
the
export-D87389540
branch
from
9a6f3d0 to
1aa05c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff introduce two objectives for LP Planner considering input_dist in Critical Path.
- BALANCE_ACROSS_ALL_SYNC_POINTS_WITH_INPUT_DIST
max(fwd compute) + max(bwd compute) + sum_{module, shardtype} max(fwd comms for module) + max(bwd comms for module, shardtype) + sum_{module, shardtype} max(bwd comms for module, shardtype}
+ sum_{module} max(input_dist_comms for module)
Differential Revision: D87389540