Add riscv64 build, make target list more explicit#171
Add riscv64 build, make target list more explicit#171threexc wants to merge 2 commits intometa-pytorch:mainfrom
Conversation
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
|
Hi @threexc! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
need CLA |
maturin supports riscv64 cross-compile, so add that to the build matrix. However, first make things more explicit about which rustc targets to use for each architecture.
From previous explorations of riscv64 builds, I've found that just specifying riscv64 as a target doesn't work, because the rustc target is actually
riscv64gc-unknown-linux-gnu. We could simply addriscv64gcto the matrix, but that won't fit the patterns used for final packages, so take the time to add aplatformlist with separatetargetandarchfields.Note that this is being done on behalf of the RISE Project to improve Python ecosystem support on riscv64 platforms.
Please also note that we have a previous PR that is still open: #107