Skip to content

Commit fd4f25c

Browse files
shayne-fletchermeta-codesync[bot]
authored andcommitted
fix lints and unused dependencies (#2110)
Summary: Pull Request resolved: #2110 more lints and unused imports/dependencies Reviewed By: dulinriley Differential Revision: D88882022 fbshipit-source-id: 05b7ec707cca790fd9cafdc3acef298f08947eea
1 parent 4eabf50 commit fd4f25c

File tree

7 files changed

+7
-11
lines changed

7 files changed

+7
-11
lines changed

hyperactor_config/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ anyhow = "1.0.98"
1717
chrono = { version = "0.4.41", features = ["clock", "serde", "std"], default-features = false }
1818
erased-serde = "0.4.9"
1919
humantime = "2.1"
20-
hyperactor_macros = { version = "0.0.0", path = "../hyperactor_macros" }
2120
hyperactor_named = { version = "0.0.0", path = "../hyperactor_named" }
2221
inventory = "0.3.21"
2322
paste = "1.0.14"

monarch_messages/Cargo.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,3 @@ thiserror = "2.0.12"
2121
torch-sys-cuda = { version = "0.0.0", path = "../torch-sys-cuda" }
2222
torch-sys2 = { version = "0.0.0", path = "../torch-sys2" }
2323
tracing = { version = "0.1.41", features = ["attributes", "valuable"] }
24-
25-
[dev-dependencies]
26-
paste = "1.0.14"

monarch_perfetto_trace/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,3 @@ edition = "2024"
1414
serde = { version = "1.0.219", features = ["derive", "rc"] }
1515
serde_json = { version = "1.0.140", features = ["alloc", "float_roundtrip", "raw_value", "unbounded_depth"] }
1616
tracing-perfetto-sdk-schema = "0.12.0"
17-
valuable = { version = "0.1", features = ["derive"] }

monarch_tensor_worker/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ license = "BSD-3-Clause"
1010
[dependencies]
1111
anyhow = "1.0.98"
1212
async-trait = "0.1.86"
13-
derivative = "2.2"
1413
derive_more = { version = "1.0.0", features = ["full"] }
1514
futures = { version = "0.3.31", features = ["async-await", "compat"] }
1615
hyperactor = { version = "0.0.0", path = "../hyperactor" }

monarch_tensor_worker/src/borrow.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,6 @@ mod tests {
184184
use monarch_messages::worker::WorkerParams;
185185
use timed_test::async_timed_test;
186186
use torch_sys2::Device;
187-
use torch_sys2::DeviceType;
188187

189188
use super::*;
190189
use crate::CallFunctionParams;

monarch_tensor_worker/src/lib.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1094,17 +1094,13 @@ mod tests {
10941094
use monarch_messages::controller::WorkerError;
10951095
use monarch_messages::worker::WorkerMessageClient;
10961096
use monarch_types::PickledPyObject;
1097-
use pyo3::IntoPyObjectExt;
10981097
use pyo3::Python;
10991098
use pyo3::prelude::*;
11001099
use pyo3::types::PyList;
11011100
use pyo3::types::PyString;
11021101
use rand::Rng;
11031102
use rand::distributions::Alphanumeric;
11041103
use timed_test::async_timed_test;
1105-
use torch_sys2::Device;
1106-
use torch_sys2::DeviceIndex;
1107-
use torch_sys2::MemoryFormat;
11081104

11091105
use super::*;
11101106
use crate::test_util::test_setup;

monarch_tensor_worker/src/stream.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1949,6 +1949,7 @@ mod tests {
19491949
use crate::comm::CommParams;
19501950
use crate::test_util;
19511951

1952+
#[allow(dead_code)]
19521953
fn fake_seq_error(err: anyhow::Error) -> Arc<SeqError> {
19531954
Arc::new(SeqError {
19541955
seq: 0.into(),
@@ -1964,7 +1965,9 @@ mod tests {
19641965
// port -- otherwise an actor failure will cause a crash.
19651966
#[allow(dead_code)]
19661967
supervision_rx: PortReceiver<ActorSupervisionEvent>,
1968+
#[allow(dead_code)]
19671969
controller_rx: PortReceiver<ControllerMessage>,
1970+
#[allow(dead_code)]
19681971
controller_actor: ActorRef<ControllerActor>,
19691972
next_ref: Ref,
19701973
}
@@ -2040,6 +2043,7 @@ mod tests {
20402043
result
20412044
}
20422045

2046+
#[allow(dead_code)]
20432047
async fn validate_dependent_error(&mut self, reference: Ref, error: Arc<SeqError>) {
20442048
let result_error = self
20452049
.stream_actor
@@ -2084,6 +2088,7 @@ mod tests {
20842088
}
20852089
}
20862090

2091+
#[allow(dead_code)]
20872092
async fn fetch_result(
20882093
cx: &impl context::Actor,
20892094
stream_actor: ActorHandle<StreamActor>,
@@ -2112,6 +2117,7 @@ mod tests {
21122117
.unwrap()
21132118
}
21142119

2120+
#[allow(dead_code)]
21152121
async fn check_fetch_result_error(
21162122
cx: &impl context::Actor,
21172123
stream_actor: ActorHandle<StreamActor>,
@@ -2140,6 +2146,7 @@ mod tests {
21402146
};
21412147
}
21422148

2149+
#[allow(dead_code)]
21432150
async fn check_fetch_result_value(
21442151
cx: &impl context::Actor,
21452152
stream_actor: ActorHandle<StreamActor>,

0 commit comments

Comments
 (0)