Meaningful process names (#2043)

Summary:
Pull Request resolved: #2043

Instead of just raw OS pids we want to see what kind of process it is in relation to monarch (client, host, proc)

Reviewed By: moonli

Differential Revision: D88227075

fbshipit-source-id: 74716ca184a1edc302f3523e76e9aad3d2d36fc8

Author: thomasywang

hyperactor_mesh/src/alloc/process.rs

@@ -492,6 +492,18 @@ impl ProcessAlloc {
         );
         cmd.env(bootstrap::BOOTSTRAP_INDEX_ENV, index.to_string());
 
+        cmd.env(
+            "HYPERACTOR_PROCESS_NAME",
+            format!(
+                "host rank:{} @{}",
+                index,
+                hostname::get()
+                    .unwrap_or_else(|_| "unknown_host".into())
+                    .into_string()
+                    .unwrap_or("unknown_host".to_string())
+            ),
+        );
+
         tracing::debug!("spawning process {:?}", cmd);
         match cmd.spawn() {
             Err(err) => {

hyperactor_mesh/src/bootstrap.rs

@@ -1878,6 +1878,20 @@ impl ProcManager for BootstrapProcManager {
             mode.to_env_safe_string()
                 .map_err(|e| HostError::ProcessConfigurationFailure(proc_id.clone(), e.into()))?,
         );
+        cmd.env(
+            "HYPERACTOR_PROCESS_NAME",
+            format!(
+                "proc {} @ {}",
+                match &proc_id {
+                    ProcId::Direct(_, name) => name.clone(),
+                    ProcId::Ranked(world_id, rank) => format!("{world_id}[{rank}]"),
+                },
+                hostname::get()
+                    .unwrap_or_else(|_| "unknown_host".into())
+                    .into_string()
+                    .unwrap_or("unknown_host".to_string())
+            ),
+        );
 
         if need_stdio {
             cmd.stdout(Stdio::piped()).stderr(Stdio::piped());

hyperactor_telemetry/src/lib.rs

@@ -631,6 +631,9 @@ pub fn initialize_logging_with_log_prefix(
             tracing::debug!("logging already initialized for this process: {}", err);
         }
         let exec_id = env::execution_id();
+        let process_name =
+            std::env::var("HYPERACTOR_PROCESS_NAME").unwrap_or_else(|_| "client".to_string());
+
         // setting target to "execution" will prevent the monarch_tracing scuba client from logging this
         tracing::info!(
             target: "execution",
@@ -645,7 +648,8 @@ pub fn initialize_logging_with_log_prefix(
             package_release = build_info::BuildInfo::get_package_release(),
             upstream_revision = build_info::BuildInfo::get_upstream_revision(),
             revision = build_info::BuildInfo::get_revision(),
-            "logging_initialized"
+            process_name = process_name,
+            "logging_initialized",
         );
         // here we have the monarch_executions scuba client log
         meta::log_execution_event(
@@ -660,6 +664,7 @@ pub fn initialize_logging_with_log_prefix(
             build_info::BuildInfo::get_package_release(),
             build_info::BuildInfo::get_upstream_revision(),
             build_info::BuildInfo::get_revision(),
+            &process_name,
         );
 
         if hyperactor_config::global::get(ENABLE_OTEL_METRICS) {

monarch_perfetto_trace/src/lib.rs

@@ -531,6 +531,26 @@ impl<T: Sink> Ctx<T> {
         id
     }
 
+    pub fn new_process_with_name(&mut self, pid: i32, process_name: String) -> u64 {
+        let id = self.next_uuid();
+        let pd = ProcessDescriptor {
+            pid: Some(pid),
+            process_name: Some(process_name),
+            ..Default::default()
+        };
+        let td = TrackDescriptor {
+            uuid: Some(id),
+            process: Some(pd),
+            ..Default::default()
+        };
+        let tp = TracePacket {
+            data: Some(Data::TrackDescriptor(td)),
+            ..Default::default()
+        };
+        self.sink.consume(tp);
+        id
+    }
+
     pub fn new_thread(&mut self, pid: i32, tid: i32, name: String) -> u64 {
         let id = self.next_uuid();
         let thd = ThreadDescriptor {