Replace Duration::from_secs(3600) to Duration::from_hours(1) (#2059)

Summary:
Pull Request resolved: #2059

Rust 1.91 introduced `Duration::from_hours`.

This diff replaces some instances of `Duration::from_secs` with the corresponding `Duration::from_hours`.

Reviewed By: dtolnay

Differential Revision: D88441312

fbshipit-source-id: b4208c4b38a2f5b2b8471ab04dbc9d30b71b631d

Author: edward-shen

monarch_conda/src/diff.rs

@@ -439,7 +439,7 @@ mod tests {
         // Test various mtime scenarios
         let base_timestamp = 1640995200;
         let test_base_time = UNIX_EPOCH + Duration::from_secs(base_timestamp);
-        let old_time = test_base_time - Duration::from_secs(3600); // 1 hour before base
+        let old_time = test_base_time - Duration::from_hours(1); // 1 hour before base
         let new_time = test_base_time + Duration::from_secs(7200); // 2 hours after base (beyond slop)
 
         // Files older than base should be considered equal
@@ -492,13 +492,13 @@ mod tests {
 
         let base_timestamp = 1640995200;
         let test_base_time = UNIX_EPOCH + Duration::from_secs(base_timestamp);
-        let update_start = test_base_time + Duration::from_secs(3600); // Update window start
+        let update_start = test_base_time + Duration::from_hours(1); // Update window start
         let update_end = test_base_time + Duration::from_mins(61); // Update window end
         let in_window_time = update_start + Duration::from_secs(30); // Inside update window
-        let after_window_time = update_end + Duration::from_secs(3600); // After update window
+        let after_window_time = update_end + Duration::from_hours(1); // After update window
 
         // Files with mtimes in the update window should be ignored (treated as equal to old files)
-        let old_time = base_time - Duration::from_secs(3600);
+        let old_time = base_time - Duration::from_hours(1);
         assert_eq!(
             comparator(&in_window_time, &old_time),
             std::cmp::Ordering::Equal
@@ -738,7 +738,7 @@ mod tests {
 
         let base_timestamp = base_time.duration_since(UNIX_EPOCH)?.as_secs();
         let update_window_time = UNIX_EPOCH + Duration::from_secs(base_timestamp + 3630); // In the middle of update window
-        let old_time = base_time - Duration::from_secs(3600);
+        let old_time = base_time - Duration::from_hours(1);
         let new_time = base_time + Duration::from_secs(7200);
 
         // When update_window_time is the first arg (env1 context with update window),
@@ -814,7 +814,7 @@ mod tests {
         // But the mtime comparator should still work since the core history is the same
         let comparator = CondaFingerprint::mtime_comparator(&fingerprint1, &fingerprint2)?;
 
-        let old_time = base_time - Duration::from_secs(3600);
+        let old_time = base_time - Duration::from_hours(1);
         let new_time = base_time + Duration::from_secs(7200);
 
         // Basic mtime comparison should still work
@@ -928,7 +928,7 @@ mod tests {
         // Create mtime comparator and verify it works with large environments
         let comparator = CondaFingerprint::mtime_comparator(&fingerprint1, &fingerprint2)?;
 
-        let old_time = base_time - Duration::from_secs(3600);
+        let old_time = base_time - Duration::from_hours(1);
         let new_time = base_time + Duration::from_secs(7200);
 
         assert_eq!(comparator(&old_time, &old_time), std::cmp::Ordering::Equal);
@@ -984,7 +984,7 @@ mod tests {
         // Test exactly at the boundary points
         let one_sec_before_window = update_window_start - Duration::from_secs(1);
         let one_sec_after_window = update_window_end + Duration::from_secs(1);
-        let old_time = base_time - Duration::from_secs(3600);
+        let old_time = base_time - Duration::from_hours(1);
 
         // Just before update window should be newer than old files
         assert_eq!(

monarch_conda/src/sync.rs

@@ -875,7 +875,7 @@ mod tests {
 
         // Modify a file in the source environment
         let modified_content = "modified test data\n";
-        let newer_time = base_time + Duration::from_secs(3600); // 1 hour later
+        let newer_time = base_time + Duration::from_hours(1); // 1 hour later
         modify_file(
             src_env.path(),
             "bin/test-file",
@@ -919,7 +919,7 @@ mod tests {
 
         // Add a new file to the source environment
         let new_file_content = "new file content\n";
-        let newer_time = base_time + Duration::from_secs(3600); // 1 hour later
+        let newer_time = base_time + Duration::from_hours(1); // 1 hour later
         add_file(
             src_env.path(),
             "lib/new-file.txt",
@@ -966,7 +966,7 @@ mod tests {
         let dst_env = setup_conda_env(TempDir::new()?, base_time, None).await?;
 
         // Create a new directory with a file in the source environment
-        let newer_time = base_time + Duration::from_secs(3600); // 1 hour later
+        let newer_time = base_time + Duration::from_hours(1); // 1 hour later
         fs::create_dir(src_env.path().join("new_dir")).await?;
         add_file(
             src_env.path(),
@@ -1021,7 +1021,7 @@ mod tests {
         fs::symlink("bin/test-file", src_env.path().join("link-to-test")).await?;
 
         // Set a newer time for the symlink to ensure it's synced
-        let newer_time = base_time + Duration::from_secs(3600); // 1 hour later
+        let newer_time = base_time + Duration::from_hours(1); // 1 hour later
         set_mtime(&src_env.path().join("link-to-test"), newer_time).await?;
 
         // Sync changes from source to destination
@@ -1061,7 +1061,7 @@ mod tests {
         let dst_env = setup_conda_env(TempDir::new()?, base_time, None).await?;
 
         // Add an extra file to the destination that doesn't exist in source
-        let newer_time = base_time + Duration::from_secs(3600); // 1 hour later
+        let newer_time = base_time + Duration::from_hours(1); // 1 hour later
         add_file(
             dst_env.path(),
             "extra-file.txt",
@@ -1099,7 +1099,7 @@ mod tests {
         let dst_env = setup_conda_env(TempDir::new()?, base_time, None).await?;
 
         // Add a .pyc file to the source.
-        let newer_time = base_time + Duration::from_secs(3600); // 1 hour later
+        let newer_time = base_time + Duration::from_hours(1); // 1 hour later
         add_file(
             src_env.path(),
             "lib/test.pyc",
@@ -1156,7 +1156,7 @@ mod tests {
         let dst_env = setup_conda_env(TempDir::new()?, base_time, None).await?;
 
         // Add an executable file to the source
-        let newer_time = base_time + Duration::from_secs(3600); // 1 hour later
+        let newer_time = base_time + Duration::from_hours(1); // 1 hour later
         add_file(
             src_env.path(),
             "bin/executable",
@@ -1208,7 +1208,7 @@ mod tests {
         let dst_env = setup_conda_env(TempDir::new()?, base_time, Some(dst_prefix)).await?;
 
         // Add a text file with prefix references to the source
-        let newer_time = base_time + Duration::from_secs(3600);
+        let newer_time = base_time + Duration::from_hours(1);
         let text_content = format!(
             "#!/bin/bash\nexport PATH={}/bin:$PATH\necho 'Using prefix: {}'\n",
             src_prefix, src_prefix
@@ -1264,7 +1264,7 @@ mod tests {
         let dst_env = setup_conda_env(TempDir::new()?, base_time, Some(dst_prefix)).await?;
 
         // Create a binary file with embedded prefix and null bytes
-        let newer_time = base_time + Duration::from_secs(3600);
+        let newer_time = base_time + Duration::from_hours(1);
         let mut binary_content = Vec::new();
         binary_content.extend_from_slice(b"\x7fELF"); // ELF magic number
         binary_content.extend_from_slice(&[0u8; 10]); // null bytes to make it binary
@@ -1315,7 +1315,7 @@ mod tests {
         let dst_env = setup_conda_env(TempDir::new()?, base_time, Some(dst_prefix)).await?;
 
         // Create a symlink that points to a path with the source prefix
-        let newer_time = base_time + Duration::from_secs(3600);
+        let newer_time = base_time + Duration::from_hours(1);
         let symlink_target = format!("{}/lib/target-file", src_prefix);
         fs::symlink(&symlink_target, src_env.path().join("bin/link-to-target")).await?;
         set_mtime(&src_env.path().join("bin/link-to-target"), newer_time).await?;
@@ -1350,7 +1350,7 @@ mod tests {
         let dst_env = setup_conda_env(TempDir::new()?, base_time, Some(dst_prefix)).await?;
 
         // Create a symlink that points to a relative path (should not be modified)
-        let newer_time = base_time + Duration::from_secs(3600);
+        let newer_time = base_time + Duration::from_hours(1);
         let symlink_target = "relative/path/target";
         fs::symlink(&symlink_target, src_env.path().join("bin/relative-link")).await?;
         set_mtime(&src_env.path().join("bin/relative-link"), newer_time).await?;
@@ -1385,7 +1385,7 @@ mod tests {
         let dst_env = setup_conda_env(TempDir::new()?, base_time, Some(dst_prefix)).await?;
 
         // Create a binary file with embedded prefix and null bytes
-        let newer_time = base_time + Duration::from_secs(3600);
+        let newer_time = base_time + Duration::from_hours(1);
         let mut binary_content = Vec::new();
         binary_content.extend_from_slice(b"\x7fELF"); // ELF magic number
         binary_content.extend_from_slice(&[0u8; 10]); // null bytes to make it binary