From 46012f89e7b08cf76abbacf83b7198029c764164 Mon Sep 17 00:00:00 2001
From: Marnick Hartgers <marnick.hartgers@gmail.com>
Date: Tue, 3 Feb 2026 23:06:00 +0100
Subject: [PATCH 1/2] gps for sensecap p1 solar

---
 variants/sensecap_solar/platformio.ini | 2 +-
 variants/sensecap_solar/target.cpp     | 8 +++++++-
 variants/sensecap_solar/variant.cpp    | 5 -----
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/variants/sensecap_solar/platformio.ini b/variants/sensecap_solar/platformio.ini
index d4fb7b442..9cf034866 100644
--- a/variants/sensecap_solar/platformio.ini
+++ b/variants/sensecap_solar/platformio.ini
@@ -8,7 +8,6 @@ build_flags = ${nrf52_base.build_flags}
   -I lib/nrf52/s140_nrf52_7.3.0_API/include/nrf52
   -I variants/sensecap_solar
   -I src/helpers/nrf52
-  -UENV_INCLUDE_GPS
   -D NRF52_PLATFORM=1
   -D RADIO_CLASS=CustomSX1262
   -D WRAPPER_CLASS=CustomSX1262Wrapper
@@ -24,6 +23,7 @@ build_flags = ${nrf52_base.build_flags}
   -D SX126X_DIO3_TCXO_VOLTAGE=1.8
   -D SX126X_CURRENT_LIMIT=140
   -D SX126X_RX_BOOSTED_GAIN=1
+  -D ENV_INCLUDE_GPS=1
 build_src_filter = ${nrf52_base.build_src_filter}
   +<helpers/*.cpp>
   +<helpers/sensors>
diff --git a/variants/sensecap_solar/target.cpp b/variants/sensecap_solar/target.cpp
index 6bd7d31a7..b88774b64 100644
--- a/variants/sensecap_solar/target.cpp
+++ b/variants/sensecap_solar/target.cpp
@@ -1,6 +1,7 @@
 #include <Arduino.h>
 #include "target.h"
 #include <helpers/ArduinoHelpers.h>
+#include <helpers/sensors/MicroNMEALocationProvider.h>
 
 SenseCapSolarBoard board;
 
@@ -10,7 +11,12 @@ WRAPPER_CLASS radio_driver(radio, board);
 
 VolatileRTCClock fallback_clock;
 AutoDiscoverRTCClock rtc_clock(fallback_clock);
-EnvironmentSensorManager sensors;
+#ifdef ENV_INCLUDE_GPS
+MicroNMEALocationProvider nmea = MicroNMEALocationProvider(Serial1, &rtc_clock);
+EnvironmentSensorManager sensors = EnvironmentSensorManager(nmea);
+#else
+EnvironmentSensorManager sensors = EnvironmentSensorManager();
+#endif
 
 bool radio_init() {
     rtc_clock.begin(Wire);
diff --git a/variants/sensecap_solar/variant.cpp b/variants/sensecap_solar/variant.cpp
index 05774c102..d7fdce49e 100644
--- a/variants/sensecap_solar/variant.cpp
+++ b/variants/sensecap_solar/variant.cpp
@@ -63,9 +63,4 @@ void initVariant() {
 
     pinMode(LED_BLUE, OUTPUT);
     digitalWrite(LED_BLUE, LOW);
-
-    /* disable gps until we actually support it.
-    pinMode(GPS_EN, OUTPUT);
-    digitalWrite(GPS_EN, HIGH);
-    */
 }

From 0a66dee990c5997da46175524134e6d864069d33 Mon Sep 17 00:00:00 2001
From: Marnick Hartgers <marnick.hartgers@gmail.com>
Date: Fri, 6 Feb 2026 00:12:22 +0100
Subject: [PATCH 2/2] fixed build without ENV_INCLUDE_GPS

---
 variants/sensecap_solar/target.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/variants/sensecap_solar/target.cpp b/variants/sensecap_solar/target.cpp
index b88774b64..05ddbdeb2 100644
--- a/variants/sensecap_solar/target.cpp
+++ b/variants/sensecap_solar/target.cpp
@@ -1,8 +1,9 @@
 #include <Arduino.h>
 #include "target.h"
 #include <helpers/ArduinoHelpers.h>
+#ifdef ENV_INCLUDE_GPS
 #include <helpers/sensors/MicroNMEALocationProvider.h>
-
+#endif
 SenseCapSolarBoard board;
 
 RADIO_CLASS radio = new Module(P_LORA_NSS, P_LORA_DIO_1, P_LORA_RESET, P_LORA_BUSY, SPI);