fix: update test file. update output.tf to correct outputs for Building Block integration

Author: younGihan

modules/azure/vmss/buildingblock/main.tf

@@ -244,7 +244,7 @@ resource "azurerm_windows_virtual_machine_scale_set" "vmss" {
   single_placement_group      = var.single_placement_group
   zones                       = var.zones
   zone_balance                = length(var.zones) > 0 ? true : false
-  platform_fault_domain_count = var.single_placement_group ? 5 : 1
+  platform_fault_domain_count = var.enable_spot_instances ? 1 : (var.single_placement_group ? 5 : 1)
   priority                    = var.enable_spot_instances ? "Spot" : "Regular"
   eviction_policy             = var.enable_spot_instances ? var.spot_eviction_policy : null
   max_bid_price               = var.enable_spot_instances ? var.spot_max_bid_price : null

modules/azure/vmss/buildingblock/outputs.tf

@@ -44,7 +44,7 @@ output "load_balancer_frontend_ip" {
 }
 
 output "public_ip_address" {
-  value       = var.enable_load_balancer && var.enable_public_ip ? azurerm_public_ip.lb_public_ip[0].ip_address : null
+  value       = var.enable_load_balancer && var.enable_public_ip ? azurerm_public_ip.lb_public_ip[0].ip_address : "no public IP assigned"
   description = "The public IP address of the load balancer (if enabled)"
 }
 

modules/azure/vmss/buildingblock/vmss.tftest.hcl

@@ -1,6 +1,6 @@
 variables {
-  vmss_name                = "test-vmss"
-  resource_group_name      = "test-vmss-rg"
+  vmss_name                = "hcl-test-vmss"
+  resource_group_name      = "hcl-test-vmss-rg"
   location                 = "germanywestcentral"
   vnet_name                = "spoke-vnet"
   vnet_resource_group_name = "rg-vmss-test"
@@ -34,18 +34,19 @@ run "valid_linux_vmss" {
 
 run "windows_vmss" {
   variables {
-    vmss_name       = "windows-vmss"
+    vmss_name       = "win-vmss"
     os_type         = "Windows"
     sku             = "Standard_B2s"
     instances       = 3
     admin_password  = "P@ssw0rd1234!"
     image_publisher = "MicrosoftWindowsServer"
     image_offer     = "WindowsServer"
     image_sku       = "2022-Datacenter"
+    os_disk_size_gb = 128
   }
 
   assert {
-    condition     = azurerm_windows_virtual_machine_scale_set.vmss[0].name == "windows-vmss"
+    condition     = azurerm_windows_virtual_machine_scale_set.vmss[0].name == "win-vmss"
     error_message = "Windows VMSS name should match input"
   }
 
@@ -267,6 +268,7 @@ run "vmss_with_rdp_access" {
     image_publisher   = "MicrosoftWindowsServer"
     image_offer       = "WindowsServer"
     image_sku         = "2022-Datacenter"
+    os_disk_size_gb   = 127
   }
 
   assert {