chore: remove useless todo and better naming

Author: r0b1n

packages/pluggableWidgets/datagrid-web/src/components/Grid.tsx

@@ -7,12 +7,13 @@ export const Grid = observer(function Grid(props: PropsWithChildren): ReactEleme
     const config = useDatagridConfig();
     const gridSizeStore = useGridSizeStore();
 
-    // TODO: add check custom css styling is applie
     const style = useGridStyle().get();
     return (
         <div
             aria-multiselectable={config.multiselectable}
-            className={classNames("widget-datagrid-grid table", { "infinite-loading": gridSizeStore.isInfinite })}
+            className={classNames("widget-datagrid-grid table", {
+                "infinite-loading": gridSizeStore.hasVirtualScrolling
+            })}
             role="grid"
             style={style}
             ref={gridSizeStore.gridContainerRef}

packages/pluggableWidgets/datagrid-web/src/model/hooks/useInfiniteControl.tsx

@@ -43,21 +43,21 @@ export function useInfiniteControl(): [trackBodyScrolling: ((e: any) => void) |
     );
 
     const gridBody = gridSizeStore.gridBodyRef.current;
-    const { isInfinite, gridBodyHeight, hasMoreItems } = gridSizeStore;
+    const { hasVirtualScrolling, gridBodyHeight, hasMoreItems } = gridSizeStore;
 
     const lockGridBodyHeight = useCallback((): void => {
-        if (isVisible && isInfinite && hasMoreItems && gridBodyHeight === undefined && gridBody) {
+        if (isVisible && hasVirtualScrolling && hasMoreItems && gridBodyHeight === undefined && gridBody) {
             gridSizeStore.setGridBodyHeight(gridBody.clientHeight - offsetBottom);
         }
-    }, [isVisible, isInfinite, hasMoreItems, gridBodyHeight, gridBody, gridSizeStore]);
+    }, [isVisible, hasVirtualScrolling, hasMoreItems, gridBodyHeight, gridBody, gridSizeStore]);
 
     useLayoutEffect(() => {
         setTimeout(() => lockGridBodyHeight(), 100);
     }, [lockGridBodyHeight]);
 
     useLayoutEffect(() => {
         const observeTarget = gridSizeStore.gridContainerRef.current;
-        if (!gridSizeStore.isInfinite || !observeTarget) return;
+        if (!gridSizeStore.hasVirtualScrolling || !observeTarget) return;
 
         const resizeObserver = new ResizeObserver(entries => {
             for (const entry of entries) {
@@ -72,5 +72,5 @@ export function useInfiniteControl(): [trackBodyScrolling: ((e: any) => void) |
         };
     }, [gridSizeStore]);
 
-    return [gridSizeStore.isInfinite ? trackBodyScrolling : undefined];
+    return [gridSizeStore.hasVirtualScrolling ? trackBodyScrolling : undefined];
 }

packages/pluggableWidgets/datagrid-web/src/model/models/grid.model.ts

@@ -11,8 +11,6 @@ export function gridStyleAtom(
     config: DatagridConfig,
     gridSizeStore: GridSizeStore
 ): ComputedAtom<CSSProperties> {
-    // todo: include custom variables from gridSizeStore;
-
     return computed(
         () =>
             ({

packages/pluggableWidgets/datagrid-web/src/model/stores/GridSize.store.ts

@@ -42,7 +42,7 @@ export class GridSizeStore {
         return this.paging.hasMoreItems;
     }
 
-    get isInfinite(): boolean {
+    get hasVirtualScrolling(): boolean {
         return this.paging.pagination === "virtualScrolling";
     }