Add http(s) and/or socks proxy support

[samthelion17]

It'll be nice for those of us behind corporate proxies inside organizations...

[qustavo]

Good point, what kind of proxy are you using?

[samthelion17]

Right now I'm using an http proxy for web browsing (only allows connections to ports 80/443). My organization uses squid to offer this service.

[qustavo]

What's the best UX for you? setting an env var to set the proxy or via flag?

-- Gus

On October 12, 2021, GitHub ***@***.***> wrote: Right now I'm using an http proxy for web browsing (only allows connections to ports 80/443). My organization uses squid to offer this service.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2 (comment)- 940973072>, or unsubscribe <https://github.com/notifications/unsubscribe- auth/AAJ2Q6KYAIFMGDXYULJY6G3UGQT2BANCNFSM5FVRUZYA>.

[samthelion17]

For me, a flag would be better, but i bet that the best UX for the rest of the world would be the env var. I'll settle for any, but considering that mempool-cli doesn't take any other flags so far (my guess) the reasonable choice would be to keep it that way and implement this via env var, right? Oct 12, 2021 9:35:59 AM Gustavo Chaín ***@***.***>:

…

What's the best UX for you? setting an env var to set the proxy or via flag? -- Gus On October 12, 2021, GitHub ***@***.***> wrote: > Right now I'm using an http proxy for web browsing (only allows > connections to ports 80/443). My organization uses squid to offer this > service. > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2 (comment)- 940973072>, or unsubscribe <https://github.com/notifications/unsubscribe- auth/AAJ2Q6KYAIFMGDXYULJY6G3UGQT2BANCNFSM5FVRUZYA>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub[#2 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AKY5GQR2SJZEGNR2A3FBYRTUGQ2T7ANCNFSM5FVRUZYA]. Triage notifications on the go with GitHub Mobile for iOS[https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675] or Android[https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub]. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACQAAAAkCAYAAADhAJiYAAAABHNCSVQICAgIfAhkiAAAABxJREFUWIXtwTEBAAAAwqD1T20Hb6AAAAAAAH4DFGQAAUvJX8QAAAAASUVORK5CYII=###24x24:true###][Tracking image][https://github.com/notifications/beacon/AKY5GQWRWWZVCK2SWOXQVELUGQ2T7A5CNFSM5FVRUZYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHALNGTI.gif]

[qustavo]

Yes I think that makes sense are there any environment variable name standard for CLI applications?
Otherwise I'm thinking about PROXY=.
On the other side, I think that it is difficult to document that, and that makes me think that flags can be useful too.

[samthelion17]

Actually, standard environment variable names for proxy are http_proxy and https_proxy, this way if the user has a proxy configured in system settings there will be no need to set the proxy again before running mempool-cli.