Change LessThan and GreaterThan "limit" to "value"

This is more consistent with other matchers:
- Equals takes a "value"
- Contains takes "values"

Author: charjr

src/Matcher/Matcher/GreaterThan.php

@@ -18,7 +18,7 @@
     public function __construct(
         private Field $field,
         #[FilterOrValidator(new ToNumber())]
-        private float|int $limit,
+        private float|int $value,
         private bool $inclusive = true,
     ) {}
 
@@ -28,7 +28,7 @@ public function matches(DTO $dto): bool
 
         return is_numeric($value)
             && ($this->inclusive
-                ? $value >= $this->limit
-                : $value > $this->limit);
+                ? $value >= $this->value
+                : $value > $this->value);
     }
 }

src/Matcher/Matcher/LessThan.php

@@ -18,7 +18,7 @@
     public function __construct(
         private Field $field,
         #[FilterOrValidator(new ToNumber())]
-        private float|int $limit,
+        private float|int $value,
         private bool $inclusive = true,
     ) {}
 
@@ -28,7 +28,7 @@ public function matches(DTO $dto): bool
 
         return is_numeric($value)
             && ($this->inclusive
-                ? $value <= $this->limit
-                : $value < $this->limit);
+                ? $value <= $this->value
+                : $value < $this->value);
     }
 }

tests/unit/Matcher/MatcherFactory/GreaterThanTest.php

@@ -42,7 +42,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => 1,
+                'value' => 1,
             ],
         ];
         yield 'implicitly >= "1"' => [
@@ -53,7 +53,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => '1',
+                'value' => '1',
             ],
         ];
         yield 'implicitly >= 3.14' => [
@@ -64,7 +64,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => 3.14,
+                'value' => 3.14,
             ],
         ];
 
@@ -76,7 +76,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => 2,
+                'value' => 2,
                 'inclusive' => true,
             ],
         ];
@@ -88,7 +88,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => '2',
+                'value' => '2',
                 'inclusive' => true,
             ],
         ];
@@ -100,7 +100,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => 9.81,
+                'value' => 9.81,
                 'inclusive' => true,
             ],
         ];
@@ -113,7 +113,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => 3,
+                'value' => 3,
                 'inclusive' => false,
             ],
         ];
@@ -125,7 +125,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => '3',
+                'value' => '3',
                 'inclusive' => false,
             ],
         ];

tests/unit/Matcher/MatcherFactory/LessThanTest.php

@@ -42,7 +42,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => 1,
+                'value' => 1,
             ],
         ];
         yield 'implicitly <= "1"' => [
@@ -53,7 +53,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => '1',
+                'value' => '1',
             ],
         ];
         yield 'implicitly <= 3.14' => [
@@ -64,7 +64,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => 3.14,
+                'value' => 3.14,
             ],
         ];
 
@@ -76,7 +76,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => 2,
+                'value' => 2,
                 'inclusive' => true,
             ],
         ];
@@ -88,7 +88,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => '2',
+                'value' => '2',
                 'inclusive' => true,
             ],
         ];
@@ -100,7 +100,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => 9.81,
+                'value' => 9.81,
                 'inclusive' => true,
             ],
         ];
@@ -113,7 +113,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => 3,
+                'value' => 3,
                 'inclusive' => false,
             ],
         ];
@@ -125,7 +125,7 @@ public static function provideConfigs(): \Generator
             ),
             [
                 'field' => ['path', 'pet', 'age'],
-                'limit' => '3',
+                'value' => '3',
                 'inclusive' => false,
             ],
         ];