Skip to content

Commit 8491746

Browse files
anntzeranntzer
committed
Shorten/clarify definition of extension types.
Moving the PyModule_AddObject call out of init_type makes it clearer which types are added to the module globals are which ones are not. Static variables are always zero-inited (this is part of the C++ standard), therefore various memset zeroing calls can be removed.
1 parent 3eadeac commit 8491746

File tree

5 files changed

+158
-230
lines changed

5 files changed

+158
-230
lines changed

‎src/_backend_agg_wrapper.cpp‎

Lines changed: 30 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ typedef struct
1212
Py_ssize_t suboffsets[3];
1313
} PyRendererAgg;
1414

15+
static PyTypeObject PyRendererAggType;
16+
1517
typedef struct
1618
{
1719
PyObject_HEAD
@@ -21,6 +23,8 @@ typedef struct
2123
Py_ssize_t suboffsets[3];
2224
} PyBufferRegion;
2325

26+
static PyTypeObject PyBufferRegionType;
27+
2428

2529
/**********************************************************************
2630
* BufferRegion
@@ -114,9 +118,7 @@ int PyBufferRegion_get_buffer(PyBufferRegion *self, Py_buffer *buf, int flags)
114118
return 1;
115119
}
116120

117-
static PyTypeObject PyBufferRegionType;
118-
119-
static PyTypeObject *PyBufferRegion_init_type(PyObject *m, PyTypeObject *type)
121+
static PyTypeObject *PyBufferRegion_init_type()
120122
{
121123
static PyMethodDef methods[] = {
122124
{ "to_string", (PyCFunction)PyBufferRegion_to_string, METH_NOARGS, NULL },
@@ -128,26 +130,17 @@ static PyTypeObject *PyBufferRegion_init_type(PyObject *m, PyTypeObject *type)
128130
};
129131

130132
static PyBufferProcs buffer_procs;
131-
memset(&buffer_procs, 0, sizeof(PyBufferProcs));
132133
buffer_procs.bf_getbuffer = (getbufferproc)PyBufferRegion_get_buffer;
133134

134-
memset(type, 0, sizeof(PyTypeObject));
135-
type->tp_name = "matplotlib.backends._backend_agg.BufferRegion";
136-
type->tp_basicsize = sizeof(PyBufferRegion);
137-
type->tp_dealloc = (destructor)PyBufferRegion_dealloc;
138-
type->tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE;
139-
type->tp_methods = methods;
140-
type->tp_new = PyBufferRegion_new;
141-
type->tp_as_buffer = &buffer_procs;
142-
143-
if (PyType_Ready(type) < 0) {
144-
return NULL;
145-
}
146-
147-
/* Don't need to add to module, since you can't create buffer
148-
regions directly from Python */
135+
PyBufferRegionType.tp_name = "matplotlib.backends._backend_agg.BufferRegion";
136+
PyBufferRegionType.tp_basicsize = sizeof(PyBufferRegion);
137+
PyBufferRegionType.tp_dealloc = (destructor)PyBufferRegion_dealloc;
138+
PyBufferRegionType.tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE;
139+
PyBufferRegionType.tp_methods = methods;
140+
PyBufferRegionType.tp_new = PyBufferRegion_new;
141+
PyBufferRegionType.tp_as_buffer = &buffer_procs;
149142

150-
return type;
143+
return &PyBufferRegionType;
151144
}
152145

153146
/**********************************************************************
@@ -592,9 +585,7 @@ static PyObject *PyRendererAgg_restore_region(PyRendererAgg *self, PyObject *arg
592585
Py_RETURN_NONE;
593586
}
594587

595-
PyTypeObject PyRendererAggType;
596-
597-
static PyTypeObject *PyRendererAgg_init_type(PyObject *m, PyTypeObject *type)
588+
static PyTypeObject *PyRendererAgg_init_type()
598589
{
599590
static PyMethodDef methods[] = {
600591
{"draw_path", (PyCFunction)PyRendererAgg_draw_path, METH_VARARGS, NULL},
@@ -614,28 +605,18 @@ static PyTypeObject *PyRendererAgg_init_type(PyObject *m, PyTypeObject *type)
614605
};
615606

616607
static PyBufferProcs buffer_procs;
617-
memset(&buffer_procs, 0, sizeof(PyBufferProcs));
618608
buffer_procs.bf_getbuffer = (getbufferproc)PyRendererAgg_get_buffer;
619609

620-
memset(type, 0, sizeof(PyTypeObject));
621-
type->tp_name = "matplotlib.backends._backend_agg.RendererAgg";
622-
type->tp_basicsize = sizeof(PyRendererAgg);
623-
type->tp_dealloc = (destructor)PyRendererAgg_dealloc;
624-
type->tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE;
625-
type->tp_methods = methods;
626-
type->tp_init = (initproc)PyRendererAgg_init;
627-
type->tp_new = PyRendererAgg_new;
628-
type->tp_as_buffer = &buffer_procs;
629-
630-
if (PyType_Ready(type) < 0) {
631-
return NULL;
632-
}
610+
PyRendererAggType.tp_name = "matplotlib.backends._backend_agg.RendererAgg";
611+
PyRendererAggType.tp_basicsize = sizeof(PyRendererAgg);
612+
PyRendererAggType.tp_dealloc = (destructor)PyRendererAgg_dealloc;
613+
PyRendererAggType.tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE;
614+
PyRendererAggType.tp_methods = methods;
615+
PyRendererAggType.tp_init = (initproc)PyRendererAgg_init;
616+
PyRendererAggType.tp_new = PyRendererAgg_new;
617+
PyRendererAggType.tp_as_buffer = &buffer_procs;
633618

634-
if (PyModule_AddObject(m, "RendererAgg", (PyObject *)type)) {
635-
return NULL;
636-
}
637-
638-
return type;
619+
return &PyRendererAggType;
639620
}
640621

641622
static struct PyModuleDef moduledef = { PyModuleDef_HEAD_INIT, "_backend_agg" };
@@ -644,26 +625,16 @@ static struct PyModuleDef moduledef = { PyModuleDef_HEAD_INIT, "_backend_agg" };
644625

645626
PyMODINIT_FUNC PyInit__backend_agg(void)
646627
{
647-
PyObject *m;
648-
649628
import_array();
650-
651-
m = PyModule_Create(&moduledef);
652-
653-
if (m == NULL) {
654-
return NULL;
655-
}
656-
657-
if (!PyRendererAgg_init_type(m, &PyRendererAggType)) {
658-
Py_DECREF(m);
659-
return NULL;
660-
}
661-
662-
if (!PyBufferRegion_init_type(m, &PyBufferRegionType)) {
663-
Py_DECREF(m);
629+
PyObject *m;
630+
if (!(m = PyModule_Create(&moduledef))
631+
|| prepare_and_add_type(PyRendererAgg_init_type(), m)
632+
// BufferRegion is not constructible from Python, thus not added to the module.
633+
|| PyType_Ready(PyBufferRegion_init_type())
634+
) {
635+
Py_XDECREF(m);
664636
return NULL;
665637
}
666-
667638
return m;
668639
}
669640

‎src/_macosx.m‎

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include <ApplicationServices/ApplicationServices.h>
44
#include <sys/socket.h>
55
#include <Python.h>
6+
#include "mplutils.h"
67

78
#ifndef PYPY
89
/* Remove this once Python is fixed: https://bugs.python.org/issue23237 */
@@ -1934,23 +1935,16 @@ static void context_cleanup(const void* info)
19341935

19351936
PyObject* PyInit__macosx(void)
19361937
{
1937-
if (PyType_Ready(&FigureCanvasType) < 0
1938-
|| PyType_Ready(&FigureManagerType) < 0
1939-
|| PyType_Ready(&NavigationToolbar2Type) < 0
1940-
|| PyType_Ready(&TimerType) < 0)
1941-
return NULL;
1942-
1943-
PyObject *module = PyModule_Create(&moduledef);
1944-
if (!module) {
1938+
PyObject *m;
1939+
if (!(m = PyModule_Create(&moduledef))
1940+
|| prepare_and_add_type(&FigureCanvasType, m)
1941+
|| prepare_and_add_type(&FigureManagerType, m)
1942+
|| prepare_and_add_type(&NavigationToolbar2Type, m)
1943+
|| prepare_and_add_type(&TimerType, m)) {
1944+
Py_XDECREF(m);
19451945
return NULL;
19461946
}
1947-
1948-
PyModule_AddObject(module, "FigureCanvas", (PyObject*) &FigureCanvasType);
1949-
PyModule_AddObject(module, "FigureManager", (PyObject*) &FigureManagerType);
1950-
PyModule_AddObject(module, "NavigationToolbar2", (PyObject*) &NavigationToolbar2Type);
1951-
PyModule_AddObject(module, "Timer", (PyObject*) &TimerType);
1952-
1953-
return module;
1947+
return m;
19541948
}
19551949

19561950
#pragma GCC visibility pop

‎src/ft2font_wrapper.cpp‎

Lines changed: 40 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ typedef struct
3333
Py_ssize_t suboffsets[2];
3434
} PyFT2Image;
3535

36+
static PyTypeObject PyFT2ImageType;
37+
3638
static PyObject *PyFT2Image_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
3739
{
3840
PyFT2Image *self;
@@ -121,9 +123,7 @@ static int PyFT2Image_get_buffer(PyFT2Image *self, Py_buffer *buf, int flags)
121123
return 1;
122124
}
123125

124-
static PyTypeObject PyFT2ImageType;
125-
126-
static PyTypeObject *PyFT2Image_init_type(PyObject *m, PyTypeObject *type)
126+
static PyTypeObject* PyFT2Image_init_type()
127127
{
128128
static PyMethodDef methods[] = {
129129
{"draw_rect", (PyCFunction)PyFT2Image_draw_rect, METH_VARARGS, PyFT2Image_draw_rect__doc__},
@@ -132,28 +132,18 @@ static PyTypeObject *PyFT2Image_init_type(PyObject *m, PyTypeObject *type)
132132
};
133133

134134
static PyBufferProcs buffer_procs;
135-
memset(&buffer_procs, 0, sizeof(PyBufferProcs));
136135
buffer_procs.bf_getbuffer = (getbufferproc)PyFT2Image_get_buffer;
137136

138-
memset(type, 0, sizeof(PyTypeObject));
139-
type->tp_name = "matplotlib.ft2font.FT2Image";
140-
type->tp_basicsize = sizeof(PyFT2Image);
141-
type->tp_dealloc = (destructor)PyFT2Image_dealloc;
142-
type->tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE;
143-
type->tp_methods = methods;
144-
type->tp_new = PyFT2Image_new;
145-
type->tp_init = (initproc)PyFT2Image_init;
146-
type->tp_as_buffer = &buffer_procs;
147-
148-
if (PyType_Ready(type) < 0) {
149-
return NULL;
150-
}
137+
PyFT2ImageType.tp_name = "matplotlib.ft2font.FT2Image";
138+
PyFT2ImageType.tp_basicsize = sizeof(PyFT2Image);
139+
PyFT2ImageType.tp_dealloc = (destructor)PyFT2Image_dealloc;
140+
PyFT2ImageType.tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE;
141+
PyFT2ImageType.tp_methods = methods;
142+
PyFT2ImageType.tp_new = PyFT2Image_new;
143+
PyFT2ImageType.tp_init = (initproc)PyFT2Image_init;
144+
PyFT2ImageType.tp_as_buffer = &buffer_procs;
151145

152-
if (PyModule_AddObject(m, "FT2Image", (PyObject *)type)) {
153-
return NULL;
154-
}
155-
156-
return type;
146+
return &PyFT2ImageType;
157147
}
158148

159149
/**********************************************************************
@@ -212,7 +202,7 @@ static PyObject *PyGlyph_get_bbox(PyGlyph *self, void *closure)
212202
"llll", self->bbox.xMin, self->bbox.yMin, self->bbox.xMax, self->bbox.yMax);
213203
}
214204

215-
static PyTypeObject *PyGlyph_init_type(PyObject *m, PyTypeObject *type)
205+
static PyTypeObject *PyGlyph_init_type()
216206
{
217207
static PyMemberDef members[] = {
218208
{(char *)"width", T_LONG, offsetof(PyGlyph, width), READONLY, (char *)""},
@@ -232,22 +222,14 @@ static PyTypeObject *PyGlyph_init_type(PyObject *m, PyTypeObject *type)
232222
{NULL}
233223
};
234224

235-
memset(type, 0, sizeof(PyTypeObject));
236-
type->tp_name = "matplotlib.ft2font.Glyph";
237-
type->tp_basicsize = sizeof(PyGlyph);
238-
type->tp_dealloc = (destructor)PyGlyph_dealloc;
239-
type->tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE;
240-
type->tp_members = members;
241-
type->tp_getset = getset;
242-
243-
if (PyType_Ready(type) < 0) {
244-
return NULL;
245-
}
246-
247-
/* Don't need to add to module, since you can't create glyphs
248-
directly from Python */
225+
PyGlyphType.tp_name = "matplotlib.ft2font.Glyph";
226+
PyGlyphType.tp_basicsize = sizeof(PyGlyph);
227+
PyGlyphType.tp_dealloc = (destructor)PyGlyph_dealloc;
228+
PyGlyphType.tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE;
229+
PyGlyphType.tp_members = members;
230+
PyGlyphType.tp_getset = getset;
249231

250-
return type;
232+
return &PyGlyphType;
251233
}
252234

253235
/**********************************************************************
@@ -265,6 +247,8 @@ typedef struct
265247
Py_ssize_t suboffsets[2];
266248
} PyFT2Font;
267249

250+
static PyTypeObject PyFT2FontType;
251+
268252
static unsigned long read_from_file_callback(FT_Stream stream,
269253
unsigned long offset,
270254
unsigned char *buffer,
@@ -312,8 +296,6 @@ static void close_file_callback(FT_Stream stream)
312296
PyErr_Restore(type, value, traceback);
313297
}
314298

315-
static PyTypeObject PyFT2FontType;
316-
317299
static PyObject *PyFT2Font_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
318300
{
319301
PyFT2Font *self;
@@ -1449,7 +1431,7 @@ static int PyFT2Font_get_buffer(PyFT2Font *self, Py_buffer *buf, int flags)
14491431
return 1;
14501432
}
14511433

1452-
static PyTypeObject *PyFT2Font_init_type(PyObject *m, PyTypeObject *type)
1434+
static PyTypeObject *PyFT2Font_init_type()
14531435
{
14541436
static PyGetSetDef getset[] = {
14551437
{(char *)"postscript_name", (getter)PyFT2Font_postscript_name, NULL, NULL, NULL},
@@ -1504,30 +1486,20 @@ static PyTypeObject *PyFT2Font_init_type(PyObject *m, PyTypeObject *type)
15041486
};
15051487

15061488
static PyBufferProcs buffer_procs;
1507-
memset(&buffer_procs, 0, sizeof(PyBufferProcs));
15081489
buffer_procs.bf_getbuffer = (getbufferproc)PyFT2Font_get_buffer;
15091490

1510-
memset(type, 0, sizeof(PyTypeObject));
1511-
type->tp_name = "matplotlib.ft2font.FT2Font";
1512-
type->tp_doc = PyFT2Font_init__doc__;
1513-
type->tp_basicsize = sizeof(PyFT2Font);
1514-
type->tp_dealloc = (destructor)PyFT2Font_dealloc;
1515-
type->tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE;
1516-
type->tp_methods = methods;
1517-
type->tp_getset = getset;
1518-
type->tp_new = PyFT2Font_new;
1519-
type->tp_init = (initproc)PyFT2Font_init;
1520-
type->tp_as_buffer = &buffer_procs;
1521-
1522-
if (PyType_Ready(type) < 0) {
1523-
return NULL;
1524-
}
1525-
1526-
if (PyModule_AddObject(m, "FT2Font", (PyObject *)type)) {
1527-
return NULL;
1528-
}
1491+
PyFT2FontType.tp_name = "matplotlib.ft2font.FT2Font";
1492+
PyFT2FontType.tp_doc = PyFT2Font_init__doc__;
1493+
PyFT2FontType.tp_basicsize = sizeof(PyFT2Font);
1494+
PyFT2FontType.tp_dealloc = (destructor)PyFT2Font_dealloc;
1495+
PyFT2FontType.tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE;
1496+
PyFT2FontType.tp_methods = methods;
1497+
PyFT2FontType.tp_getset = getset;
1498+
PyFT2FontType.tp_new = PyFT2Font_new;
1499+
PyFT2FontType.tp_init = (initproc)PyFT2Font_init;
1500+
PyFT2FontType.tp_as_buffer = &buffer_procs;
15291501

1530-
return type;
1502+
return &PyFT2FontType;
15311503
}
15321504

15331505
static struct PyModuleDef moduledef = { PyModuleDef_HEAD_INIT, "ft2font" };
@@ -1547,11 +1519,12 @@ PyMODINIT_FUNC PyInit_ft2font(void)
15471519
FT_Library_Version(_ft2Library, &major, &minor, &patch);
15481520
snprintf(version_string, sizeof(version_string), "%d.%d.%d", major, minor, patch);
15491521

1550-
PyObject *m = PyModule_Create(&moduledef);
1551-
if (!m ||
1552-
!PyFT2Image_init_type(m, &PyFT2ImageType) ||
1553-
!PyGlyph_init_type(m, &PyGlyphType) ||
1554-
!PyFT2Font_init_type(m, &PyFT2FontType) ||
1522+
PyObject *m;
1523+
if (!(m = PyModule_Create(&moduledef)) ||
1524+
prepare_and_add_type(PyFT2Image_init_type(), m) ||
1525+
prepare_and_add_type(PyFT2Font_init_type(), m) ||
1526+
// Glyph is not constructible from Python, thus not added to the module.
1527+
PyType_Ready(PyGlyph_init_type()) ||
15551528
PyModule_AddStringConstant(m, "__freetype_version__", version_string) ||
15561529
PyModule_AddStringConstant(m, "__freetype_build_type__", STRINGIFY(FREETYPE_BUILD_TYPE)) ||
15571530
PyModule_AddIntConstant(m, "SCALABLE", FT_FACE_FLAG_SCALABLE) ||

‎src/mplutils.h‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,20 @@ enum {
4646

4747
const size_t NUM_VERTICES[] = { 1, 1, 1, 2, 3, 1 };
4848

49+
inline int prepare_and_add_type(PyTypeObject *type, PyObject *module)
50+
{
51+
if (PyType_Ready(type)) {
52+
return -1;
53+
}
54+
char const* ptr = strrchr(type->tp_name, '.');
55+
if (!ptr) {
56+
PyErr_SetString(PyExc_ValueError, "tp_name should be a qualified name");
57+
return -1;
58+
}
59+
if (PyModule_AddObject(module, ptr + 1, (PyObject *)type)) {
60+
return -1;
61+
}
62+
return 0;
63+
}
64+
4965
#endif

0 commit comments

Comments
 (0)