Make rubocop happy

Author: ellnix

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2025-03-14 19:22:00 UTC using RuboCop version 1.27.0.
+# on 2025-03-24 19:18:19 UTC using RuboCop version 1.27.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -66,7 +66,7 @@ Lint/UnusedMethodArgument:
   Exclude:
     - 'lib/meilisearch-rails.rb'
 
-# Offense count: 13
+# Offense count: 15
 # Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 105
@@ -82,12 +82,12 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Max: 171
 
-# Offense count: 9
+# Offense count: 11
 # Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
   Max: 28
 
-# Offense count: 20
+# Offense count: 23
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
   Max: 102
@@ -97,7 +97,7 @@ Metrics/MethodLength:
 Metrics/ModuleLength:
   Max: 437
 
-# Offense count: 8
+# Offense count: 9
 # Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
   Max: 35
@@ -139,7 +139,7 @@ RSpec/ContextWording:
     - 'spec/options_spec.rb'
     - 'spec/system/tech_shop_spec.rb'
 
-# Offense count: 61
+# Offense count: 72
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 16
@@ -177,11 +177,12 @@ RSpec/VerifiedDoubles:
   Exclude:
     - 'spec/configuration_spec.rb'
 
-# Offense count: 3
+# Offense count: 6
 # Configuration parameters: ForbiddenMethods, AllowedMethods.
 # ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all
 Rails/SkipsModelValidations:
   Exclude:
+    - 'spec/federated_search_spec.rb'
     - 'spec/multi_search_spec.rb'
 
 # Offense count: 2
@@ -240,7 +241,7 @@ Style/StringLiterals:
   Exclude:
     - 'spec/ms_clean_up_job_spec.rb'
 
-# Offense count: 16
+# Offense count: 20
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https

spec/federated_search_spec.rb

@@ -9,7 +9,6 @@
     [Book, Color, Product].each(&:delete_all)
     [Book, Color, Product].each(&:clear_index!)
 
-    # rubocop:disable Rails::SkipsModelValidations
     Product.insert_all([
                          { name: 'palm pixi plus', href: 'ebay', tags: ['terrible'] },
                          { name: 'lg vortex', href: 'ebay', tags: ['decent'] },
@@ -26,7 +25,6 @@
                       { name: 'Steve Jobs', author: 'Walter Isaacson' },
                       { name: 'Moby Dick', author: 'Herman Melville' }
                     ])
-    # rubocop:enable Rails::SkipsModelValidations
 
     [Book, Color, Product].each(&:reindex!)
     AsyncHelper.await_last_task