Skip to content

Commit 6f0035e

Browse files
committed
Use rm_f instead of combining rm with File.exist?
There's a theoretical possibility of a race condition: https://docs.datadoghq.com/security/code_security/static_analysis/static_analysis_rules/ruby-best-practices/atomic-file-operations/ I don't really expect it to happen, but this way is simpler in any case.
1 parent b1b6457 commit 6f0035e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

spec/support/active_record_schema.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
ActiveRecord::Base.raise_in_transactional_callbacks = true if ActiveRecord::Base.respond_to?(:raise_in_transactional_callbacks)
1717

18-
FileUtils.rm('data.sqlite3') if File.exist?('data.sqlite3')
18+
FileUtils.rm_f('data.sqlite3')
1919

2020
def ar_schema
2121
@ar_schema ||= ActiveRecord::Schema.new

spec/support/sequel_db.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ def sequel_db
77
end)
88
end
99

10-
FileUtils.rm('sequel_data.sqlite3') if File.exist?('sequel_data.sqlite3')
10+
FileUtils.rm_f('sequel_data.sqlite3')

0 commit comments

Comments
 (0)