Skip to content

Commit d24433c

Browse files
committed
Duplicated code refactoring
1 parent bf0263a commit d24433c

1 file changed

Lines changed: 10 additions & 11 deletions

File tree

src/Mountebank.php

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -250,9 +250,8 @@ public function fetchImposter($alias)
250250
*/
251251
public function seeImposterHasRequestsByCriteria($alias, array $criteria, $exact_quantity = 1)
252252
{
253-
$port = $this->resolveImposterPort($alias);
254-
$imposter = $this->juggler->getImposter($port);
255-
$requests = $imposter->findRequests($criteria);
253+
$requests = $this->fetchImposter($alias)
254+
->findRequests($criteria);
256255

257256
if (sizeof($requests) > 0) {
258257
$this->debugSection('Matched requests', json_encode($requests, JSON_PRETTY_PRINT));
@@ -276,10 +275,10 @@ public function seeImposterHasRequestsByCriteria($alias, array $criteria, $exact
276275
*/
277276
public function seeImposterHasRequests($alias)
278277
{
279-
$port = $this->resolveImposterPort($alias);
280-
$imposter = $this->juggler->getImposter($port);
281-
282-
$this->assertTrue($imposter->hasRequests(), 'Imposter has requests recorded');
278+
$this->assertTrue(
279+
$this->fetchImposter($alias)->hasRequests(),
280+
'Imposter has requests recorded'
281+
);
283282
}
284283

285284
/**
@@ -289,10 +288,10 @@ public function seeImposterHasRequests($alias)
289288
*/
290289
public function seeImposterHasNoRequests($alias)
291290
{
292-
$port = $this->resolveImposterPort($alias);
293-
$imposter = $this->juggler->getImposter($port);
294-
295-
$this->assertFalse($imposter->hasRequests(), 'Imposter has no request recorded');
291+
$this->assertFalse(
292+
$this->fetchImposter($alias)->hasRequests(),
293+
'Imposter has no request recorded'
294+
);
296295
}
297296

298297
/**

0 commit comments

Comments
 (0)