[Feature Request]: History Preview Window Length

[mattcargile]

OS

• Windows
• macOS
• Linux
• Not specific to an OS

New feature description

I, unfortunately, have some very long run-on one-lines because I was using PSFzf before and it didn't handle multi-line commands.

I was reading through the below code. Would there be a way to set up a config for maxNameLength so it would just wrap the text around? Maybe have some "wrap character".

PowerShellRun/module/PowerShellRun/Private/PSReadLineHistory.ps1

Lines 17 to 48 in a948791

	$historySet = [System.Collections.Generic.Hashset[string]]::new([System.StringComparer]::OrdinalIgnoreCase)
	$entries = [System.Collections.Generic.List[PowerShellRun.SelectorEntry]]::new()
	$maxNameLength = 128
	foreach ($item in $historyItems) {
	$isAdded = $historySet.Add($item.CommandLine)
	if ($isAdded) {
	$entry = [PowerShellRun.SelectorEntry]::new()
	$entry.UserData = $item
	$entry.Name = if ($item.CommandLine.Length -gt $maxNameLength) {
	$item.CommandLine.Substring(0, $maxNameLength)
	} else {
	$item.CommandLine
	}
	$startTime = if ($item.StartTime -ne [DateTime]::MinValue) {
	$localTime = $item.StartTime.ToLocalTime()
	'{0} {1}' -f $localTime.ToShortDateString(), $localTime.ToShortTimeString()
	} else {
	'-'
	}
	$elapsedTime = if ($item.ApproximateElapsedTime -ne [TimeSpan]::Zero) {
	$item.ApproximateElapsedTime.ToString()
	} else {
	'-'
	}
	$entry.Preview = "{0}📅 {1} ⌚ {2}{3}`n`n{4}" -f $PSStyle.Underline, $startTime, $elapsedTime, $PSStyle.UnderlineOff, $item.CommandLine
	$entry.ActionKeys = $actionKeys
	$entries.Add($entry)
	}
	}

I tend to store code that should be a function{} in my history for later use and editing. Bad habit, sure. Just was thinking. I'm fully off PSFzf now. Thanks for putting this together. Lots of work and thought surely! :-)

NOTE 1: Well in thinking about it more, maybe I should just rewrite my own hehe...

[mdgrs-mei]

There is no way to wrap in the preview window or shift the name to show the matches currently. I think that's why I set the maxNameLength here.

However, I noticed that the length limit is not good for long multi-line histories either as they are excluded from search.

Removing maxNameLength is pretty easy but if possible, could you test it out locally if it works for you? The search hit might not be visible but entries are included to the query result at least.

[mdgrs-mei]

Never mind, I removed the maxNameLength in #97 . There was no good reason for the length limit.

[mdgrs-mei]

@mattcargile v0.14.0 has been released including the maxNameLength removal.

If the "wrap character" option for the preview window is still important, I'll have to think about it separately as it's going to be a big work.

[mattcargile]

Yeah it would be really nice if the command would wrap around. Doesn't necessarily need a special character though.

[mdgrs-mei]

Working on the generic text wrapping on this branch:

https://github.com/mdgrs-mei/PowerShellRun/tree/support-preview-wrap-mode

PreviewTextWrapMode option will be added to Theme.

[mdgrs-mei]

Hi @mattcargile,

v0.15.0 has been released. Could you update the module and try this?

$option = Get-PSRunDefaultSelectorOption
$option.Theme.PreviewTextWrapMode = 'Character'
Set-PSRunDefaultSelectorOption $option

I named it [PowerShellRun.TextWrapMode]::Character in case we want to add Word wrapping or custom Delimiter wrapping in the future.

[mattcargile]

Woot! Thank you! 💯 Works great.

[mdgrs-mei]

Cool! Closing this as completed. Thank you.