-
Notifications
You must be signed in to change notification settings - Fork 159
Open
Description
The git rev-parse --short HEAD below resolves to Git hash
Lines 3 to 4 in 34a21a3
| VERSION ?= $(shell git rev-parse --short HEAD) | |
| DOCKER_TAG ?= mccutchen/go-httpbin:$(VERSION) |
Shouldn't the VERSION be based on Git tag, that is, git describe --tags --abbrev=0?
This makes me wonder, is this VERSION actually used for the image tagging?
Perhaps Docker images are tagged following this instruction?
Lines 93 to 95 in 34a21a3
| Use `VERSION` to override the tag value | |
| make imagepush VERSION=v1.2.3 |
If my understanding is correct and there is room for improvement indeed, I can propose PR.
Metadata
Metadata
Assignees
Labels
No labels