template: Don't send git clone output to /dev/null

Previously I'd squelched the output because of the verbosity of the
`detached HEAD` warning when making a shallow clone, but it's not really
necessary anymore given `-c advice.detachedHead=false`. Now that the
`template` test is failing on Travis, I really need to see the output:

https://travis-ci.org/mbland/go-script-bash/jobs/200472791
https://travis-ci.org/mbland/go-script-bash/jobs/200472885

Author: mbland

go-template

@@ -40,14 +40,14 @@ readonly GO_SCRIPT_BASH_CORE="$SCRIPTS_DIR/go-script-bash/go-core.bash"
 readonly GO_SCRIPT_BASH_REPO_URL='https://github.com/mbland/go-script-bash.git'
 
 if [[ ! -e "$GO_SCRIPT_BASH_CORE" ]]; then
-  printf 'Cloning %s into %s...\n' "$GO_SCRIPT_BASH_REPO_URL" \
-    "${GO_SCRIPT_BASH_CORE%/*}"
+  printf "Cloning framework from '%s'...\n" "$GO_SCRIPT_BASH_REPO_URL"
   if ! git clone --depth 1 -c advice.detachedHead=false \
       -b "$GO_SCRIPT_BASH_VERSION" "$GO_SCRIPT_BASH_REPO_URL" \
-      "${GO_SCRIPT_BASH_CORE%/*}" &>/dev/null; then
-    printf 'Failed to clone %s; aborting.\n' "$GO_SCRIPT_BASH_REPO_URL" >&2
+      "${GO_SCRIPT_BASH_CORE%/*}"; then
+    printf "Failed to clone '%s'; aborting.\n" "$GO_SCRIPT_BASH_REPO_URL" >&2
     exit 1
   fi
+  printf "Clone of '%s' successful.\n\n" "$GO_SCRIPT_BASH_REPO_URL"
 fi
 
 . "$GO_SCRIPT_BASH_CORE" "${SCRIPTS_DIR##*/}"

tests/template.bats

@@ -35,10 +35,12 @@ create_template_script() {
   create_template_script "$_GO_CORE_DIR" "$_GO_CORE_VERSION"
   run "$TEST_GO_ROOTDIR/go-template"
 
-  # The script will return an error without a command, but the core repo should
-  # exist as expected.
+  # Without a command argument, the script will print the top-level help and
+  # return an error, but the core repo should exist as expected.
   assert_failure
-  assert_output_matches "Cloning $_GO_CORE_DIR into $TEST_CLONE_DIR\.\.\."
+  assert_output_matches "Cloning framework from '$_GO_CORE_DIR'\.\.\."
+  assert_output_matches "Cloning into '$TEST_CLONE_DIR'\.\.\."
+  assert_output_matches "Clone of '$_GO_CORE_DIR' successful\."$'\n\n'
   assert_output_matches "Usage: $TEST_GO_ROOTDIR/go-template <command>"
   [[ -f "$TEST_GO_ROOTDIR/scripts/go-script-bash/go-core.bash" ]]
 
@@ -51,7 +53,7 @@ create_template_script() {
 @test "$SUITE: fail to clone a nonexistent repo" {
   create_template_script 'bogus-repo-that-does-not-exist'
   run "$TEST_GO_ROOTDIR/go-template"
-  assert_failure \
-    "Cloning bogus-repo-that-does-not-exist into $TEST_CLONE_DIR..." \
-    'Failed to clone bogus-repo-that-does-not-exist; aborting.'
+  assert_failure "Cloning framework from 'bogus-repo-that-does-not-exist'..." \
+    "fatal: repository 'bogus-repo-that-does-not-exist' does not exist" \
+    "Failed to clone 'bogus-repo-that-does-not-exist'; aborting."
 }