kcov: Fix cmake command

Turns out cmake _always_ emits output in the current directory unless the build
directory already exists.

Author: mbland

scripts/lib/kcov

@@ -88,10 +88,11 @@ clone_and_build_kcov() {
 
   @go.printf 'Building kcov...\n'
 
-  if ! cmake "$kcov_dir" || ! make -C "$kcov_dir"; then
-    @go.printf 'Failed to build kcov.\n' >&2
-    return 1
+  if cd "$kcov_dir" >/dev/null && cmake . && make && cd - >/dev/null; then
+    return
   fi
+  @go.printf 'Failed to build kcov.\n' >&2
+  return 1
 }
 
 check_kcov_dev_packages_installed() {

tests/kcov.bats

@@ -85,10 +85,10 @@ write_kcov_go_script() {
   assert_success "apt-get install -y ${KCOV_DEV_PACKAGES[*]}"
 
   run cat "$FAKE_BIN_DIR/cmake.out"
-  assert_success 'tests/kcov'
+  assert_success '.'
 
   run cat "$FAKE_BIN_DIR/make.out"
-  assert_success '-C tests/kcov'
+  assert_success ''
 }
 
 @test "$SUITE: clone and build fails if clone fails" {