Skip to content

Commit 25c5bb3

Browse files
maystudiosclaude
andcommitted
fix(phase-2): resolve lint warnings in Phase 2 code
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 45a30e1 commit 25c5bb3

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

packages/cli/src/commands/github.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1204,7 +1204,7 @@ export const GITHUB_COMMANDS: CommandRegistry = {
12041204
}
12051205

12061206
if (maxsimCommentTimestamps.length > 0) {
1207-
const lastMaxsimComment = maxsimCommentTimestamps.sort().pop()!;
1207+
const lastMaxsimComment = maxsimCommentTimestamps.sort().pop() ?? '';
12081208
if (issue.updatedAt > lastMaxsimComment) {
12091209
report.bodyEdits.push({
12101210
issueUpdatedAt: issue.updatedAt,

packages/cli/tests/unit/github-commands-phase2.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ describe('handle-verification-success handler', () => {
474474

475475
describe('status handler argument validation', () => {
476476
it('returns error when --phase-number is not a valid integer', async () => {
477-
const result = await GITHUB_COMMANDS['status'].handler(['--phase-number', 'abc']);
477+
const result = await GITHUB_COMMANDS.status.handler(['--phase-number', 'abc']);
478478

479479
expect(result.ok).toBe(false);
480480
if (result.ok) throw new Error('Expected ok:false');

packages/cli/tests/unit/github-labels-new.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ describe('MAXSIM_LABELS includes verification:failed', () => {
5656
it('verification:failed has a non-empty description and valid color', () => {
5757
const found = MAXSIM_LABELS.find((l) => l.name === 'verification:failed');
5858
expect(found).toBeDefined();
59-
expect(found!.description.length).toBeGreaterThan(0);
60-
expect(found!.color).toMatch(/^[0-9a-f]{6}$/i);
59+
expect(found?.description.length).toBeGreaterThan(0);
60+
expect(found?.color).toMatch(/^[0-9a-f]{6}$/i);
6161
});
6262

6363
it('has exactly 7 labels (4 type + 2 maxsim + 1 verification)', () => {

0 commit comments

Comments
 (0)