-
Notifications
You must be signed in to change notification settings - Fork 10
Add PHP 8.5 #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add PHP 8.5 #226
Conversation
|
Possible actions:
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #226 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 147 147
===========================================
Files 8 8
Lines 669 669
===========================================
Hits 669 669 ☔ View full report in Codecov by Sentry. |
|
Let's wait for an official 8.5.0 (or .1) release, I'm quite sure all the dependencies will get appropriate updates until then. |
xalopp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmoll I think this should be part of a own PR.
Fixes Issues reported by SonarQube:
https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions
Some of the used GitHub Actions are not up to date (slackapi/slack-github-action, technote-space/workflow-conclusion-action) which might also need attention.
|
@xalopp Could you open a separate PR to update the actions to newer versions and use the SHAs to shut up SonarCube? |
|


Type of PR
Breaking changes
Description
Be prepared for upcoming PHP 8.5 release