add more XML validation and formatting

Author: mmoll

.travis.yml

@@ -23,9 +23,15 @@ before_script:
   - if [ "${DEPENDENCIES}" = "lowest" ]; then composer update --prefer-lowest --prefer-dist --no-interaction --no-progress; fi;
   - if [ "${DEPENDENCIES}" = "highest" ]; then composer update --prefer-dist --no-interaction --no-progress; fi;
   - if [ "${DEPENDENCIES}" = "highest" ]; then pecl install -f ast-1.0.7; fi; # Install AST extension, as phan uses it
+  - export XMLLINT_INDENT="    "
 
 script:
-  - xmllint --noout --schema vendor/squizlabs/php_codesniffer/phpcs.xsd MO4/ruleset.xml # validate MO4's ruleset XML
+  - xmllint --noout --schema vendor/squizlabs/php_codesniffer/phpcs.xsd MO4/ruleset.xml
+  - xmllint --noout --schema vendor/squizlabs/php_codesniffer/phpcs.xsd phpcs.mo4.xml
+  - xmllint --noout --schema vendor/squizlabs/php_codesniffer/phpcs.xsd phpcs.xml.dist
+  - diff -B MO4/ruleset.xml <(xmllint --format MO4/ruleset.xml)
+  - diff -B phpcs.mo4.xml <(xmllint --format phpcs.mo4.xml)
+  - diff -B phpcs.xml.dist <(xmllint --format phpcs.xml.dist)
   - vendor/bin/phpcs -s --standard=MO4 integrationtests/testfile.php # Check, if all the sniffs work with the current dependencies
   - vendor/bin/phpunit # Run tests
   - vendor/bin/phpcs # Stylecheck against PHPCS's ruleset

MO4/ruleset.xml

@@ -80,9 +80,9 @@
     <!-- Require presence of constant visibility -->
     <rule ref="SlevomatCodingStandard.Classes.ClassConstantVisibility"/>
     <!-- Forbid multi constant definition -->
-    <rule ref="SlevomatCodingStandard.Classes.DisallowMultiConstantDefinition" />
+    <rule ref="SlevomatCodingStandard.Classes.DisallowMultiConstantDefinition"/>
     <!-- Forbid multi property definition -->
-    <rule ref="SlevomatCodingStandard.Classes.DisallowMultiPropertyDefinition" />
+    <rule ref="SlevomatCodingStandard.Classes.DisallowMultiPropertyDefinition"/>
     <!-- Forbid empty lines after class/interface/trait opening and before closing braces -->
     <rule ref="SlevomatCodingStandard.Classes.EmptyLinesAroundClassBraces">
         <properties>

phpcs.mo4.xml

@@ -10,7 +10,7 @@
     <exclude-pattern>vendor/*</exclude-pattern>
 
     <arg name="basepath" value="."/>
-    <arg name="colors" />
-    <arg name="parallel" value="75" />
+    <arg name="colors"/>
+    <arg name="parallel" value="75"/>
     <arg value="np"/>
 </ruleset>

phpcs.xml.dist

@@ -8,7 +8,7 @@
     <!--   1. CLI parameters -->
     <!--   2. followed by configuration settings imported from rulesets, first come, first serve -->
     <!--   3. and finally the configuration from this file itself! -->
-    <rule ref="phpcs.mo4.xml" />
+    <rule ref="phpcs.mo4.xml"/>
 
-    <rule ref="vendor/squizlabs/php_codesniffer/phpcs.xml.dist" />
+    <rule ref="vendor/squizlabs/php_codesniffer/phpcs.xml.dist"/>
 </ruleset>