How can we specify boolean columns?

[kristallizer]

Since the prop_type kwarg in PropsBuilder#cast_attribute expects a Class, I'm not able to specify a boolean attribute in the model struct using T::Boolean because it's a type alias (T::Private::Types::TypeAlias)

const :is_active, T::Boolean

When I try to eject a model instance:

Parameter 'prop_type': Expected type Class, got type T::Private::Types::SimplePairUnion with hash 4434194183274143389 (TypeError)
Caller: /ruby/3.3.6/lib/ruby/gems/3.3.0/gems/activerecord-ejection_seat-0.3.2/lib/activerecord-ejection_seat/props_builder.rb:35
Definition: /ruby/3.3.6/lib/ruby/gems/3.3.0/gems/activerecord-ejection_seat-0.3.2/lib/activerecord-ejection_seat/props_builder.rb:39 (PropsBuilder#cast_attribute)

[maxveldink]

@kristallizer I saw you had something for this and I missed it; do you want to reopen? Is this still an issue affecting you?

[kristallizer]

@maxveldink hey, yeah, I actually ended up forking this into the Justworks org and deleted my own fork, so I'm not able to reopen the PR. The only additional change is I used T::Types::Union instead of ::T::Private::Types::SimplePairUnion and the cast_attribute method looks like this:

  sig do
    params(
      attribute: T.untyped,
      prop_type: T.any(T::Class[T.anything], T::Types::Union)
    ).returns(T.untyped)
  end
  def cast_attribute(attribute, prop_type)
    if prop_type.is_a? T::Types::Union
      return attribute if prop_type == T::Boolean

      prop_type.deserialize(attribute) # fallback for other two‐member unions
    elsif prop_type < T::Enum
      prop_type.deserialize(attribute)
    elsif prop_type < T::Struct
      prop_type.new(PropsBuilder.new(model: attribute, target_struct: prop_type).build)
    else
      attribute
    end
  rescue KeyError
    nil
  end

Was there another way you got it working for boolean columns?

[maxveldink]

Yea that seems right to me; when I get home this weekend I'll play round with it. I might have handled this differently in sorbet-schema since I learned more about how Sorbet runtime's internals work, so I might pull in something from there.

I do plan on deprecating this in favor of sorbet-schema once I add the AR serializer, just as an FYI

[kristallizer]

Oh, interesting, I'll keep an eye on that repo. Thanks!